[PATCH] D49227: Override a bit fields layout from an external source

2018-07-13 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D49227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337047: Use external layout information to layout bit-fields for MS ABI. (authored by rsmith, committed by ). Repository: rL LLVM https://reviews.llvm.org/D49227 Files:

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-13 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337047: Use external layout information to layout bit-fields for MS ABI. (authored by rsmith, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-13 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov updated this revision to Diff 155324. aleksandr.urakov added a comment. Thank you! Yes, I have added a test case for that. If it's OK, can you commit this for me, please? I have no commit access. https://reviews.llvm.org/D49227 Files: lib/AST/RecordLayoutBuilder.cpp

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeGenCXX/override-bit-field-layout.cpp:5-12 +struct S { + short a : 3; + short b : 5; +}; + +void use_structs() { + S ss[sizeof(S)];

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-12 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai resigned from this revision. smeenai added a comment. I'm not familiar enough with this to review it. Repository: rC Clang https://reviews.llvm.org/D49227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-12 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rsmith, mstorsjo, arphaman, whunt, majnemer. aleksandr.urakov added a project: clang. This patch adds a possibility to use an external layout for bit fields. The problem occurred while debugging a Windows application with