[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

2018-08-28 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus abandoned this revision. Szelethus added a comment. In https://reviews.llvm.org/D49986#1192798, @Szelethus wrote: > In https://reviews.llvm.org/D49985#1181568, @NoQ wrote: > > > In https://reviews.llvm.org/D49985#1181564, @dblaikie wrote: > > > > > It looks like concat orders the

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

2018-08-08 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a subscriber: dblaikie. Szelethus added a comment. In https://reviews.llvm.org/D49985#1181568, @NoQ wrote: > In https://reviews.llvm.org/D49985#1181564, @dblaikie wrote: > > > It looks like concat orders the arguments in the same way that the output > > would be (so concat(X,

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

2018-07-30 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Cool! Always bothered me. In https://reviews.llvm.org/D49986#1180403, @george.karpenkov wrote: > I'm a bit confused: does it mean these methods are never called in Clang? This patch *is* for

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

2018-07-30 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. I'm a bit confused: does it mean these methods are never called in Clang? Repository: rC Clang https://reviews.llvm.org/D49986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49986: [ADT] ImmutableList::add parameters are switched

2018-07-30 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, dcoughlin, chandlerc. Herald added a subscriber: cfe-commits. Clang side changes, see https://reviews.llvm.org/D49985. Repository: rC Clang https://reviews.llvm.org/D49986 Files: