[PATCH] D50850: clang: Add triples support for MIPS r6

This revision was automatically updated to reflect the committed changes. Closed by commit rL344608: [driver][mips] Support MIPS R6 target triples (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. https://reviews.llvm.org/D50850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 169810. https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/CodeGen/target-data.c

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa added a comment. In https://reviews.llvm.org/D50850#1250313, @atanasyan wrote: > In https://reviews.llvm.org/D50850#1250285, @wzssyqa wrote: > > > This is really for Clang. I guess you mean that compiler-rt directory also > > need to be patched. > > > If you take a look at the previous

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please rebase this patch against the trunk? Comment at: lib/Driver/ToolChains/Linux.cpp:717 + const StringRef MIPS64R6ELMultiarchIncludeDirs[] = { + "/usr/include/mipsisa64r6el-linux-gnu", +

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. In https://reviews.llvm.org/D50850#1250285, @wzssyqa wrote: > This is really for Clang. I guess you mean that compiler-rt directory also > need to be patched. If you take a look at the previous version of this patch https://reviews.llvm.org/D50850?id=167419, you

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 167630. https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/CodeGen/target-data.c

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa added a comment. This is really for Clang. I guess you mean that compiler-rt directory also need to be patched. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:115 + if (ABIName.empty() && (Triple.getEnvironment() == llvm::Triple::GNUABIN32)) +ABIName = "n32"; +

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at https://reviews.llvm.org/rL343185 already. Could you attach an actual patch brings https://reviews.llvm.org/source/compiler-rt/ support to the Clang driver?

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 167419. Herald added a subscriber: dexonsmith. https://reviews.llvm.org/D50850 Files: include/llvm/ADT/Triple.h lib/Support/Triple.cpp lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp unittests/ADT/TripleTest.cpp Index: unittests/ADT/TripleTest.cpp

Re: [PATCH] D50850: clang: Add triples support for MIPS r6

I updated N32 patch for clang. Simon Atanasyan via Phabricator 于2018年9月27日周四 下午8:23写道： > > atanasyan added a comment. > > Could you please update the patch against the current trunk? > > > Repository: > rC Clang > > https://reviews.llvm.org/D50850 > > > -- YunQiang Su

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa added a subscriber: rsmith. wzssyqa added a comment. I updated N32 patch for clang. Simon Atanasyan via Phabricator 于2018年9月27日周四 下午8:23写道： > atanasyan added a comment. > > Could you please update the patch against the current trunk? > > Repository: > > rC Clang > >

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please update the patch against the current trunk? Repository: rC Clang https://reviews.llvm.org/D50850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 166219. Repository: rC Clang https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 163624. https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/CodeGen/target-data.c

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please include more context to patches sent for review? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/Driver/ToolChains/Linux.cpp:46 TargetTriple.getEnvironment(); +

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 163221. Repository: rC Clang https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you add test cases to cover these changes? Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:115 + if (ABIName.empty() && (Triple.getEnvironment() == llvm::Triple::GNUABIN32)) +ABIName = "n32"; + It looks like this change is