[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

thakis added a comment. Herald added a project: clang. I noticed that this causes memory errors in certain situations. https://bugs.llvm.org/show_bug.cgi?id=42501 has details. Can you take a look? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53457/new/ https://

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

This revision was automatically updated to reflect the committed changes. Closed by commit rC346393: clang-cl: Add "/clang:" pass-through arg support. (authored by hans, committed by ). Repository: rC Clang https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/C

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

hans added a comment. In https://reviews.llvm.org/D53457#1291020, @neerajksingh wrote: > Reid, Hans, or someone else with commit access. If the revision looks good, > could you please submit to SVN? > > Any particular testing I should run beforehand? I ran the clang tests locally > on Windows.

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. Reid, Hans, or someone else with commit access. If the revision looks good, could you please submit to SVN? Any particular testing I should run beforehand? I ran the clang tests locally on Windows. https://reviews.llvm.org/D53457 __

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 173072. neerajksingh marked an inline comment as done. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index: test

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh marked 2 inline comments as done. neerajksingh added a comment. Will update revision... Comment at: test/Driver/cl-options.c:619 + +// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s +// NOCLANG: "--dependent-lib=libcmt" han

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Okay, looks good to me (with a small nit). Comment at: docs/UsersManual.rst:2852 /Brepro Emit an object file which can be reproduced over time + /cla

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 172615. neerajksingh added a comment. Make it clear in the documentation that the /clang flags are added to the end. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

hans added a comment. In https://reviews.llvm.org/D53457#1279191, @neerajksingh wrote: > In https://reviews.llvm.org/D53457#1278579, @hans wrote: > > > The `-Xclang` option has the same issue, and I think `/clang:` should work > > similarly, i.e. `/clang:-MF /clang:`. It's not pretty, but at >

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1278579, @hans wrote: > The `-Xclang` option has the same issue, and I think `/clang:` should work > similarly, i.e. `/clang:-MF /clang:`. It's not pretty, but at least > it's consistent. Yes, that means processing consecutive `/X

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

hans added a comment. In https://reviews.llvm.org/D53457#1277950, @neerajksingh wrote: > In https://reviews.llvm.org/D53457#1277315, @hans wrote: > > > One note about flag ordering: the /clang: flags are concatenated to the > > end of > > the argument list, so in cases where the last flag wi

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171382. neerajksingh added a comment. Fix hans' comments. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index:

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1277315, @hans wrote: > One note about flag ordering: the /clang: flags are concatenated to the end > of > the argument list, so in cases where the last flag wins, the /clang: flags > will be chosen regardless of their order

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

hans added a comment. One note about flag ordering: the /clang: flags are concatenated to the end of the argument list, so in cases where the last flag wins, the /clang: flags will be chosen regardless of their order relative to other flags on the driver command line. This seems a little

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171233. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index: test/Driver/cl-options.c ==

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 171203. neerajksingh retitled this revision from "clang-cl: Add "/Xdriver:" pass-through arg support." to "clang-cl: Add "/clang:" pass-through arg support.". neerajksingh edited the summary of this revision. neerajksingh added a comment. Change the spe