This revision was automatically updated to reflect the committed changes.
Closed by commit rL349204: [test] Capture stderr from tar --version
call as well (authored by mgorny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55443?vs=177265=178296#toc
Repository:
rL LLVM
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55443/new/
https://reviews.llvm.org/D55443
___
cfe-commits mailing list
krytarowski resigned from this revision.
krytarowski added a comment.
Herald added a subscriber: krytarowski.
I don't feel enough comfortable with this Python code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55443/new/
https://reviews.llvm.org/D55443
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: test/lit.cfg.py:100
config.available_features.add('gnutar')
-tar_version.wait()
ruiu wrote:
> Maybe a silly question, but is this OK to remove this line?
Yes. [[
ruiu added inline comments.
Comment at: test/lit.cfg.py:100
config.available_features.add('gnutar')
-tar_version.wait()
Maybe a silly question, but is this OK to remove this line?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55443/new/
mgorny updated this revision to Diff 177265.
mgorny marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55443/new/
https://reviews.llvm.org/D55443
Files:
test/lit.cfg.py
Index: test/lit.cfg.py
MaskRay added inline comments.
Comment at: test/lit.cfg.py:101
+env={'LANG': 'C'})
+sout, serr = tar_version.communicate()
+if 'GNU tar' in sout.decode():
LG, but `serr` can be replaced by `_` if it is not used.
CHANGES SINCE LAST ACTION
ruiu added inline comments.
Comment at: test/lit.cfg.py:99
+stdout=subprocess.PIPE,
+stderr=subprocess.PIPE,
+env={'LANG': 'C'})
ruiu wrote:
> mgorny wrote:
> > MaskRay wrote:
> > > If you don't need stderr, remove
mgorny added a comment.
Sorry, it seems that my reply didn't go through.
Comment at: test/lit.cfg.py:99
+stdout=subprocess.PIPE,
+stderr=subprocess.PIPE,
+env={'LANG': 'C'})
MaskRay wrote:
> If you don't need stderr, remove
ruiu added inline comments.
Comment at: test/lit.cfg.py:99
+stdout=subprocess.PIPE,
+stderr=subprocess.PIPE,
+env={'LANG': 'C'})
MaskRay wrote:
> If you don't need stderr, remove `stderr=subprocess.PIPE,`
>
> `subprocess.Popen followed
mgorny updated this revision to Diff 177250.
mgorny marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55443/new/
https://reviews.llvm.org/D55443
Files:
test/lit.cfg.py
Index: test/lit.cfg.py
MaskRay added inline comments.
Comment at: test/lit.cfg.py:99
+stdout=subprocess.PIPE,
+stderr=subprocess.PIPE,
+env={'LANG': 'C'})
If you don't need stderr, remove `stderr=subprocess.PIPE,`
`subprocess.Popen followed by communicate()`
mgorny created this revision.
mgorny added reviewers: krytarowski, ikudrin, pcc, zturner.
mgorny added a project: lld.
Herald added subscribers: llvm-commits, MaskRay.
Capture the stderr from 'tar --version' call as otherwise error messages
spill onto user's terminal unnecessarily (e.g. on NetBSD
13 matches
Mail list logo