[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

This revision was automatically updated to reflect the committed changes. Dor1s marked an inline comment as done. Closed by commit rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. (authored by Dor1s, committed by ). Changed prior to commit:

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s marked 2 inline comments as done. Dor1s added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. +

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s updated this revision to Diff 184766. Dor1s added a comment. Herald added a project: clang. Clarify that only linkers other than LLD are affected. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 Files:

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

morehouse added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. + Maybe add "for linkers

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s added a comment. I'm not sure if I wrote down the information correctly, PTAL :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___ cfe-commits mailing list

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s created this revision. Dor1s added a reviewer: morehouse. Herald added a subscriber: cfe-commits. There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it would be also helpful to leave a note in the docs to prevent users from running into issues, e.g.