[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4264e7bbfdb3: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D57829?vs=2276

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/linker-options.cu:1-5 +// RUN: %clang_cc1 -emit-llvm -o - -fcuda-is-device -fms-extensions -x hip %s \ +// RUN: -fno-autolink -triple amdgcn-amd-amdhsa \ +// RUN: | FileC

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Nit about test name and test scope. Comment at: clang/test/CodeGenCUDA/linker-options.cu:1-5 +// RUN: %clang_cc1 -emit-llvm -o - -fcuda-is-device -fms-extensions -

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl updated this revision to Diff 227636. yaxunl added a comment. revised by Artem's comments. Also fix test since linker option only supported on windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 Files: clang/lib/Driver/ToolChains/

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Ac

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Action::OFK_HIP)) +Default = false; --

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Ac

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Action::OFK_HIP)) +Default = false; --

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl added a comment. In D57829#1729094 , @tra wrote: > Could you, please, give us a bit more context and provide more info for the > questions @rjmccall and I asked before? > > Is the problem specifically because autolink is not supported on device sid

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. Could you, please, give us a bit more context and provide more info for the questions @rjmccall and I asked before? Is the problem specifically because autolink is not supported on device side? Or is disabling autolink just a convoluted way to avoid calling EmitModuleLinkO

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl updated this revision to Diff 227216. yaxunl retitled this revision from "[HIP] Disable emitting llvm.linker.options in device compilation" to "[CUDA][HIP] Disable emitting llvm.linker.options in device compilation". yaxunl edited the summary of this revision. yaxunl added a comment. use