[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; thakis wrote: > aaron.ballman wrote: > > Given that static assertions are member declarations of a struct, should > > this "replay" the static

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; aaron.ballman wrote: > Given that static assertions are member declarations of a struct, should this > "repl

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; Given that static assertions are member declarations of a struct, should this "replay" the static asserts from the interface (including failin

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rC356148: Objective-C++11: Support static_assert() in @interface/@implementation ivar… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190534. thakis edited the summary of this revision. thakis added a comment. extension CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDec

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. Ah, got it, thanks for explaining! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/Features.def:121 FEATURE(objc_class_property, LangOpts.ObjC) +FEATURE(objc_c_static_assert, true) +FEATURE(objc_cxx_static_assert, LangOpts.CPlusPlus11) thakis wrote: > erik.pilkington

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/include/clang/Basic/Features.def:121 FEATURE(objc_class_property, LangOpts.ObjC) +FEATURE(objc_c_static_assert, true) +FEATURE(objc_cxx_static_assert, LangOpts.CPlusPlus11)

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190521. thakis added a comment. c89 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseObjc.cpp clang/lib/

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, after one more comment in Features.def :) Comment at: clang/include/clang/Basic/Features.def:121 FEATURE(objc_class_property, LangOpts.ObjC) +FEATURE

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. Seems like this wasn't convincing, so now with two separate feature flags. I went with the shorter name, since adding "interface_" isn't just longer but also misleading, since this also works in @implementation ivar blocks now. CHANGES SINCE LAST ACTION https://review

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190418. thakis edited the summary of this revision. thakis added a comment. two features CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/Parse

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > erik.pilkington wrote: > > thakis wrote: > > >

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added reviewers: rsmith, aaron.ballman. aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + erik.pilkington wrote: > thakis wrote: > > aaron.b

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

erik.pilkington added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + thakis wrote: > aaron.ballman wrote: > > thakis wrote: > > > aaron.ballman wrote: > > > > Can you try

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190172. thakis marked an inline comment as done. thakis added a comment. test c++98 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDecl.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > thakis wrote: > > aaron.ballman wrote: > > > Can you try explicitly specifying C++98 as

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + thakis wrote: > aaron.ballman wrote: > > Can you try explicitly specifying C++98 as the underlying langu

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3892-3893 /// +/// Note that a struct declaration refers to a declaration in a struct, +/// not to the declaration of a struct. +/// aaron.ballman wr

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3892-3893 /// +/// Note that a struct declaration refers to a declaration in a struct, +/// not to the declaration of a struct. +/// Seems to be unrelated to this patch? Feel free to

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. (Since jfb added a few people who might not have seen it: This was discussed in "Objective-C++11: concerns about adding static_assert support to @interface / @implementation?" on cfe-dev) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis created this revision. thakis added a reviewer: erik.pilkington. This adds support for static_assert() (and _Static_assert()) in @interface/@implementation ivar lists and in @interface method declarations. It was already supported in @implementation blocks outside of the ivar lists. The