[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362600: [ARM] Allow -march=foo+fp to vary with foo (authored by SjoerdMeijer, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Fair enough, I don't think we currently try to diagnose any other invalid combinations of features. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202934. SjoerdMeijer added a comment. Hi Oliver, thanks for your comments! This was the easy one, they have been added: > I also don't see any tests for the negated forms of either feature. The trouble begun with this: > +fp.dp, but the FPU is

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard added inline comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:551 + + // If the default FPU already supports double-precision, or if + // there is no double-prec FPU that extends it, then "fp.dp" Could you also add tests for the

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202433. SjoerdMeijer added a comment. This time with tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/Driver/ToolChains/Arch/ARM.h

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added a comment. Ah yes, the school boy error! ;-) Actually, there was a test, but in a different patch; I will move it to here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. This still needs tests adding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202388. SjoerdMeijer added a comment. This addresses @t.p.northover comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

t.p.northover added inline comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:476 -StringRef ARM::getArchExtFeature(StringRef ArchExt) { - if (ArchExt.startswith("no")) { -StringRef ArchExtBase(ArchExt.substr(2)); -for (const auto AE : ARCHExtNames) { -

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

simon_tatham marked 3 inline comments as done. simon_tatham added a comment. The aim of this change is that it will apply to the v8.1-M (mainline) architecture introduced in D60698 , in which `+fp` //won't// be the default: `-march=armv8.1m.main` by itself gives

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

t.p.northover added a comment. This needs some tests. I'm also not quite sure when you'd use bare "+fp", if it's the default anyway. Comment at: llvm/lib/Support/ARMTargetParser.cpp:476 -StringRef ARM::getArchExtFeature(StringRef ArchExt) { - if (ArchExt.startswith("no"))

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. Now, when clang processes an argument of the form