[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL362855: [analyzer] Add werror flag for analyzer warnings (authored by kfischer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

Szelethus accepted this revision. Szelethus added a comment. Comment at: include/clang/Driver/CC1Options.td:170 +def analyzer_werror : Flag<["-"], "analyzer-werror">, + HelpText<"Emit analyzer results as errors, not warnings">; + how about "rather than

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

NoQ added a comment. Looks great! Feel free to add a Driver flag as well (i.e., --analyzer-werror or something like that) so that not to type `-Xclang` every time. In D62885#1530573 , @xazax.hun wrote: > The only problem I see with this approach is that

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

xazax.hun added a comment. The only problem I see with this approach is that it is an all or nothing thing at the moment. Most of the checks in CSA can have false positives and people usually do not want to fail a build due to a false positive finding. This would force the users to do two

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

loladiro marked an inline comment as done. loladiro added a comment. > So, you'd like to make this a frontend flag in order not to expose it to > "regular" end users? Or was it because, well, every other flag we have is a > frontend flag? Little bit of both? We already need to pass a bunch of

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

Szelethus added a comment. Interesting. Let's also have a link to your cfe-dev letter: http://lists.llvm.org/pipermail/cfe-dev/2019-June/062495.html So, you'd like to make this a frontend flag in order not to expose it to "regular" end users? Or was it because, well, every other flag we have

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

loladiro created this revision. loladiro added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We're using the clang static analyzer together with a