This revision was automatically updated to reflect the committed changes.
Closed by commit rL362791: [ARM] Fix bugs introduced by the fp64/d32 rework.
(authored by statham, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
SjoerdMeijer added a comment.
Cheers, LGTM too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62998/new/
https://reviews.llvm.org/D62998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
simon_tatham updated this revision to Diff 203526.
simon_tatham added a comment.
Renamed `FeaturesAfter` to `ExtensionFeatures` and added a comment
explaining why it has to be separate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62998/new/
SjoerdMeijer added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:103
std::vector ,
+ std::vector ,
const llvm::Triple ) {
Nitpick: can you comment in
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM with one change.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:294
+ std::vector FeaturesAfter;
+
You explained it in the commit
simon_tatham created this revision.
simon_tatham added reviewers: SjoerdMeijer, dmgreen, ostannard, samparker,
JamesNagurne.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls,
javed.absar, srhines.
Herald added projects: clang, LLVM.
Change D60691
