[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske added a comment. New patch: https://reviews.llvm.org/D65064 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske added a comment. Commit was reverted because we were not aware of that clangAST library can not use clangFrontend library. So a different solution is needed, probably pass a SourceLocation import callback to ASTImporter. (A `Preprocessor` that can be used in place of `ASTUnit` here can

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366449: [CrossTU] Add a function to retrieve original source location. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext &FromContext, FileManager &FromFileManager, +ASTUnit *FromUnit, bool Minim

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked 4 inline comments as done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext &FromContext, FileManager &FromFileManager, +ASTUnit *FromUnit, bool MinimalImport, +std::shared_

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:288 +ASTContext &FromContext, FileManager &FromFileManager, +ASTUnit *FromUnit, bool MinimalImport, +std::shared_ptr SharedState); Why do we

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske updated this revision to Diff 210490. balazske marked an inline comment as not done. balazske added a comment. - Renamed 'Unit', changed constructors. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 Files: incl

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); martong wrote: > balazske wrote: > > balazske wrote: > > > martong wrote: > > > > W

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); balazske wrote: > balazske wrote: > > martong wrote: > > > What if we provided an a

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked an inline comment as not done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); balazske wrote: > martong wrote: >

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske marked an inline comment as done. balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); martong wrote: > What if we provided an

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:317 +std::shared_ptr SharedState = nullptr, +ASTUnit *Unit = nullptr); What if we provided an additional constructor where we take over the ASTUnits inst

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added inline comments. Comment at: include/clang/AST/ASTImporter.h:234 +/// The ASTUnit that this importer belongs to, if any. +ASTUnit *Unit; + `Unit->getASTContext` must be equal to `FromContext`, right? Then `FromUnit` would be a better naming.

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

martong added a comment. > This patch can be treated as part of a bigger change that is needed to > improve macro expansion handliong at plist generation. @balazske Could you please prepare the upcoming patch and put that on the Stack. I think that may ease the work of the reviewers if they cou

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A new function will be added to get the original SourceLocation for a SourceLocation that was impor