[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372919: [clang-format] Modified SortIncludes and IncludeCategories to priority for… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-09-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. > Yes, it would be good if it is landed. And can I know the procedure for > getting commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-09-12 Thread Manikishan Ghantasala via Phabricator via cfe-commits
Manikishan added a comment. >>! In D64695#1667696 , >>@MyDeveloperDay wrote: > Does this need landing? given that you have a number of patches in flight > perhaps it would be good to request commit access Yes, it would be good if it is landed. And can

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-09-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Does this need landing? given that you have a number of patches in flight perhaps it would be good to request commit access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 ___ cfe-commits mailing list

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-22 Thread Manikishan Ghantasala via Phabricator via cfe-commits
Manikishan updated this revision to Diff 216576. Manikishan edited the summary of this revision. Manikishan added a comment. I have removed the introduction to the NetBSDStyle, as there are some styles that are needed to implemented before launching the NetBSD style. Repository: rC Clang

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-21 Thread Manikishan Ghantasala via Phabricator via cfe-commits
Manikishan added a comment. In D64695#1614386 , @MyDeveloperDay wrote: > Assuming this works and the other unit tests don't show issues then this > LGTM. Please consider running this on your NetBSD code base before > committing, if possible please also

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

2019-08-21 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D64695#1614386 , @MyDeveloperDay wrote: > Assuming this works and the other unit tests don't show issues then this LGTM. > Please consider running this on your NetBSD code base before committing, if > possible please