This revision was automatically updated to reflect the committed changes.
Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers
(authored by DiegoAstiazaran, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
DiegoAstiazaran updated this revision to Diff 215193.
DiegoAstiazaran marked an inline comment as done.
DiegoAstiazaran added a comment.
Use getAccess() instead of getAccessUnsafe() for CXXMethodDecl.
Add comments in YAML generator to specify that AS_none is used as the default
here because it's
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
One comment then LGTM
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:507
Reference{ParentUSR, Parent->getNameAsString(), InfoType::IT_record};
- Fu
DiegoAstiazaran updated this revision to Diff 214923.
DiegoAstiazaran edited the summary of this revision.
DiegoAstiazaran added a comment.
Default value of AccessSpecifier attributes is now AS_public.
Multiple tests modified.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66151/new/
htt
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: jakehehrlich, juliehockett.
DiegoAstiazaran added a project: clang-tools-extra.
Bitcode writer was not emitting the corresponding record for the Access
attribute of a FunctionInfo.
This is added and corresponding test is incl
