[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-24 Thread John Reagan via Phabricator via cfe-commits
JohnReagan added a comment. Does the current code generate all the prologue cfi directives? Epilogue too? The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work. We're also

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-24 Thread John Reagan via cfe-commits
Does the current code generate all the prologue cfi directives?  Epilogue too?  The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work.  We're also looking at using the compact format

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-24 Thread Eric Christopher via cfe-commits
That said, prior art in gcc in this area: -fasynchronous-unwind-tables Generate unwind table in DWARF format, if supported by target machine. The table is exact at each instruction boundary, so it can be used for stack unwinding from asynchronous events (such as debugger or garbage collector).

[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-24 Thread Keith Walker via Phabricator via cfe-commits
keith.walker.arm added a comment. I feel that using a -g option make more sense. Maybe -gdwarf-frame, or -gdwarf-frame-always might be more user friendly as it relates more to the DWARF section created rather than the section content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-06 Thread David Candler via Phabricator via cfe-commits
dcandler added a comment. Herald added a subscriber: ychen. I was actually torn myself on whether to put the flag in the g group or not, so I'm happy to rename it. As far as I could find, no compiler has an existing option to control this: instead armcc always includes a debug_frame section by

[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-05 Thread Oliver Stannard (Linaro) via Phabricator via cfe-commits
ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Does the name of the `-falways-need-cfi` option match any existing compiler (google doesn't find anything)? If not, I think it would make more sense as a `-g` option, as it's

[PATCH] D67216: [cfi] Add flag to always generate call frame information

2019-09-05 Thread David Candler via Phabricator via cfe-commits
dcandler created this revision. dcandler added reviewers: echristo, probinson, aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. This adds a flag to LLVM and clang to always generate call frame information,