[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1730324 , @gribozavr2 wrote: > > Are you suggesting we remove text and selection entirely? > > Yes! Sounds good. I'll do that in a separate patch. I think we can abandon this one. Repository: rG LLVM Github

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. > Are you suggesting we remove text and selection entirely? Yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69625/new/ https://reviews.llvm.org/D69625 ___ cfe-commits

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1729702 , @gribozavr2 wrote: > > Which idiom do you think we should encourage, then, for text and > > range-selectors -- the named combinator or the single-argument cat? That is > > You are making a very interesting

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. > Which idiom do you think we should encourage, then, for text and > range-selectors -- the named combinator or the single-argument cat? That is You are making a very interesting point! It sounds very appealing to me to remove the special `text` and `selection`

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1729634 , @gribozavr2 wrote: > I fully agree about passing a Stencil to `access`. However whether to call > `makeStencil` inside is an interesting question. On one hand, such implicit > conversions increase the

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. I fully agree about passing a Stencil to `access`. However whether to call `makeStencil` inside is an interesting question. On one hand, such implicit conversions increase the convenience. On the other, they increase the API surface (more possible argument types),

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel added a parent revision: D69613: [libTooling] Simplify type structure of `Stencil`s.. Changes `clang::transformer::access` to also support `RangeSelector` as the second argument. This