This revision was automatically updated to reflect the committed changes.
Closed by commit rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to
add_llvm_executable() (authored by daltenty).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69638/new/
https://re
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69638/new/
https://reviews.llvm.org/D69638
___
c
daltenty updated this revision to Diff 227463.
daltenty marked an inline comment as done.
daltenty added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69638/new/
https://reviews.llvm.org/D69638
Files:
clang/tools/driver/CMake
daltenty updated this revision to Diff 227461.
daltenty added a comment.
- Address review comments round 1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69638/new/
https://reviews.llvm.org/D69638
Files:
clang/tools/driver/CMakeLists.txt
llvm/c
beanz added a comment.
A few comments inline.
Comment at: clang/tools/driver/CMakeLists.txt:34
${tablegen_deps}
+ SUPPORT_PLUGINS
)
This is now a behavior change because you're always passing this.
You'll want to bring back the conditional statement wit
daltenty created this revision.
Herald added subscribers: llvm-commits, cfe-commits, mgorny.
Herald added projects: clang, LLVM.
daltenty edited the summary of this revision.
daltenty added reviewers: hubert.reinterpretcast, beanz, lhames.
daltenty added a reverted change: D69356: [NFC] Rename LLVM
