[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm closed this revision. arsenm added a comment. fa7cd549d604bfd8f9dce5d649a19720cbc39cca CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 __

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM - the PS4 behavior was confirmed off-list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 ___

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 243553. arsenm added a comment. Rebase and fix check prefix name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Dr

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added inline comments. Comment at: clang/test/Driver/default-denormal-fp-math.c:7 +// crtfastmath enables ftz and daz +// RUN: %clang -### -target x86_64-unknown-linux-gnu -ffast-math --sysroot=%S/Inputs/basic_linux_tree -c %s -v 2>&1 | FileCheck -check-prefix=CHECK-ZERO

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 232088. arsenm added a comment. Rename functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a subscriber: andreadb. spatel added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:580 + /// This checks for presence of the -Ofast, -ffast-math or -funsafe-math flags. + virtual bool FastMathRuntimeIsAvailable( +const llvm::opt::ArgList

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 231726. arsenm added a comment. DAZ/FTZ seem to be set in crtfastmath.o, so try to reproduce the logic for linking that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/Too

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a comment. In D69979#1749198 , @arsenm wrote: > I just posted the test I wrote here: https://github.com/arsenm/subnormal_test Thanks. I tried compiling with gcc (can't trust clang since it doesn't honor #pragma STDC FENV_ACCESS ON?). And r

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1746043 , @spatel wrote: > In D69979#1740294 , @arsenm wrote: > > > In D69979#1738099 , @craig.topper > > wrote: > > > > > I checked Redhat

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a comment. In D69979#1740294 , @arsenm wrote: > In D69979#1738099 , @craig.topper > wrote: > > > I checked Redhat 7.4 that's on the server I'm using for work. And I had a > > coworker check his Ubuntu

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1738099 , @craig.topper wrote: > I checked Redhat 7.4 that's on the server I'm using for work. And I had a > coworker check his Ubuntu 18.04 system with this program. And both systems > printed 1f80 as the value of MXCS

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1738723 , @spatel wrote: > Also, I may have missed some discussions. Does this patch series replace the > proposal to add instruction-level FMF for denorms? > http://lists.llvm.org/pipermail/llvm-dev/2019-September/13518

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a reviewer: cameron.mcinally. spatel added a comment. Also, I may have missed some discussions. Does this patch series replace the proposal to add instruction-level FMF for denorms? http://lists.llvm.org/pipermail/llvm-dev/2019-September/135183.html Ie, did we decide that a function

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a comment. In D69979#1738099 , @craig.topper wrote: > I checked Redhat 7.4 that's on the server I'm using for work. And I had a > coworker check his Ubuntu 18.04 system with this program. And both systems > printed 1f80 as the value of MXCS

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

craig.topper added a comment. I checked Redhat 7.4 that's on the server I'm using for work. And I had a coworker check his Ubuntu 18.04 system with this program. And both systems printed 1f80 as the value of MXCSR which shows FTZ and DAZ are both 0. Are you seeing something different? #inclu

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm created this revision. arsenm added reviewers: spatel, craig.topper, RKSimon, hfinkel, probinson. Herald added a subscriber: wdng. arsenm added a parent revision: D69978: Separately track input and output denormal mode. This is to avoid performance regressions when the default attribute be