[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

2019-11-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcbb10e2d08: [clangd] Ignore more implicit nodes in computing selection. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70194?vs=229141=229319#toc Repository: rG LLVM

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

2019-11-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:162 + // Refs to operator() and [] are (almost?) always implicit as part of calls. + if (auto *DRE =

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

2019-11-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

2019-11-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The DeclRefExpr for the callee of overloaded `operator()` and `operator[]` are assigned the