aganea marked an inline comment as done.
aganea added inline comments.
Comment at: lld/Common/ErrorHandler.cpp:78
}
- _exit(val);
+ llvm::sys::Process::Exit(val);
}
rnk wrote:
> This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`,
>
rnk added inline comments.
Comment at: lld/Common/ErrorHandler.cpp:78
}
- _exit(val);
+ llvm::sys::Process::Exit(val);
}
This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, not
`_exit`, so now atexit destructors are run. That's
ayrivera added inline comments.
Comment at: lld/ELF/Driver.cpp:895
const char *argv[] = {config->progName.data(), opt.data()};
+ cl::ResetAllOptionOccurrences();
if (cl::ParseCommandLineOptions(2, argv, "", ))
aganea wrote:
> ayrivera wrote:
> > MaskRay
aganea added inline comments.
Comment at: lld/ELF/Driver.cpp:895
const char *argv[] = {config->progName.data(), opt.data()};
+ cl::ResetAllOptionOccurrences();
if (cl::ParseCommandLineOptions(2, argv, "", ))
ayrivera wrote:
> MaskRay wrote:
> > ayrivera
ayrivera added inline comments.
Comment at: lld/ELF/Driver.cpp:895
const char *argv[] = {config->progName.data(), opt.data()};
+ cl::ResetAllOptionOccurrences();
if (cl::ParseCommandLineOptions(2, argv, "", ))
MaskRay wrote:
> ayrivera wrote:
> > Hi,
> >
MaskRay added inline comments.
Comment at: lld/ELF/Driver.cpp:895
const char *argv[] = {config->progName.data(), opt.data()};
+ cl::ResetAllOptionOccurrences();
if (cl::ParseCommandLineOptions(2, argv, "", ))
ayrivera wrote:
> Hi,
>
> I built locally lld
ayrivera added inline comments.
Comment at: lld/ELF/Driver.cpp:895
const char *argv[] = {config->progName.data(), opt.data()};
+ cl::ResetAllOptionOccurrences();
if (cl::ParseCommandLineOptions(2, argv, "", ))
Hi,
I built locally lld and came across an
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf2efb5742cc9: [LLD][COFF] Cover usage of LLD-as-a-library in
tests (authored by aganea).
Changed prior to commit:
rnk accepted this revision.
rnk added a comment.
Looks good to me, I didn't review very in depth, but I see the test case that
we need. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
amccarth accepted this revision.
amccarth added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
___
cfe-commits mailing list
MaskRay added a comment.
@rnk @amccarth Do you have more comments? ☺️
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
___
cfe-commits mailing list
aganea added a comment.
@MaskRay Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaskRay accepted this revision.
MaskRay added a comment.
Looks great!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
___
cfe-commits mailing list
aganea added a comment.
Ping! @MaskRay any further comments?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
___
cfe-commits mailing list
aganea added inline comments.
Comment at: clang/tools/driver/driver.cpp:537
+ // When running in integrated-cc1 mode, the CrashRecoveryContext returns
+ // the same code as if the program crashed. On Unix, that is codes >128.
+ IsCrash |= CommandRes > 128;
aganea updated this revision to Diff 287952.
aganea marked 2 inline comments as done.
aganea added a comment.
Address comments.
Added a CrashRecoveryTest.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70378/new/
https://reviews.llvm.org/D70378
MaskRay added inline comments.
Comment at: clang/tools/driver/driver.cpp:537
+ // When running in integrated-cc1 mode, the CrashRecoveryContext returns
+ // the same code as if the program crashed. On Unix, that is codes >128.
+ IsCrash |= CommandRes > 128;
aganea updated this revision to Diff 287747.
aganea marked an inline comment as done.
aganea added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Rebase.
Address @MaskRay's suggestions.
Made `safeLldLink` a public API and made it possible to provide user-defined
18 matches
Mail list logo
