[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson added a comment. In D72538#4296277 , @nikic wrote: > In D72538#4296119 , @tejohnson wrote: > >> In D72538#4291552 , @nikic wrote: >> >>> Would it be possible to

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. In D72538#4296119 , @tejohnson wrote: > In D72538#4291552 , @nikic wrote: > >> Would it be possible to cut down the Clang side tests to only check parts >> that Clang controls in some way,

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson added a comment. In D72538#4291552 , @nikic wrote: > Would it be possible to cut down the Clang side tests to only check parts > that Clang controls in some way, e.g. that SLPVectorizer is enabled? This > test is something of a PITA because it

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. Herald added subscribers: wlei, pcwang-thead, ormris, wenlei. Herald added a project: All. Would it be possible to cut down the Clang side tests to only check parts that Clang controls in some way, e.g. that SLPVectorizer is enabled? This test is something of a PITA

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rG2af97be8027a: [ThinLTO] Add additional ThinLTO pipeline testing with new PM (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 ___

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson marked 2 inline comments as done. tejohnson added a comment. In D72538#1815074 , @wmi wrote: > The additional pipeline testing will catch any future pass change to the > pipeline. A related but separate question is do we have a way to check >

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237462. tejohnson marked an inline comment as done. tejohnson added a comment. Implement suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files:

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi added a comment. The additional pipeline testing will catch any future pass change to the pipeline. A related but separate question is do we have a way to check whether there is any other missing pass in thinlto newpm similar as that in D72386 ?

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237427. tejohnson added a comment. Remove some cruft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson created this revision. tejohnson added a reviewer: wmi. Herald added subscribers: jfb, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. I've added some more extensive ThinLTO pipeline testing with the new PM, motivated by the bug fixed in