[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

JDevlieghere added a comment. In D72552#1832875 , @JDevlieghere wrote: > It looks like the concept changes broke the debugger (quite spectacularly > actually): > > http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356 > http://lab.llvm.org:80

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

JDevlieghere added a comment. It looks like the concept changes broke the debugger (quite spectacularly actually): http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356 http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12872 http://green.lab.llvm.org/green/view/LLDB/job/

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

rtrieu added inline comments. Comment at: clang/lib/AST/ASTConcept.cpp:17 #include "clang/AST/ASTContext.h" +#include "clang/Sema/SemaConcept.h" using namespace clang; This causes a circular dependency between AST and Sema. It looks like you are including thi

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

This revision was automatically updated to reflect the committed changes. Closed by commit rGb933d37cd377: [Concepts] Constraint Satisfaction Caching (authored by saar.raz). Changed prior to commit: https://reviews.llvm.org/D72552?vs=237474&id=239464#toc Repository: rG LLVM Github Monorepo

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

david_stone added a comment. In D72552#1832293 , @rsmith wrote: > Mechanically, this looks fine. > > There's an ongoing discussion in the committee as to whether this kind of > caching is permissible. But if this is necessary for acceptable performance,

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Mechanically, this looks fine. There's an ongoing discussion in the committee as to whether this kind of caching is permissible. But if this is necessary for acceptable performance, let's tak

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a simple cache for constraint satisfaction results. This results in a major speedup (cjdb measured x2 faster than gcc with this caching, compared to being '