This revision was automatically updated to reflect the committed changes.
Closed by commit rG53f5c8b4a14c: [AST] Add fixed-point multiplication constant
evaluation. (authored by ebevhan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73186/new/
leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73186/new/
https://reviews.llvm.org/D73186
ebevhan added a comment.
The last patchset contains the comment about rounding, so I think I will
consider this accepted.
As a final addendum to the discussion on rounding and overflow... The last
Appendix to the E-C TR does actually say:
2. In the first edition requires that overflow
ebevhan updated this revision to Diff 255976.
ebevhan added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73186/new/
https://reviews.llvm.org/D73186
Files:
clang/include/clang/Basic/FixedPoint.h
rjmccall added a comment.
Since we've settled on not considering that to be overflow, yeah, I think the
patch is fine. Might be worth being explicit about that at the point you do
the shift: that it's known that this discards precision that could leave the
true mathematical value outside of
ebevhan added a comment.
So, any more on this or are we in agreement?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73186/new/
https://reviews.llvm.org/D73186
___
cfe-commits mailing list
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
rjmccall wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > rjmccall wrote:
> > > > ebevhan wrote:
> > > > > rjmccall
rjmccall added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
leonardchan wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > ebevhan wrote:
> > > > rjmccall wrote:
> > > > > leonardchan
leonardchan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
ebevhan wrote:
> rjmccall wrote:
> > ebevhan wrote:
> > > rjmccall wrote:
> > > > leonardchan wrote:
> > > > > ebevhan
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
rjmccall wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > leonardchan wrote:
> > > > ebevhan wrote:
> > > > > rjmccall
rjmccall added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
ebevhan wrote:
> rjmccall wrote:
> > leonardchan wrote:
> > > ebevhan wrote:
> > > > rjmccall wrote:
> > > > > ebevhan
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
rjmccall wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > rjmccall wrote:
> > > > ebevhan wrote:
> > > > > ebevhan
rjmccall added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
leonardchan wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > ebevhan wrote:
> > > > ebevhan wrote:
> > > > > rjmccall
leonardchan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
ebevhan wrote:
> rjmccall wrote:
> > ebevhan wrote:
> > > ebevhan wrote:
> > > > rjmccall wrote:
> > > > > If the
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
rjmccall wrote:
> ebevhan wrote:
> > ebevhan wrote:
> > > rjmccall wrote:
> > > > If the maximum expressible value is *k*,
rjmccall added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
ebevhan wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > If the maximum expressible value is *k*, and the fully-precise
>
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
ebevhan wrote:
> rjmccall wrote:
> > If the maximum expressible value is *k*, and the fully-precise
> > multiplication
ebevhan added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
rjmccall wrote:
> If the maximum expressible value is *k*, and the fully-precise multiplication
> yields *k+e* for some
ebevhan updated this revision to Diff 239797.
ebevhan added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73186/new/
https://reviews.llvm.org/D73186
Files:
clang/include/clang/Basic/FixedPoint.h
rjmccall added inline comments.
Comment at: clang/lib/Basic/FixedPoint.cpp:242
+ } else
+Overflowed = Result < Min || Result > Max;
+
If the maximum expressible value is *k*, and the fully-precise multiplication
yields *k+e* for some epsilon *e* that isn't
ebevhan created this revision.
ebevhan added reviewers: rjmccall, leonardchan, bjope.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D73186
Files:
clang/include/clang/Basic/FixedPoint.h
21 matches
Mail list logo
