[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-05-06 Thread George Rokos via Phabricator via cfe-commits
grokos abandoned this revision. grokos added a comment. The partial linking scheme has been found to not work correctly in all cases (it fails when we have libraries with device code only). A new patch will be uploaded which will be based on archive extraction. Repository: rG LLVM Github

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-14 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D74262#1876835 , @grokos wrote: > In D74262#1867245 , @ABataev wrote: > > > Partial linking may lead to some incorrect results with global > > constructors. How are you going to handle

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-14 Thread George Rokos via Phabricator via cfe-commits
grokos marked 2 inline comments as done. grokos added a comment. In D74262#1867245 , @ABataev wrote: > Partial linking may lead to some incorrect results with global constructors. > How are you going to handle this? Can you give me an example of what

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:84 " o - object\n" + " oo - object; output file is a list of unbundled objects\n" " gch -

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. (I'll try to actually review this later but I left a comment below) Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c %s -o %t_fat.o +// RUN: %clangxx %t_fat.o

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-10 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Partial linking may lead to some incorrect results with global constructors. How are you going to handle this? Comment at: clang/test/Driver/clang-offload-bundler-missing-size-section.cpp:1-44 +// REQUIRES: x86-registered-target +// RUN: %clangxx -c

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

2020-02-07 Thread George Rokos via Phabricator via cfe-commits
grokos created this revision. grokos added reviewers: hfinkel, jdoerfert, ABataev, mdtoguchi, kbobrovs, sdmitriev. grokos added a project: clang. Herald added a subscriber: Anastasia. This is the bundler-side patch for enabling static library support in clang. The scheme has been discussed