This revision was automatically updated to reflect the committed changes.
Closed by commit rG5dc2314d5ecf: [clangd] Update the CompletionItemKind.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74609/new/
https://reviews.llvm.or
hokein added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106
+ case SK::ConversionFunction:
+return CompletionItemKind::Operator;
case SK::Variable:
kadircet wrote:
> I believe `function` still captures the intend better here, a
hokein updated this revision to Diff 244646.
hokein marked 2 inline comments as done.
hokein added a comment.
address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74609/new/
https://reviews.llvm.org/D74609
Files:
clang-tools-extra/clang
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106
+ case SK::ConversionFunction:
+return CompletionItemKind::Operator;
case SK::Variable:
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Fix some FIXMEs.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D74609
Files:
clang-tools-extra/clan
