Re: [PATCH] D78454: [clangd] Highlight related control flow.

mits@lists.llvm.org>; Theko Lekena ; Nicolas > Lesser ; Han Shen ; Haojian Wu > > *Subject:* Re: [PATCH] D78454: [clangd] Highlight related control flow. > > > > On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < > revi...@reviews.llvm.org> wrote: > &g

RE: [PATCH] D78454: [clangd] Highlight related control flow.

Subject: Re: [PATCH] D78454: [clangd] Highlight related control flow. On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator mailto:revi...@reviews.llvm.org>> wrote: russell.gallop added a comment. Hi Sam, It looks like this is causing a failure on the Windows PS4 buildbot:

Re: [PATCH] D78454: [clangd] Highlight related control flow.

Added workaround in 6dd1629770d686831bdb2649650b86c37f0f7091 - will look at disabling tests properly tomorrow. On Thu, May 28, 2020 at 4:55 PM Sam McCall wrote: > On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < > revi...@reviews.llvm.org> wrote: > >> russell.gallop added a

Re: [PATCH] D78454: [clangd] Highlight related control flow.

On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < revi...@reviews.llvm.org> wrote: > russell.gallop added a comment. > > Hi Sam, > > It looks like this is causing a failure on the Windows PS4 buildbot: >

[PATCH] D78454: [clangd] Highlight related control flow.

russell.gallop added a comment. Hi Sam, It looks like this is causing a failure on the Windows PS4 buildbot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606 Please could you take a look? PS4 target disables RTTI, hence exceptions, by default so

[PATCH] D78454: [clangd] Highlight related control flow.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGa56141b8f9fe: [clangd] Highlight related control flow. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78454?vs=264734=266817#toc

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:907 +// Highlight the loop keyword itself. +Result.push_back(P->ASTNode.getSourceRange().getBegin()); +break;

[PATCH] D78454: [clangd] Highlight related control flow.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:907 +// Highlight the loop keyword itself. +Result.push_back(P->ASTNode.getSourceRange().getBegin()); +

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:654 + // Types of control-flow statements we might highlight. + enum Target { +Break = 1, adamcz wrote: > What about "goto"? It's more difficult to figure out if it breaks out

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall updated this revision to Diff 264734. sammccall marked 6 inline comments as done. sammccall added a comment. Address comments, handle goto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78454/new/ https://reviews.llvm.org/D78454 Files:

[PATCH] D78454: [clangd] Highlight related control flow.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:628 +return FD->getBody(); + if (const auto *FD = N.get()) +return FD->getBody(); You are checking for FunctionDecl twice Comment at:

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This means e.g. highlighting "return" will show other returns/throws from the same