[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. In D82548#2124549 , @lh123 wrote: > In D82548#2124546 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D82548?vs=274496=274685#toc Repository: rG LLVM Github

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 added a comment. In D82548#2124546 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thank you! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6278 + return true; +// FIXME(liuhui): Ideally, we should check the ctor parameter list to +

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274496. lh123 added a comment. Add the missing `operator!=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274491. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

sammccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11968 bool AfterAmpersand); + void CodeCompleteFunctionDeleteAndDefaultSpecifier(); nit: "specifier" isn't an accurate term here. I don't know

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273942. lh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273925. lh123 edited the summary of this revision. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files:

[PATCH] D82548: [CodeComplete] add code completion for `delete` and `default` specifier.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82535: [CodeComplete] Add code completion for using alias.. add code completion for `delete` and `default` specifier.