This revision was automatically updated to reflect the committed changes.
Closed by commit rG3537939cda86: [X86] Move frontend CPU feature initialization
to a look up table based… (authored by craig.topper).
Changed prior to commit:
https://reviews.llvm.org/D82731?vs=274161&id=274586#toc
Repos
RKSimon added a comment.
LGTM with a couple of minors
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2835
// CHECK_ZNVER1_M32: #define __F16C__ 1
+// CHECK_ZNVER1_M32-NOT: #define __FMA4__ 1
// CHECK_ZNVER1_M32: #define __FMA__ 1
The additional
craig.topper added a comment.
@RKSimon do you mind taking a look at this too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82731/new/
https://reviews.llvm.org/D82731
___
cfe-commits mailing list
cfe-c
craig.topper updated this revision to Diff 274161.
craig.topper added a comment.
-Run clang-format. Some lines in the table are still slightly over 80 columns.
-Fix the number of words in the FeatureBitset.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
A bunch of clang-format, plus 1 odd looking equation, otherwise this like good.
Comment at: llvm/lib/Support/X86TargetParser.cpp:27
+class FeatureBitset {
+ static c
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, LuoYuanke, LiuChen3, echristo,
FreddyYe.
Herald added subscribers: jfb, hiraditya.
Herald added projects: clang, LLVM.
craig.topper added a reviewer: erichkeane.
This replaces the switch statement implementation in
