[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb10b065f2a8: [clang] Pass the NamedDecl* instead of the DeclarationName into many… (authored by riccibruno). Changed prior to commit:

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno added a comment. In D84656#2176139 , @aaron.ballman wrote: > The changes LGTM but it seems like there may be some formatting issues with > the patch (or the lint tool is acting up). Looks like the bot is right this time. Thanks!

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

aaron.ballman accepted this revision. aaron.ballman added a comment. The changes LGTM but it seems like there may be some formatting issues with the patch (or the lint tool is acting up). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84656/new/

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno added a comment. In D84656#2175813 , @erichkeane wrote: > I looked through the code changes, and they all seem quite mechanical. I > believe they are all correct. > > After reading through the test changes, I believe that this change is >

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I looked through the code changes, and they all seem quite mechanical. I believe they are all correct. After reading through the test changes, I believe that this change is strictly

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Background: --- There are two related argument types which can be sent into a diagnostic to display the name of an