This revision was automatically updated to reflect the committed changes.
Closed by commit rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block
captures is conditional when theā¦ (authored by erik.pilkington).
Herald added a project: clang.
Changed prior to commit:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM modulo the minor fix
Comment at: clang/lib/CodeGen/CGDecl.cpp:2107
+// FIXME: When popping normal cleanups, we need to keep this EH cleanup
+// around in
erik.pilkington created this revision.
erik.pilkington added reviewers: ahatanak, rjmccall.
Herald added subscribers: danielkiss, ributzka, dexonsmith, jkorous.
erik.pilkington requested review of this revision.
Previously, clang was crashing on the attached test because the EH cleanup for
the