awarzynski added a comment.
Thank you all for your input! Before merging I took the liberty to rename
`NoClangOption` as `FlangOnlyOption`. The new name reflects better what the
flag is introduced for. Also, based on responses to [1], it is unlikely that it
will be used beyond flang-only
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic
frontend actions and file I/O (authored by CarolineConcatto, committed by
awarzynski).
richard.barton.arm accepted this revision.
richard.barton.arm added a comment.
I'm happy to accept this revision based on @SouraVX 's code review and the fact
that Andrzej has sent multiple RFCs covering the clang-side changes, including
the Options flags (latest here
SouraVX accepted this revision.
SouraVX added a comment.
This revision is now accepted and ready to land.
Thanks for your patience. LGTM! at least the part I reviewed. Though I would
vote for having another approval(From some senior folks in community)
Repository:
rG LLVM Github Monorepo
awarzynski added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
awarzynski updated this revision to Diff 299033.
awarzynski added a comment.
Simplify the API for creating output files
The originally implemented API was overly complicated and not yet required.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
awarzynski added a comment.
I've added more reviewers for the Clang side of this patch. I choose people who
most recently changed the functions/files that this patch modifies. Any input
much appreciated! For more context regarding Clang changes:
awarzynski commandeered this revision.
awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski.
awarzynski added a comment.
Thank you for reviewing @SouraVX! I'm just about to submit an updated patch
with the requested changes.
@CarolineConcatto has recently moved to a
awarzynski updated this revision to Diff 298407.
awarzynski added a comment.
Address PR comments, clang-format, rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
Files:
SouraVX added a comment.
Thanks for the patch! Overall it's in pretty nice state and conformant to
design highlighted.
Could you please `clang-format` this patch, There are lot of `lint` warning
that causes lot of noise while reviewing.
Couple of NIT comments inline. I've tried marking all
awarzynski added a comment.
@reviewers A note regarding the changes in Clang.
This patch introduces a Flang option (`-test-io`), that should not be
available/visible in Clang. AFAIK, there's no precedent of that, hence
`options::NoClangOption` is introduced. This is discussed in more detail
awarzynski added a comment.
LGTM, thanks for working on this!
As this is a fairly large change, could you wait for one more reviewer to
approve? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
CarolineConcatto marked 7 inline comments as done.
CarolineConcatto added a comment.
@awarzynski patch updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
https://reviews.llvm.org/D87989
CarolineConcatto updated this revision to Diff 296066.
CarolineConcatto edited the summary of this revision.
CarolineConcatto added a comment.
address reviews comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87989/new/
awarzynski added a comment.
@CarolineConcatto thank you again for working on this! The structure is good,
but IMHO this patch could be polished a bit more. Overall:
- could you make sure that this patch does not change the output from `clang
-help`?
- doxygen comments are consistent
-
15 matches
Mail list logo
