[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

rsmith added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -fclang-abi-compat=11.0 -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK-LEGACY

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG774ab60125ee: Add option to use older clang ABI behavior when passing certain union types as… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

LiuChen3 added a comment. Adding an option compatible with old abi is good method. Looks good for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89747/new/ https://reviews.llvm.org/D89747 ___

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung added a comment. Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks! Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems fine to me; thanks for the fix. For future reference, please upload diffs with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung created this revision. dyung added reviewers: probinson, rsmith, LiuChen3, craig.topper. dyung added a project: clang. Herald added subscribers: dexonsmith, pengfei. dyung requested review of this revision. Recently commit D78699 (commit 26cfb6e562f1