[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500124 , @jdoerfert wrote: > In D93078#2500122 , @mtrofin wrote: > >> In D93078#2500114 , @jdoerfert >> wrote: >> >>> In D93078#2500040

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2500122 , @mtrofin wrote: > In D93078#2500114 , @jdoerfert wrote: > >> In D93078#2500040 , @mtrofin wrote: >> >>> In D93078#2500032

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500114 , @jdoerfert wrote: > In D93078#2500040 , @mtrofin wrote: > >> In D93078#2500032 , @jdoerfert >> wrote: >> >>> In D93078#246

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2500040 , @mtrofin wrote: > In D93078#2500032 , @jdoerfert wrote: > >> In D93078#246 , @mtrofin wrote: >> >>> In D93078#245

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500032 , @jdoerfert wrote: > In D93078#246 , @mtrofin wrote: > >> In D93078#245 , @jdoerfert >> wrote: >> >>> In D93078#2499982

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#246 , @mtrofin wrote: > In D93078#245 , @jdoerfert wrote: > >> In D93078#2499982 , @mtrofin wrote: >> >>> In D93078#2499666

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#245 , @jdoerfert wrote: > In D93078#2499982 , @mtrofin wrote: > >> In D93078#2499666 , @jdoerfert >> wrote: >> >>> I think this

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2499982 , @mtrofin wrote: > In D93078#2499666 , @jdoerfert wrote: > >> I think this caused a lot of problems for the Attributor tests. I get the >> "conflict output" warning

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2499666 , @jdoerfert wrote: > I think this caused a lot of problems for the Attributor tests. I get the > "conflict output" warning all the time now :( > > These two `UpdateTestChecks` tests also generate the warning. I

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I think this caused a lot of problems for the Attributor tests. I get the "conflict output" warning all the time now :( These two `UpdateTestChecks` tests also generate the warning. I

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei added inline comments. Comment at: llvm/utils/update_analyze_test_checks.py:129 + +common.warn_on_failed_prefixes(func_dict) is_in_function = False mtrofin wrote: > pengfei wrote: > > Can we move these warn to common.py? > Come to think of

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added inline comments. Comment at: llvm/utils/update_analyze_test_checks.py:129 + +common.warn_on_failed_prefixes(func_dict) is_in_function = False pengfei wrote: > Can we move these warn to common.py? Come to think of it, maybe moving it to

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2dc306b1ac7: [utils] Fix UpdateTestChecks case where 2 runs differ for last label (authored by mtrofin). Repository: rG LLVM Github Monorepo

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311896. mtrofin added a comment. update_test_prefix.py change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 Files:

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2453891 , @pengfei wrote: > LGTM. Thanks. > `update_test_prefix.py` assumes the conflicting output. You may need to > change the expection of it as well. oh yes - made it check the new warning. Thanks! Repository:

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks. `update_test_prefix.py` assumes the conflicting output. You may need to change the expection of it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311593. mtrofin marked 3 inline comments as done. mtrofin added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 Files:

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin marked an inline comment as done. mtrofin added a comment. In D93078#2451747 , @pengfei wrote: > What's the difference with the existing code? It looks to me that you just > brought the warning out of loop, right? Oh true! we can just do the

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei added a comment. What's the difference with the existing code? It looks to me that you just brought the warning out of loop, right? Comment at: llvm/utils/update_analyze_test_checks.py:128 raw_tool_output, prefixes, func_dict, func_order, args.verbose,

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311359. mtrofin marked an inline comment as done. mtrofin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. added check for when a prefix has conflicts for all functions Repository: rG LLVM Github Monorepo CHANGES