[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by 
thopre).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

Files:
  clang/test/CodeGenCXX/split-stacks.cpp


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -27,7 +27,6 @@
 
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
-// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS0]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -27,7 +27,6 @@
 
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
-// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS0]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre marked 2 inline comments as done.
thopre added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

ChuanqiXu wrote:
> thopre wrote:
> > ChuanqiXu wrote:
> > > thopre wrote:
> > > > ChuanqiXu wrote:
> > > > > I find NSS2 equals to NSS0, which is `#0`. It looks good to me if 
> > > > > this could handle the inconsistency.
> > > > Only without split stack (second RUN line). With split stack I get:
> > > > 
> > > > 
> > > > ```
> > > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > > define dso_local i32 @_Z3foov() #0 {
> > > > entry:
> > > >   ret i32 0
> > > > }
> > > > 
> > > > ; Function Attrs: noinline optnone uwtable mustprogress
> > > > define dso_local i32 @_Z7nosplitv() #1 {
> > > > entry:
> > > >   %call = call i32 @_Z8tnosplitIiEiv()
> > > >   ret i32 %call
> > > > }
> > > > 
> > > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > > define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat {
> > > > entry:
> > > >   ret i32 0
> > > > }
> > > > 
> > > > ```
> > > Yeah, this is what I get without split stack:
> > > ```
> > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > define dso_local i32 @_Z3foov() #0 {
> > > entry:
> > >   ret i32 0
> > > }
> > > 
> > > ; Function Attrs: noinline optnone uwtable mustprogress
> > > define dso_local i32 @_Z7nosplitv() #1 {
> > > entry:
> > >   %call = call i32 @_Z8tnosplitIiEiv()
> > >   ret i32 %call
> > > }
> > > 
> > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #0 comdat {
> > > entry:
> > >   ret i32 0
> > > }
> > > 
> > > attributes #0 = { noinline nounwind optnone uwtable mustprogress 
> > > "frame-pointer"="all" "min-legal-vector-width"="0" 
> > > "no-trapping-math"="true" "stack-protector-buffer-size"="8" 
> > > "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" 
> > > "tune-cpu"="generic" }
> > > attributes #1 = { noinline optnone uwtable mustprogress 
> > > "frame-pointer"="all" "min-legal-vector-width"="0" 
> > > "no-trapping-math"="true" "stack-protector-buffer-size"="8" 
> > > "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" 
> > > "tune-cpu"="generic" }
> > > ```
> > > 
> > > My compiler version is latest trunk:2ea6ed9b70c6495342e39a7d1.
> > We get the same thing. The code I pasted about was *with* split stack. 
> > Since it's the same FileCheck directive with and without split stack it 
> > makes sense to keep NSS0 and NSS2 separate otherwise the split-stack case 
> > would fail.
> The FileCheck directive seems different with and without split stack. And the 
> number of attributes is different from what we paste.
Ah my bad, you are absolutely right. Difference in attributes is not a problem 
since these are CHECK-NOT directives but I've changed it nonetheless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre updated this revision to Diff 338811.
thopre marked an inline comment as done.
thopre added a comment.

Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

Files:
  clang/test/CodeGenCXX/split-stacks.cpp


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -27,7 +27,6 @@
 
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
-// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS0]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -27,7 +27,6 @@
 
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
-// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS0]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

thopre wrote:
> ChuanqiXu wrote:
> > thopre wrote:
> > > ChuanqiXu wrote:
> > > > I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this 
> > > > could handle the inconsistency.
> > > Only without split stack (second RUN line). With split stack I get:
> > > 
> > > 
> > > ```
> > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > define dso_local i32 @_Z3foov() #0 {
> > > entry:
> > >   ret i32 0
> > > }
> > > 
> > > ; Function Attrs: noinline optnone uwtable mustprogress
> > > define dso_local i32 @_Z7nosplitv() #1 {
> > > entry:
> > >   %call = call i32 @_Z8tnosplitIiEiv()
> > >   ret i32 %call
> > > }
> > > 
> > > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > > define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat {
> > > entry:
> > >   ret i32 0
> > > }
> > > 
> > > ```
> > Yeah, this is what I get without split stack:
> > ```
> > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > define dso_local i32 @_Z3foov() #0 {
> > entry:
> >   ret i32 0
> > }
> > 
> > ; Function Attrs: noinline optnone uwtable mustprogress
> > define dso_local i32 @_Z7nosplitv() #1 {
> > entry:
> >   %call = call i32 @_Z8tnosplitIiEiv()
> >   ret i32 %call
> > }
> > 
> > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #0 comdat {
> > entry:
> >   ret i32 0
> > }
> > 
> > attributes #0 = { noinline nounwind optnone uwtable mustprogress 
> > "frame-pointer"="all" "min-legal-vector-width"="0" 
> > "no-trapping-math"="true" "stack-protector-buffer-size"="8" 
> > "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" 
> > "tune-cpu"="generic" }
> > attributes #1 = { noinline optnone uwtable mustprogress 
> > "frame-pointer"="all" "min-legal-vector-width"="0" 
> > "no-trapping-math"="true" "stack-protector-buffer-size"="8" 
> > "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" 
> > "tune-cpu"="generic" }
> > ```
> > 
> > My compiler version is latest trunk:2ea6ed9b70c6495342e39a7d1.
> We get the same thing. The code I pasted about was *with* split stack. Since 
> it's the same FileCheck directive with and without split stack it makes sense 
> to keep NSS0 and NSS2 separate otherwise the split-stack case would fail.
The FileCheck directive seems different with and without split stack. And the 
number of attributes is different from what we paste.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

ChuanqiXu wrote:
> thopre wrote:
> > ChuanqiXu wrote:
> > > I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this 
> > > could handle the inconsistency.
> > Only without split stack (second RUN line). With split stack I get:
> > 
> > 
> > ```
> > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > define dso_local i32 @_Z3foov() #0 {
> > entry:
> >   ret i32 0
> > }
> > 
> > ; Function Attrs: noinline optnone uwtable mustprogress
> > define dso_local i32 @_Z7nosplitv() #1 {
> > entry:
> >   %call = call i32 @_Z8tnosplitIiEiv()
> >   ret i32 %call
> > }
> > 
> > ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> > define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat {
> > entry:
> >   ret i32 0
> > }
> > 
> > ```
> Yeah, this is what I get without split stack:
> ```
> ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> define dso_local i32 @_Z3foov() #0 {
> entry:
>   ret i32 0
> }
> 
> ; Function Attrs: noinline optnone uwtable mustprogress
> define dso_local i32 @_Z7nosplitv() #1 {
> entry:
>   %call = call i32 @_Z8tnosplitIiEiv()
>   ret i32 %call
> }
> 
> ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #0 comdat {
> entry:
>   ret i32 0
> }
> 
> attributes #0 = { noinline nounwind optnone uwtable mustprogress 
> "frame-pointer"="all" "min-legal-vector-width"="0" "no-trapping-math"="true" 
> "stack-protector-buffer-size"="8" "target-cpu"="x86-64" 
> "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
> attributes #1 = { noinline optnone uwtable mustprogress "frame-pointer"="all" 
> "min-legal-vector-width"="0" "no-trapping-math"="true" 
> "stack-protector-buffer-size"="8" "target-cpu"="x86-64" 
> "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
> ```
> 
> My compiler version is latest trunk:2ea6ed9b70c6495342e39a7d1.
We get the same thing. The code I pasted about was *with* split stack. Since 
it's the same FileCheck directive with and without split stack it makes sense 
to keep NSS0 and NSS2 separate otherwise the split-stack case would fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

thopre wrote:
> ChuanqiXu wrote:
> > I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this 
> > could handle the inconsistency.
> Only without split stack (second RUN line). With split stack I get:
> 
> 
> ```
> ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> define dso_local i32 @_Z3foov() #0 {
> entry:
>   ret i32 0
> }
> 
> ; Function Attrs: noinline optnone uwtable mustprogress
> define dso_local i32 @_Z7nosplitv() #1 {
> entry:
>   %call = call i32 @_Z8tnosplitIiEiv()
>   ret i32 %call
> }
> 
> ; Function Attrs: noinline nounwind optnone uwtable mustprogress
> define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat {
> entry:
>   ret i32 0
> }
> 
> ```
Yeah, this is what I get without split stack:
```
; Function Attrs: noinline nounwind optnone uwtable mustprogress
define dso_local i32 @_Z3foov() #0 {
entry:
  ret i32 0
}

; Function Attrs: noinline optnone uwtable mustprogress
define dso_local i32 @_Z7nosplitv() #1 {
entry:
  %call = call i32 @_Z8tnosplitIiEiv()
  ret i32 %call
}

; Function Attrs: noinline nounwind optnone uwtable mustprogress
define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #0 comdat {
entry:
  ret i32 0
}

attributes #0 = { noinline nounwind optnone uwtable mustprogress 
"frame-pointer"="all" "min-legal-vector-width"="0" "no-trapping-math"="true" 
"stack-protector-buffer-size"="8" "target-cpu"="x86-64" 
"target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
attributes #1 = { noinline optnone uwtable mustprogress "frame-pointer"="all" 
"min-legal-vector-width"="0" "no-trapping-math"="true" 
"stack-protector-buffer-size"="8" "target-cpu"="x86-64" 
"target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
```

My compiler version is latest trunk:2ea6ed9b70c6495342e39a7d1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

ChuanqiXu wrote:
> I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this could 
> handle the inconsistency.
Only without split stack (second RUN line). With split stack I get:


```
; Function Attrs: noinline nounwind optnone uwtable mustprogress
define dso_local i32 @_Z3foov() #0 {
entry:
  ret i32 0
}

; Function Attrs: noinline optnone uwtable mustprogress
define dso_local i32 @_Z7nosplitv() #1 {
entry:
  %call = call i32 @_Z8tnosplitIiEiv()
  ret i32 %call
}

; Function Attrs: noinline nounwind optnone uwtable mustprogress
define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() #2 comdat {
entry:
  ret i32 0
}

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.



Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }

I find NSS2 equals to NSS0, which is `#0`. It looks good to me if this could 
handle the inconsistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre added a comment.

Ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre added a comment.

Ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99839/new/

https://reviews.llvm.org/D99839

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

[Thomas Preud'homme via Phabricator via cfe-commits]

thopre created this revision.
thopre added reviewers: respindola, pcc, EricWF.
thopre requested review of this revision.
Herald added a project: clang.

The NSS FileCheck variables at the end of the
CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in
the use of an undefined variable (NSS3). This commit fixes that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99839

Files:
  clang/test/CodeGenCXX/split-stacks.cpp


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -28,6 +28,6 @@
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() 
[[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }


Index: clang/test/CodeGenCXX/split-stacks.cpp
===
--- clang/test/CodeGenCXX/split-stacks.cpp
+++ clang/test/CodeGenCXX/split-stacks.cpp
@@ -28,6 +28,6 @@
 // CHECK-NOSEGSTK: define dso_local i32 @_Z3foov() [[NSS0:#[0-9]+]] {
 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] {
 // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat {
+// CHECK-NOSEGSTK-NOT: [[NSS0]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS1]] = { {{.*}} "split-stack" {{.*}} }
 // CHECK-NOSEGSTK-NOT: [[NSS2]] = { {{.*}} "split-stack" {{.*}} }
-// CHECK-NOSEGSTK-NOT: [[NSS3]] = { {{.*}} "split-stack" {{.*}} }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits