Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

2020-03-26 Thread Michael LIAO via cfe-commits
Thanks for catching that. On Thu, Mar 26, 2020 at 11:14 PM David Blaikie wrote: > > Usually this sort of thing is addressed with llvm_unreachable, rather than a > return statement that's not expected to be reached by any valid execution of > LLVM (it'd require a carefully hand-crafted CPU kind

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

2020-03-26 Thread David Blaikie via cfe-commits
Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the

[clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

2020-03-25 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-03-26T00:53:24-04:00 New Revision: d264f02c6f502960e2bcdd332f250efc702d09f2 URL: https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2 DIFF: https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2.diff