RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] Will do. Thanks. Sam -Original Message- From: Erich Keane via Phabricator Sent: Wednesday, February 19, 2020 8:52 AM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov;

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] Reverted. I will make sure it does not regress mlir before commit again. Thanks. Sam -Original Message- From: Eric Christopher via Phabricator Sent: Tuesday, February 18, 2020 11:21 AM To: Liu, Yaxun (Sam) ; t...@google.com;

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com Subject: Re: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese [CAUTION: External Email] ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

Re: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

How did you come to this conclusion? https://buildkite.com/mlir/mlir-core/builds/2790#9ecce42d-5a20-4e52-8621-c7c0dcee7aa7 is a clean build at e8e078c8bf7987b95298062a644bac9eed26f988 that is just before 1b978ddba05cb15e22b4e75adb5e7362ad861987 (if I look at commits on github) and at

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] It seems to be caused by some commit hash before 20c5968e0953d978be4d9d1062801e8758c393b5. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Monday, February 17, 2020 10:58 AM To: Liu, Yaxun (Sam) ;

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] I am taking a look. Thanks. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Monday, February 17, 2020 10:58 AM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov;

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] Thanks a lot for fixing it. Sam -Original Message- From: Fangrui Song via Phabricator Sent: Sunday, February 16, 2020 8:41 PM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov;