Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html alexfh wrote: > aaron.ballman wrote: > > alexfh wrote: > > > Since this is not a

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

aaron.ballman added a comment. Fine by me -- I went with CERT since it's an acronym, but we don't do this for LLVM, so this change makes sense. Thanks! In http://reviews.llvm.org/D15805#317736, @alexfh wrote: > In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote: > > > Fine by me --

Re: [PATCH] D15791: Disable generating movt on FreeBSD

andrew added a comment. Can someone commit with the FIXME comment? I'm unable to do it myself. Repository: rL LLVM http://reviews.llvm.org/D15791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

flx updated this revision to Diff 43743. flx marked 2 inline comments as done. http://reviews.llvm.org/D15623 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html aaron.ballman wrote: > alexfh wrote: > > Since this is not a deprecated/obsolete file, it

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta updated this revision to Diff 43748. mattsta added a comment. Updated to include fix for: Assertion failed: (InitialLoc.isValid()), function checkStmt, file ../llvm/tools/clang/tools/extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp, line 226. Repository: rL LLVM

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta added a comment. It's difficult to track down *why* the invalid locations are happening because by the time we get to an invalid location, all source location information is lost. The best I've been able to come up with is fixing the early return conditions (which were previously

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

alexfh added a comment. In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote: > Fine by me -- I went with CERT since it's an acronym, but we don't do this > for LLVM, so this change makes sense. Thanks! AFAIU, LLVM is not an acronym anymore ;) (but still an upper-case spelling is

r256570 - [TrailingObjects] Convert AST classes that had a ASTTemplateKWAndArgsInfo.

Author: jyknight Date: Tue Dec 29 12:15:14 2015 New Revision: 256570 URL: http://llvm.org/viewvc/llvm-project?rev=256570=rev Log: [TrailingObjects] Convert AST classes that had a ASTTemplateKWAndArgsInfo. So, also: - Moved the TemplateArgumentLoc array out of the ASTTemplateKWAndArgsInfo

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html Since this is not a deprecated/obsolete file, it might be a good idea to also add a textual

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html aaron.ballman wrote: > alexfh wrote: > > alexfh wrote: > > > aaron.ballman wrote: > > > >

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html alexfh wrote: > Since this is not a deprecated/obsolete file, it might be a good idea

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

alexfh added inline comments. Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23 @@ +22,3 @@ +bool inHeaderFile(const SourceManager *SM, SourceLocation Location) { + StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location)); + return Filename.endswith(".h")

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

aaron.ballman added inline comments. Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23 @@ +22,3 @@ +bool inHeaderFile(const SourceManager *SM, SourceLocation Location) { + StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location)); + return

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5 @@ +4,2 @@ +.. meta:: + :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html alexfh wrote: > alexfh wrote: > > aaron.ballman wrote: > > > alexfh wrote: > > > >

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

On Tue, Dec 29, 2015 at 5:22 PM, Benjamin Kramer wrote: > On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh > > Date: Tue Dec 29 10:14:38 2015 > > New Revision: 256562 > > > > URL:

[clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

Author: alexfh Date: Tue Dec 29 10:14:38 2015 New Revision: 256562 URL: http://llvm.org/viewvc/llvm-project?rev=256562=rev Log: [clang-tidy] Fix a use-after-free bug found by asan Modified: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp Modified:

r256567 - [analyzer] Nullability: allow cast to _Nonnull to suppress warning about returning nil.

Author: dcoughlin Date: Tue Dec 29 11:40:49 2015 New Revision: 256567 URL: http://llvm.org/viewvc/llvm-project?rev=256567=rev Log: [analyzer] Nullability: allow cast to _Nonnull to suppress warning about returning nil. The nullability checker currently allows casts to suppress warnings when a

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Tue Dec 29 10:14:38 2015 > New Revision: 256562 > > URL: http://llvm.org/viewvc/llvm-project?rev=256562=rev > Log: > [clang-tidy] Fix a use-after-free bug found by asan

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

fraggamuffin marked 15 inline comments as done. fraggamuffin added a comment. Thanks for the pre-xmas review. Comment at: include/clang/AST/DeclOpenMP.h:98 @@ +97,3 @@ +/// +class OMPDeclareTargetDecl : public Decl, public DeclContext { + friend class ASTDeclReader;

r256599 - Fix test from r256596

Author: nico Date: Tue Dec 29 17:23:38 2015 New Revision: 256599 URL: http://llvm.org/viewvc/llvm-project?rev=256599=rev Log: Fix test from r256596 Modified: cfe/trunk/test/Lexer/msdos-cpm-eof.c Modified: cfe/trunk/test/Lexer/msdos-cpm-eof.c URL:

r256605 - [analyzer] Handle another Android assert function.

Author: dcoughlin Date: Tue Dec 29 18:08:59 2015 New Revision: 256605 URL: http://llvm.org/viewvc/llvm-project?rev=256605=rev Log: [analyzer] Handle another Android assert function. Android's assert can call both the __assert and __assert2 functions under the cover, but the

r256595 - Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

Author: nico Date: Tue Dec 29 17:06:17 2015 New Revision: 256595 URL: http://llvm.org/viewvc/llvm-project?rev=256595=rev Log: Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

Re: r256595 - Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Tue Dec 29 17:06:17 2015 > New Revision: 256595 > > URL: http://llvm.org/viewvc/llvm-project?rev=256595=rev > Log: > Emit a -Wmicrosoft warning when pasting /##/ into a comment

r256601 - Model NamespaceAliasDecls as having their nominated namespace as an underlying

Author: rsmith Date: Tue Dec 29 17:34:32 2015 New Revision: 256601 URL: http://llvm.org/viewvc/llvm-project?rev=256601=rev Log: Model NamespaceAliasDecls as having their nominated namespace as an underlying declaration. This fixes an issue where we would reject (due to a claimed ambiguity) a case

r256602 - When a namespace alias redeclares a using declaration, point the diagnostic at

Author: rsmith Date: Tue Dec 29 17:42:34 2015 New Revision: 256602 URL: http://llvm.org/viewvc/llvm-project?rev=256602=rev Log: When a namespace alias redeclares a using declaration, point the diagnostic at the using declaration not at the thing it's using. Modified:

r256603 - [analyzer] Suppress nullability warning for _Nonnull locals zero-initialized by ObjC ARC.

Author: dcoughlin Date: Tue Dec 29 17:44:19 2015 New Revision: 256603 URL: http://llvm.org/viewvc/llvm-project?rev=256603=rev Log: [analyzer] Suppress nullability warning for _Nonnull locals zero-initialized by ObjC ARC. Prevent the analyzer from warning when a _Nonnnull local variable is

[libcxx] r256592 - [libcxx] Fixing silly mistake from last commit.

Author: bcraig Date: Tue Dec 29 16:55:55 2015 New Revision: 256592 URL: http://llvm.org/viewvc/llvm-project?rev=256592=rev Log: [libcxx] Fixing silly mistake from last commit. Tested on Linux x86_64 targeting Linux x86_64. Modified: libcxx/trunk/test/libcxx/test/target_info.py Modified:

[libcxx] r256594 - [libcxx] Fixing the Mac / Darwin build

Author: bcraig Date: Tue Dec 29 17:01:07 2015 New Revision: 256594 URL: http://llvm.org/viewvc/llvm-project?rev=256594=rev Log: [libcxx] Fixing the Mac / Darwin build Modified: libcxx/trunk/test/libcxx/test/target_info.py Modified: libcxx/trunk/test/libcxx/test/target_info.py URL:

Re: r256595 - Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

On Tue, Dec 29, 2015 at 3:23 PM, Nico Weber wrote: > On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author:

r256600 - Address review comment on r256595

Author: nico Date: Tue Dec 29 17:30:42 2015 New Revision: 256600 URL: http://llvm.org/viewvc/llvm-project?rev=256600=rev Log: Address review comment on r256595 Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td URL:

r256576 - fix typos; NFC

Author: spatel Date: Tue Dec 29 14:09:37 2015 New Revision: 256576 URL: http://llvm.org/viewvc/llvm-project?rev=256576=rev Log: fix typos; NFC Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

aaron.ballman added inline comments. Comment at: include/clang/AST/DeclBase.h:563 @@ +562,3 @@ + /// \brief Return true if this declaration is a definition of alias or ifunc. + bool hasDefiningAttr() const; + rjmccall wrote: > aaron.ballman wrote: > > I think

[PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

bcraig created this revision. bcraig added reviewers: mclow.lists, jroelofs, danalbert, EricWF. bcraig added a subscriber: cfe-commits. Herald added a subscriber: emaste. This patch makes it easier to support running the lit tests for new and unusual platforms. It will break existing users that

Re: r256595 - Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nico >> Date: Tue Dec 29 17:06:17 2015 >> New Revision: 256595 >> >> URL:

[libcxx] r256597 - Mark LWG defect #2367 as complete

Author: ericwf Date: Tue Dec 29 17:18:27 2015 New Revision: 256597 URL: http://llvm.org/viewvc/llvm-project?rev=256597=rev Log: Mark LWG defect #2367 as complete Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

r256596 - Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode.

Author: nico Date: Tue Dec 29 17:17:27 2015 New Revision: 256596 URL: http://llvm.org/viewvc/llvm-project?rev=256596=rev Log: Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

Re: r256595 - Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.

On Tue, Dec 29, 2015 at 6:28 PM, Richard Smith wrote: > On Tue, Dec 29, 2015 at 3:23 PM, Nico Weber wrote: > >> On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Tue, Dec 29, 2015 at 3:06

Re: [PATCH] D15814: Implicit conversion from float->bool

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: test/SemaCXX/warn-literal-conversion.cpp:49-50 @@ +48,4 @@ + // values. + bool b3 = 0.0f; + bool b4 = 0.0; +} What about bool b5 = 1.0; bool b6 = 2.0; ? Arguably

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

EricWF added a comment. This is NOT correct and it's breaking bots. I don't want to revert it because I really like the change but it needs to be fixed quickly. @bcraig You removed the logic that tests if a system provides a given locale. We use this information to enable/disable tests.

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

rjmccall added a comment. This looks great, thanks. A few minor comment tweaks and this will be ready to commit. Comment at: include/clang/AST/DeclBase.h:562 @@ -561,1 +561,3 @@ + /// \brief Return true if this declaration is a definition of alias or ifunc. + bool

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

jroelofs added a comment. This is awesome! LGTM with one nit: add a newline between each function definition, and two between each class. It's a little crowded without that. http://reviews.llvm.org/D15813 ___ cfe-commits mailing list

r256585 - [TrailingObjects] Convert Decl* classes.

Author: jyknight Date: Tue Dec 29 16:13:13 2015 New Revision: 256585 URL: http://llvm.org/viewvc/llvm-project?rev=256585=rev Log: [TrailingObjects] Convert Decl* classes. Also remove now-redundant explicit alignment specification on some of the classes converted prior to TrailingObjects

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

bcraig closed this revision. bcraig added a comment. Committed as r256588. Thanks for the quick review! http://reviews.llvm.org/D15813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r256589 - [MS ABI] Invent a mangling for reference temporaries

Author: majnemer Date: Tue Dec 29 16:25:14 2015 New Revision: 256589 URL: http://llvm.org/viewvc/llvm-project?rev=256589=rev Log: [MS ABI] Invent a mangling for reference temporaries MSVC is non-conforming and doesn't have a mangling for these. Invent our own to unblock folks using clang. This

[libcxx] r256588 - [libcxx] Refactoring target_info.py

Author: bcraig Date: Tue Dec 29 16:21:38 2015 New Revision: 256588 URL: http://llvm.org/viewvc/llvm-project?rev=256588=rev Log: [libcxx] Refactoring target_info.py This patch makes it easier to support running the lit tests for new and unusual platforms. It will break existing users that set

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood updated this revision to Diff 43761. LegalizeAdulthood added a comment. Regenerate documentation from dump_ast_matchers.py http://reviews.llvm.org/D8149 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

aaron.ballman added inline comments. Comment at: include/clang/AST/DeclBase.h:563 @@ +562,3 @@ + /// \brief Return true if this declaration is a definition of alias or ifunc. + bool hasDefiningAttr() const; + I think this function and getDefiningAttr() can be

[PATCH] D15814: Implicit conversion from float->bool

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rtrieu, dblaikie. aaron.ballman added a subscriber: cfe-commits. When performing an implicit from float to bool, the floating point value must be *exactly* zero in order for the conversion to result in 0. This does not

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

jroelofs added a comment. > This patch makes it easier to support running the lit tests for new and > unusual platforms. It will break existing users that set LIBCXX_TARGET_INFO > to anything other than the default. I think this is fine, because the old > LIBCXX_TARGET_INFO wasn't terribly

Re: [PATCH] D15814: Implicit conversion from float->bool

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This seems to me as specific case of Clang-tidy readability-implicit-bool-cast. May be this check should be entirely moved to Clang? http://reviews.llvm.org/D15814

r256583 - [MS ABI] Add a mangling for _Complex

Author: majnemer Date: Tue Dec 29 16:02:15 2015 New Revision: 256583 URL: http://llvm.org/viewvc/llvm-project?rev=256583=rev Log: [MS ABI] Add a mangling for _Complex MSVC doesn't implement a mangling for C99's _Complex so we must invent our own. For now, treating it like a class type called

r256582 - [MS ABI] Mark an unreachable path appropriately

Author: majnemer Date: Tue Dec 29 16:02:10 2015 New Revision: 256582 URL: http://llvm.org/viewvc/llvm-project?rev=256582=rev Log: [MS ABI] Mark an unreachable path appropriately No functional change is intended, just a small cleanup. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp

r256587 - Use consistent types for all bit-field members in the same bit-field so that MSVC's bit-field packing algorithm packs them properly.

Author: rsmith Date: Tue Dec 29 16:19:20 2015 New Revision: 256587 URL: http://llvm.org/viewvc/llvm-project?rev=256587=rev Log: Use consistent types for all bit-field members in the same bit-field so that MSVC's bit-field packing algorithm packs them properly. Modified:

[libcxx] r256591 - [libcxx] Fixing the Linux sanitizer builds

Author: bcraig Date: Tue Dec 29 16:43:17 2015 New Revision: 256591 URL: http://llvm.org/viewvc/llvm-project?rev=256591=rev Log: [libcxx] Fixing the Linux sanitizer builds Modified: libcxx/trunk/test/libcxx/test/target_info.py Modified: libcxx/trunk/test/libcxx/test/target_info.py URL:

Re: [PATCH] D15814: Implicit conversion from float->bool

aaron.ballman added a comment. In http://reviews.llvm.org/D15814#317879, @Eugene.Zelenko wrote: > This seems to me as specific case of Clang-tidy > readability-implicit-bool-cast. May be this check should be entirely moved to > Clang? I think the reason why that is in clang-tidy is because

r256575 - Teach typo correction to properly handle mapping declarations to their

Author: rsmith Date: Tue Dec 29 13:43:10 2015 New Revision: 256575 URL: http://llvm.org/viewvc/llvm-project?rev=256575=rev Log: Teach typo correction to properly handle mapping declarations to their underlying decls. Preserve the found declaration throughout, and only map to the underlying

r256590 - [TrailingObjects] Convert OffsetOfExpr.

Author: jyknight Date: Tue Dec 29 16:31:18 2015 New Revision: 256590 URL: http://llvm.org/viewvc/llvm-project?rev=256590=rev Log: [TrailingObjects] Convert OffsetOfExpr. That necessitated moving the OffsetOfNode class out of OffsetOfExpr. Modified: cfe/trunk/include/clang/AST/Expr.h

r256623 - [MS ABI] Add variable templates to the NameBackReferences

Author: majnemer Date: Tue Dec 29 23:40:32 2015 New Revision: 256623 URL: http://llvm.org/viewvc/llvm-project?rev=256623=rev Log: [MS ABI] Add variable templates to the NameBackReferences Only function template specializations are exempt from being added to the NameBackReferences. Redundant

r256629 - [ptr-traits] Some compilers (older Clang? unsure) on build bots need

Author: chandlerc Date: Wed Dec 30 00:21:02 2015 New Revision: 256629 URL: http://llvm.org/viewvc/llvm-project?rev=256629=rev Log: [ptr-traits] Some compilers (older Clang? unsure) on build bots need this constructor to be out of line in order to not require the complete type of TemplateDecl.

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

ABataev added a comment. Hello Michael, Thanks for working on this. I still think we don't need OMPDeclareTargetDecl here and we can handle everything with an attribute. Try to implement everything just with an attribute and without OMPDeclareTargetDecl. http://reviews.llvm.org/D15321

r256619 - Fix alignment issue in CodeGenFunction::PopCleanupBlock.

Author: jyknight Date: Tue Dec 29 21:58:33 2015 New Revision: 256619 URL: http://llvm.org/viewvc/llvm-project?rev=256619=rev Log: Fix alignment issue in CodeGenFunction::PopCleanupBlock. It was copying an EHCleanupStack::Cleanup object into a SmallVector, with a comment saying that SmallVector's

[libcxx] r256621 - Fix locale feature testing in test suite.

Author: ericwf Date: Tue Dec 29 22:45:42 2015 New Revision: 256621 URL: http://llvm.org/viewvc/llvm-project?rev=256621=rev Log: Fix locale feature testing in test suite. Modified: libcxx/trunk/test/libcxx/test/target_info.py Modified: libcxx/trunk/test/libcxx/test/target_info.py URL:

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

EricWF added a comment. I re-added the feature myself in r256621. http://reviews.llvm.org/D15813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256622 - [MS ABI] Improve our mangling of pass_object_size

Author: majnemer Date: Tue Dec 29 23:13:03 2015 New Revision: 256622 URL: http://llvm.org/viewvc/llvm-project?rev=256622=rev Log: [MS ABI] Improve our mangling of pass_object_size We didn't add the artificial pass_object_size arguments to the backreference map which bloated the size of manglings

r256630 - [ptr-traits] Add another complete type that is necessary for at least

Author: chandlerc Date: Wed Dec 30 00:38:29 2015 New Revision: 256630 URL: http://llvm.org/viewvc/llvm-project?rev=256630=rev Log: [ptr-traits] Add another complete type that is necessary for at least some of the build bots. Still can't reproduce these failures locally. Modified:

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

DmitryPolukhin updated this revision to Diff 43775. DmitryPolukhin marked 8 inline comments as done. DmitryPolukhin added a comment. Fixed comments. http://reviews.llvm.org/D15524 Files: include/clang/AST/DeclBase.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

r256545 - [ms inline asm] Add support for label names with '$' chars

Author: myatsina Date: Tue Dec 29 02:49:34 2015 New Revision: 256545 URL: http://llvm.org/viewvc/llvm-project?rev=256545=rev Log: [ms inline asm] Add support for label names with '$' chars In MS inline asm syntax a label with '$' char produces an error, while in AT it does not. In AT inline asm

r256546 - clang-format: [JS/TypeScript] Support "enum" as property name.

Author: djasper Date: Tue Dec 29 02:54:23 2015 New Revision: 256546 URL: http://llvm.org/viewvc/llvm-project?rev=256546=rev Log: clang-format: [JS/TypeScript] Support "enum" as property name. Before: enum: string []; After: enum: string[]; Modified:

[PATCH] D15802: [clang-tidy] Don't generate duplicated blank line in add_new_check.py script.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D15802 Files: clang-tidy/add_new_check.py clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt docs/clang-tidy/checks/list.rst Index:

Re: [PATCH] D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls

a.sidorin updated this revision to Diff 43726. a.sidorin added a comment. C++11-fy adding loop. (Sorry for the noise.) http://reviews.llvm.org/D15410 Files: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/Analysis/inlining/analysis-order.c Index:

r256555 - [MS ABI] Cleanup the mangling of artifical types

Author: majnemer Date: Tue Dec 29 05:45:53 2015 New Revision: 256555 URL: http://llvm.org/viewvc/llvm-project?rev=256555=rev Log: [MS ABI] Cleanup the mangling of artifical types Hand-rolling the mangling results in us not correctly adding names to the backreference map. Modified:

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

alexfh added inline comments. Comment at: clang-tidy/google/DefinitionsInHeadersCheck.cpp:52 @@ +51,3 @@ +// Inline function is allowed. +if (funDecl->isInlined()) + return; hokein wrote: > alexfh wrote: > > This check can be done in the matcher. >

[clang-tools-extra] r256559 - [clang-tidy] Fix capitalization of the message in the example

Author: alexfh Date: Tue Dec 29 07:28:10 2015 New Revision: 256559 URL: http://llvm.org/viewvc/llvm-project?rev=256559=rev Log: [clang-tidy] Fix capitalization of the message in the example Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified:

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

alexfh added a comment. Thank you for working on this! A few minor comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21 @@ +20,3 @@ +namespace { +AST_MATCHER(VarDecl, isLocalVarDecl) { return Node.isLocalVarDecl(); } +AST_MATCHER(QualType,

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

DmitryPolukhin added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2700 @@ -2685,3 +2699,3 @@ return; Aliases.push_back(GD); rjmccall wrote: > Please diagnose that the resolver function has the appropriate type here. > Given the

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Fine by me -- I went with CERT since it's an acronym, but we don't do this for LLVM, so this change makes sense. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15805

Re: [PATCH] D15685: [clang-tidy] introducing cppcoreguidelines-enum-all-caps check

omtcyf0 added a comment. @alexfh, Thanks for the feedback! What you said seems reasonable to me, I'll follow your advice and come up with the proposed solution! http://reviews.llvm.org/D15685 ___ cfe-commits mailing list

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide accepted this revision. davide added a reviewer: davide. davide added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/Tools.cpp:941 @@ -940,3 +940,3 @@ - // The kext linker doesn't know how to deal with movw/movt. - if

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

ABataev marked 2 inline comments as done. Comment at: test/Sema/attr-x86-interrupt.c:54 @@ +53,3 @@ + foo8((int *)argv); // expected-error {{interrupt service routine can't be used directly}} + return 0; +} aaron.ballman wrote: > I'd like to see a test

Re: [PATCH] D15803: [clang-tidy] Don't generate duplicated blank line in add_new_check.py script.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. I'll submit the patch for you. Repository: rL LLVM http://reviews.llvm.org/D15803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

alexfh added a comment. In http://reviews.llvm.org/D15805#317629, @hokein wrote: > I'm wondering whether should we rename `CERT` to `cert` to keep the same > with other modules like misc and google. SGTM. Aaron, do you see any reasons not to do this? Repository: rL LLVM

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide added a comment. In http://reviews.llvm.org/D15791#317172, @dim wrote: > @davide, any idea whether lld will be able to handle movt correctly? If so, > we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ? lld/AArch64 can't still handle that properly, so I'd rather

Re: [PATCH] D15709: [X86] Support 'interrupt' attribute for x86

ABataev updated this revision to Diff 43727. ABataev added a comment. Update after review http://reviews.llvm.org/D15709 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

[clang-tools-extra] r256554 - [clang-tidy] Don't generate duplicated blank line in add_new_check.py script.

Author: alexfh Date: Tue Dec 29 05:05:35 2015 New Revision: 256554 URL: http://llvm.org/viewvc/llvm-project?rev=256554=rev Log: [clang-tidy] Don't generate duplicated blank line in add_new_check.py script. Reviewers: alexfh Subscribers: cfe-commits Patch by Haojian Wu! Differential Revision:

Re: [PATCH] D15803: [clang-tidy] Don't generate duplicated blank line in add_new_check.py script.

This revision was automatically updated to reflect the committed changes. Closed by commit rL256554: [clang-tidy] Don't generate duplicated blank line in add_new_check.py script. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15803?vs=43717=43728#toc Repository: rL

Re: [clang-tools-extra] r256517 - Orphaning these RST files; each one is retained only for link backwards compatibility.

Nice! Didn't know about this feature. On Mon, Dec 28, 2015 at 8:59 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Mon Dec 28 13:59:15 2015 > New Revision: 256517 > > URL: http://llvm.org/viewvc/llvm-project?rev=256517=rev > Log: > Orphaning

Re: [PATCH] D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls

a.sidorin removed rL LLVM as the repository for this revision. a.sidorin updated this revision to Diff 43723. a.sidorin added a comment. Added a comment. http://reviews.llvm.org/D15410 Files: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/Analysis/inlining/analysis-order.c Index:

r256557 - [MS ABI] Implement a mangling for _Atomic types

Author: majnemer Date: Tue Dec 29 05:46:00 2015 New Revision: 256557 URL: http://llvm.org/viewvc/llvm-project?rev=256557=rev Log: [MS ABI] Implement a mangling for _Atomic types MSVC doesn't implement a mangling for C11's _Atomic so we must invent our own. For now, treating it like a class type

Re: [PATCH] D15805: [clang-tidy] Cleanup code in CERT module.

hokein added a comment. I'm wondering whether should we rename `CERT` to `cert` to keep the same with other modules like misc and google. For adding a new check in CERT module, you need to use the upper name explicitly via `python add_new_check.py CERT foo` rather than `python

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

aaron.ballman added inline comments. Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23 @@ +22,3 @@ +bool inHeaderFile(const SourceManager *SM, SourceLocation Location) { + StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location)); + return