Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

bcraig added a comment. The "@" will do a ping through phabricator, but a direct email is probably going to be your best bet at this point. https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. @zaks.anna, changing the build system to explicitly select which sanitizer runtime to use is more complicated than it might seem. The sanitizer runtime libraries are named differently by toolchain, so correctly selecting a library would involve either duplicating

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) +ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); thakis wrote: >

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec : Spelling; +class Microsoft : Spelling; class CXX11 Given that MS have deprecated this syntax and are trying to

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec : Spelling; +class Microsoft : Spelling; class CXX11 thakis wrote: > rsmith wrote: > > Given that MS have

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis added inline comments. Comment at: include/clang/Parse/Parser.h:2217 @@ -2215,1 +2216,3 @@ + SourceLocation UuidLoc, + ParsedAttributes ); void ParseMicrosoftAttributes(ParsedAttributes ,

[libcxx] r280407 - [CMake] NFC. Missed the other uses in r280406

Author: cbieneman Date: Thu Sep 1 14:47:39 2016 New Revision: 280407 URL: http://llvm.org/viewvc/llvm-project?rev=280407=rev Log: [CMake] NFC. Missed the other uses in r280406 Doh! Obviously need to slow down. Modified: libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake Modified:

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator added a comment. In https://reviews.llvm.org/D21803#530681, @bcraig wrote: > In https://reviews.llvm.org/D21803#530678, @tavianator wrote: > > > Ping? > > > Well, I still think it's fine. Maybe a direct message to @mclow.lists or > @EricWF? Is there a way to do that through

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) +ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); thakis wrote: >

[PATCH] D24158: Try contextually converting condition of constexpr if to Boolean value

ismailp created this revision. ismailp added a reviewer: rsmith. ismailp added a subscriber: cfe-commits. C++1z 6.4.1/p2: If the if statement is of the form if constexpr, the value of the condition shall be a contextually converted constant expression of type bool [...] C++1z 5.20/p4: [...] A

Re: [PATCH] D24099: [libc++] Don't add -fPIC on Windows

compnerd closed this revision. compnerd added a comment. SVN r280413 https://reviews.llvm.org/D24099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24155: clang-format: [JS] merge requoting replacements.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. When formatting source code that needs both requoting and reindentation, merge the replacements to avoid erroring out for conflicting replacements.

[PATCH] D24163: [scan-build-py] Increase precision of timestamp in report directory name

dcoughlin created this revision. dcoughlin added a reviewer: rizsotto.mailinglist. dcoughlin added a subscriber: cfe-commits. This patch improves compatibility with the perl version of scan-build. The perl version of scan-build produces output report directories with increasing lexicographic

Re: [PATCH] D24105: [libc++] Limit gets to CRT versions below 14

compnerd closed this revision. compnerd added a comment. SVN r280417 https://reviews.llvm.org/D24105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) +ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); aaron.ballman wrote: > thakis

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

compnerd added a comment. Ugh, I was wrong. There is type information associated with a scoped enum. This means that `_LIBCPP_TYPE_VIS` is the right annotation here. https://reviews.llvm.org/D24065 ___ cfe-commits mailing list

[PATCH] D24159: Fix PR30202 - notify_all_at_thread_exit seg faults if run from a raw pthread context.

EricWF created this revision. EricWF added reviewers: mclow.lists, bcraig. EricWF added a subscriber: cfe-commits. This patch allows threads not created using `std::thread` to use `std::notify_all_at_thread_exit` by ensuring the TL state has been initialized within

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

kcc added reviewers: vitalybuka, eugenis. kcc added a comment. Sorry, I won't have a chance to look at it before late next week. Adding two more folks in case they have ideas. https://reviews.llvm.org/D24048 ___ cfe-commits mailing list

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8652 @@ +8651,3 @@ +/// +bool Sema::shouldLinkDependentDeclWithPrevious(Decl *D, Decl *PrevDecl) { + DeclContext *LexicalDC = D->getLexicalDeclContext(); Most of the logic in this function can be

Re: [PATCH] D19854: Define Contiki OS toolchain

mlemay-intel updated this revision to Diff 70076. mlemay-intel added a comment. Fixed indentation of Contiki constructor in ToolChains.h. https://reviews.llvm.org/D19854 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/fsanitize.c Index:

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis added inline comments. Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec : Spelling; +class Microsoft : Spelling; class CXX11 rsmith wrote: > Given that MS have deprecated this syntax and

r280420 - [WebAssembly] Change wasm SizeType to match asmjs

Author: dschuff Date: Thu Sep 1 17:38:37 2016 New Revision: 280420 URL: http://llvm.org/viewvc/llvm-project?rev=280420=rev Log: [WebAssembly] Change wasm SizeType to match asmjs Summary: We want wasm and asmjs to have matching ABIs, and right now asmjs uses unsigned int for its size_t. This

Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

This revision was automatically updated to reflect the committed changes. Closed by commit rL280420: [WebAssembly] Change wasm SizeType to match asmjs (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D24134?vs=70008=70082#toc Repository: rL LLVM

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

gribozavr added a subscriber: gribozavr. gribozavr added a comment. > If a user specifies "-fsanitize=" I think it is expected that the > sanitizer library would be included on the link line. I deeply disagree. If the user asks for `-nodefaultlibs`, we should not add any libraries ourselves,

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: zaks.anna, kubabrecka, bogner. > beanz added a subscriber: cfe-commits. > > The -nodefaultlibs and -nostdlib flags suppress all the runtime > libraries that the driver puts on the link line. This feels

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

zlei edited reviewers, added: bruno; removed: cfe-commits. zlei edited subscribers, added: cfe-commits; removed: bruno. zlei updated this revision to Diff 69947. zlei added a comment. Update the man page entry to state default behavior of this option. https://reviews.llvm.org/D24069 Files:

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, zaks.anna, bruno, filcab. > beanz added a subscriber: cfe-commits. > Herald added a subscriber: emaste. > > The FreeBSD and GNUTools drivers support -fsanitize arguments > bypassing

Re: r262189 - [modules] Prefer more complete array types.

On 01/09/16 02:59, Akira Hatanaka wrote: I’ve come up with a patch and sent it to the list today since it is urgent to fix. https://reviews.llvm.org/D24110 Thank you. I saw it landed in the trunk. Thanks! On Aug 31, 2016, at 1:50 PM, Vassil Vassilev

r280337 - Remove whitespace to test commit access

Author: honggyu.kim Date: Thu Sep 1 01:14:45 2016 New Revision: 280337 URL: http://llvm.org/viewvc/llvm-project?rev=280337=rev Log: Remove whitespace to test commit access Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp URL:

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet added inline comments. Comment at: test/clang-tidy/misc-enum-misuse.cpp:3 @@ +2,3 @@ + +enum Empty { +}; Could you specify which part of the file seems off? I have run the clang format with the same options on testfiles as on the others.

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) +ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); Silently ignoring seems

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: include/clang/Parse/Parser.h:2217 @@ -2215,1 +2216,3 @@ + SourceLocation UuidLoc, + ParsedAttributes ); void ParseMicrosoftAttributes(ParsedAttributes ,

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman added a comment. Ping https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r280406 - [CMake] NFC. Fixing spelling from r280400

Author: cbieneman Date: Thu Sep 1 14:46:02 2016 New Revision: 280406 URL: http://llvm.org/viewvc/llvm-project?rev=280406=rev Log: [CMake] NFC. Fixing spelling from r280400 Doh! Modified: libcxx/trunk/include/CMakeLists.txt Modified: libcxx/trunk/include/CMakeLists.txt URL:

[PATCH] D24153: Add bunch of _Interlocked builtins

agutowski created this revision. agutowski added reviewers: rnk, compnerd, thakis. agutowski added a subscriber: cfe-commits. https://reviews.llvm.org/D24153 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h test/CodeGen/ms-intrinsics.c Index:

Re: [PATCH] D24097: Add testcases for PR30188

sebpop abandoned this revision. sebpop added a comment. Agreed, this is a test for llvm/opt. I will submit another patch. https://reviews.llvm.org/D24097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r280409 - When we reach the end of a #include of a header of a local submodule that we

Author: rsmith Date: Thu Sep 1 15:15:25 2016 New Revision: 280409 URL: http://llvm.org/viewvc/llvm-project?rev=280409=rev Log: When we reach the end of a #include of a header of a local submodule that we textually included, create an ImportDecl just as we would if we reached a #include of any

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a subscriber: filcab. beanz added a comment. To address both @bogner and @gribozavr... The problem is we're wildly inconsistent on what -nodefaultlibs and -nostdlibs mean. For example, on GNUTools or FreeBSD -fsanitize *always* adds sanitizer libraries regardless of the presence

r280394 - [CMake] Properly connecting Compiler-RT check and test-depends

Author: cbieneman Date: Thu Sep 1 13:28:49 2016 New Revision: 280394 URL: http://llvm.org/viewvc/llvm-project?rev=280394=rev Log: [CMake] Properly connecting Compiler-RT check and test-depends This correctly connects compiler-rt-test-depends to test-depends and check-compiler-rt to check-all.

Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

sunfish added a comment. LGTM as a temporary workaround. https://reviews.llvm.org/D24134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim added a comment. Ping... https://reviews.llvm.org/D23960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

If we do add a warning, we probably need to make the warning more generic than this because it also applies to the Code coverage flags. -Chris > On Sep 1, 2016, at 11:29 AM, Bruno Cardoso Lopes > wrote: > > On Wed, Aug 31, 2016 at 11:00 PM, Justin Bogner

Re: [PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

dschuff added a comment. test comment https://reviews.llvm.org/D24134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280355 - [Frontend] Fix mcount inlining bug

Author: honggyu.kim Date: Thu Sep 1 06:29:21 2016 New Revision: 280355 URL: http://llvm.org/viewvc/llvm-project?rev=280355=rev Log: [Frontend] Fix mcount inlining bug Since some profiling tools, such as gprof, ftrace, and uftrace, use -pg option to generate a mcount function call at the entry

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

This revision was automatically updated to reflect the committed changes. Closed by commit rL280355: [Frontend] Fix mcount inlining bug (authored by honggyu.kim). Changed prior to commit: https://reviews.llvm.org/D22666?vs=68954=69986#toc Repository: rL LLVM https://reviews.llvm.org/D22666

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

rmaprath updated this revision to Diff 69962. rmaprath added a comment. Simplified the patch a little bit more. Now, library vendors should be able to define `_LIBCPP_STRICT_C99_COMPATIBILITY` and `libc++` will not use/test C99 math functions in `C++03/98` modes. Currently it's only the math

Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 updated this revision to Diff 69968. rogfer01 added a comment. Skip the check if the field is already aligned to 1. https://reviews.llvm.org/D23657 Files: lib/Sema/SemaChecking.cpp test/Sema/address-packed.c Index: test/Sema/address-packed.c

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... https://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24024: Checkout cfe when building clang-tools-extra docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280354: Checkout cfe when building clang-tools-extra docs. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D24024?vs=69667=69984#toc Repository: rL LLVM

r280352 - [analyzer][test commit] ExprEngine.cpp: Remove training whitespace; NFC

Author: a.sidorin Date: Thu Sep 1 06:11:46 2016 New Revision: 280352 URL: http://llvm.org/viewvc/llvm-project?rev=280352=rev Log: [analyzer][test commit] ExprEngine.cpp: Remove training whitespace; NFC Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Modified:

Re: [PATCH] D24065: [libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class

smeenai updated this revision to Diff 70087. smeenai retitled this revision from "[libc++] Don't attempt to dllexport enum class" to "[libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class". smeenai updated the summary for this revision. smeenai added a comment. Switching back to

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

ahatanak added a subscriber: ahatanak. ahatanak added a comment. This patch causes clang to error out on the following code, which used to compile fine: $ cat f2.c typedef __attribute__((__ext_vector_type__(8))) unsigned short vector_ushort8; vector_ushort8 foo1(void) { return 1 <<

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

jroelofs added a comment. In https://reviews.llvm.org/D21803#532382, @EricWF wrote: > In https://reviews.llvm.org/D21803#532347, @jroelofs wrote: > > > In https://reviews.llvm.org/D21803#532309, @EricWF wrote: > > > > > `__thread` > > > > > > What do you think of this idea? > > > > > > You'll

[PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[clang-tools-extra] r280456 - Add clang-reorder-fields to clang-tools-extra

Author: alexshap Date: Thu Sep 1 21:56:07 2016 New Revision: 280456 URL: http://llvm.org/viewvc/llvm-project?rev=280456=rev Log: Add clang-reorder-fields to clang-tools-extra This diff adds v0 of clang-reorder-fields tool to clang/tools/extra. The main idea behind this tool is to simplify and

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec : Spelling; +class Microsoft : Spelling; class CXX11 aaron.ballman wrote: > thakis wrote: > > rsmith wrote:

[PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: omtcyf0. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24178 Files: clang-rename/USRFinder.h Index:

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) +ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); aaron.ballman wrote: > thakis

[PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: sfantao, compnerd, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim added inline comments. Comment at: include/bitset:262 @@ -261,3 +261,3 @@ #elif __SIZEOF_SIZE_T__ == 4 -: __first_{__v, __v >> __bits_per_word} +: __first_{static_cast<__storage_type>(__v), static_cast<__storage_type>(__v >> __bits_per_word)} #else

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF added a comment. We can perform far fewer calls to `pthread_getspecific`/`pthread_setspecific` if we represent the list head using a global `__thread DtorList* list_head = nullptr`. This also allows us to avoid the hack of setting/unsetting the key during `run_dtors()` which I really do

Re: [PATCH] D23279: clang-reorder-fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL280431: Add clang-reorder-fields to clang-tools-extra (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23279?vs=69814=70102#toc Repository: rL LLVM

[clang-tools-extra] r280431 - Add clang-reorder-fields to clang-tools-extra

Author: alexshap Date: Thu Sep 1 18:49:48 2016 New Revision: 280431 URL: http://llvm.org/viewvc/llvm-project?rev=280431=rev Log: Add clang-reorder-fields to clang-tools-extra This diff adds v0 of clang-reorder-fields tool to clang/tools/extra. The main idea behind this tool is to simplify and

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Sorry this took so long. I was confused about the narrowing rules. https://reviews.llvm.org/D23960 ___ cfe-commits mailing list

r280434 - Refactor to avoid holding a reference to a container element that could go away

Author: rsmith Date: Thu Sep 1 19:10:28 2016 New Revision: 280434 URL: http://llvm.org/viewvc/llvm-project?rev=280434=rev Log: Refactor to avoid holding a reference to a container element that could go away during this function, and to avoid rolling back changes to the module manager's data

Buildbot numbers for the last week of 8/21/2016 - 8/27/2016

Hello everyone, Below are some buildbot numbers for the last week of 8/21/2016 - 8/27/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

jroelofs added a comment. In https://reviews.llvm.org/D21803#532309, @EricWF wrote: > `__thread` > > What do you think of this idea? You'll have to guard it against all the platforms that don't support TLS. Darwin 10.6 is one of them. https://reviews.llvm.org/D21803

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF added a comment. In https://reviews.llvm.org/D21803#532347, @jroelofs wrote: > In https://reviews.llvm.org/D21803#532309, @EricWF wrote: > > > `__thread` > > > > What do you think of this idea? > > > You'll have to guard it against all the platforms that don't support TLS. > Darwin 10.6

r280436 - Clean up handling of reading module files from stdin. Don't bother trying to

Author: rsmith Date: Thu Sep 1 19:18:05 2016 New Revision: 280436 URL: http://llvm.org/viewvc/llvm-project?rev=280436=rev Log: Clean up handling of reading module files from stdin. Don't bother trying to look for a corresponding file, since we're not going to read it anyway. No observable

r280426 - Remove excessive padding from MismatchingNewDeleteDetector

Author: alexshap Date: Thu Sep 1 18:18:00 2016 New Revision: 280426 URL: http://llvm.org/viewvc/llvm-project?rev=280426=rev Log: Remove excessive padding from MismatchingNewDeleteDetector The class MismatchingNewDeleteDetector is in lib/Sema/SemaExprCXX.cpp inside the anonymous namespace. This

Re: [PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

This revision was automatically updated to reflect the committed changes. Closed by commit rL280426: Remove excessive padding from MismatchingNewDeleteDetector (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23898?vs=69306=70094#toc Repository: rL LLVM

Re: [PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

ismailp accepted this revision. ismailp added a comment. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D23898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r280359 - [include-fixer] Fix an undefined variable exception in vim script when there is

Author: hokein Date: Thu Sep 1 07:17:28 2016 New Revision: 280359 URL: http://llvm.org/viewvc/llvm-project?rev=280359=rev Log: [include-fixer] Fix an undefined variable exception in vim script when there is only one candidate header. Modified:

r280360 - [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion

Author: a.sidorin Date: Thu Sep 1 07:25:16 2016 New Revision: 280360 URL: http://llvm.org/viewvc/llvm-project?rev=280360=rev Log: [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion Some FileIDs that may be used by PlistDiagnostics were not added while building a list of

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

This revision was automatically updated to reflect the committed changes. Closed by commit rL280360: [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion (authored by a.sidorin). Changed prior to commit: https://reviews.llvm.org/D22090?vs=68987=69993#toc Repository: rL LLVM

[PATCH] D24136: [OpenCL] Fix pipe built-in functions return type.

bader created this revision. bader added a reviewer: Anastasia. bader added subscribers: yaxunl, cfe-commits. By default return type of call expressions calling built-in functions is set to bool. Fixes https://llvm.org/bugs/show_bug.cgi?id=30219. https://reviews.llvm.org/D24136 Files:

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv added a comment. Just a drive-by nit. Thanks for the patch! Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

rsmith added a comment. Lgtm other than George's nit. https://reviews.llvm.org/D24152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280367 - [analyzer] ExprEngine: remove second call to PreStmt

Author: a.sidorin Date: Thu Sep 1 08:55:38 2016 New Revision: 280367 URL: http://llvm.org/viewvc/llvm-project?rev=280367=rev Log: [analyzer] ExprEngine: remove second call to PreStmt This patch also introduces AnalysisOrderChecker which is intended for testing of callback call correctness.

Re: [PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein updated this revision to Diff 69994. hokein added a comment. Add editor scripts support. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-include-fixer.el

[PATCH] D24134: [WebAssembly] Change wasm SizeType to match asmjs

jgravelle-google created this revision. jgravelle-google added a reviewer: dschuff. jgravelle-google added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. We want wasm and asmjs to have matching ABIs, and right now asmjs uses unsigned int for its size_t. This causes exported

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet updated this revision to Diff 70017. szepet marked 11 inline comments as done. szepet added a comment. Changes based on comments, fix a cast to dyn_cast bug, description updated (hopefully it became more clear). https://reviews.llvm.org/D22507 Files: clang-tidy/misc/CMakeLists.txt

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis updated this revision to Diff 70013. thakis marked an inline comment as done. thakis added a comment. Sorry about the delay! Now with custom parsing code that accepts uuid() without quotes. I thought this would be complicated, but ended up being not so bad in the end. See the tests for

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rnk added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3943 @@ +3942,3 @@ + } else { +// something like uuid({00A0---C000-0049}) -- no +// quotes in the parens. Just append the spelling of all tokens encountered This isn't