[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

malcolm.parsons added inline comments. Comment at: include/clang/AST/TypeLoc.h:513 struct BuiltinLocInfo { - SourceLocation BuiltinLoc; + SourceRange BuiltinRange; }; aaron.ballman wrote: > malcolm.parsons wrote: > > aaron.ballman wrote: > > >

[PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

yaxunl updated this revision to Diff 75203. yaxunl marked 4 inline comments as done. yaxunl added a comment. Fix typo in test. https://reviews.llvm.org/D25343 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CGCall.cpp lib/Headers/opencl-c.h

[PATCH] D25793: Don't crash generating debug info for VLA in function prototype.

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGDebugInfo.cpp:2183-2185 + if (VAT->getSizeExpr()) { +llvm::APSInt V; +if (VAT->getSizeExpr()->EvaluateAsInt(V,

[PATCH] D25797: [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added a subscriber: cfe-commits. NFC https://reviews.llvm.org/D25797 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCUDA.cpp Index: clang/lib/Sema/SemaCUDA.cpp

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

manmanren added a comment. It makes sense to rebuild the expression when a field designator stores a FieldDecl. Thanks for working on this! Manman Comment at: lib/Sema/TreeTransform.h:8926 D.getFieldLoc())); + if

[PATCH] D25779: MS ABI: Don't assert when generating virtual function call with virtual bases and -flto (PR30731)

hans added a comment. In https://reviews.llvm.org/D25779#574630, @majnemer wrote: > Why did this only fail with -flto? Seems strange. I was asking myself the same thing :-) It's because of this code in MicrosoftCXXABI::getVirtualFunctionPointer: if (CGM.getCodeGenOpts().PrepareForLTO) //

[PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

yaxunl added a comment. > Should we deprecate noduplicate then as convergent should cover both use > cases for OpenCL I believe? As far as I understand noduplicate was added > specifically for SPMD use cases... noduplicate has different semantics than convergent. Although it is proposed for

r284638 - New clang option -mpie-copy-relocations to use copy relocations for PIE builds.

Author: tmsriram Date: Wed Oct 19 15:24:06 2016 New Revision: 284638 URL: http://llvm.org/viewvc/llvm-project?rev=284638=rev Log: New clang option -mpie-copy-relocations to use copy relocations for PIE builds. Differential Revision: https://reviews.llvm.org/D19996 Modified:

[PATCH] D19996: New clang option -mpie-copy-relocationss to indicate support for linker copy relocations when linking as PIE

This revision was automatically updated to reflect the committed changes. Closed by commit rL284638: New clang option -mpie-copy-relocations to use copy relocations for PIE builds. (authored by tmsriram). Changed prior to commit: https://reviews.llvm.org/D19996?vs=75189=75212#toc Repository:

[PATCH] D25704: [CUDA] When we emit an error that might have been deferred, also print a callstack.

jlebar marked 2 inline comments as done. jlebar added a comment. I'm going to submit this and send a patch to reuse FunctionDeclAndLoc. But I'm happy to add a comment about the note as well. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707 +def

[PATCH] D25704: [CUDA] When we emit an error that might have been deferred, also print a callstack.

jlebar marked 2 inline comments as done. jlebar added a comment. Thank you for the review, Reid. https://reviews.llvm.org/D25704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284646 - [CMake] Support thin LTO in PGO CMake cache

Author: cbieneman Date: Wed Oct 19 16:12:04 2016 New Revision: 284646 URL: http://llvm.org/viewvc/llvm-project?rev=284646=rev Log: [CMake] Support thin LTO in PGO CMake cache This allows you to set PGO_INSTRUMENT_LTO=Thin and have it work correctly. Modified:

r284639 - [ubsan] Re-work check lines to try to appease a bot (NFC)

Author: vedantk Date: Wed Oct 19 15:28:35 2016 New Revision: 284639 URL: http://llvm.org/viewvc/llvm-project?rev=284639=rev Log: [ubsan] Re-work check lines to try to appease a bot (NFC) This bot does not produce the IR I expect -- it's missing some 'handler.dynamic_type_cache_miss:' labels. We

r284647 - [CUDA] When we emit an error that might have been deferred, also print a callstack.

Author: jlebar Date: Wed Oct 19 16:15:01 2016 New Revision: 284647 URL: http://llvm.org/viewvc/llvm-project?rev=284647=rev Log: [CUDA] When we emit an error that might have been deferred, also print a callstack. Summary: Previously, when you did something not allowed in a host+device function

[PATCH] D25704: [CUDA] When we emit an error that might have been deferred, also print a callstack.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284647: [CUDA] When we emit an error that might have been deferred, also print a… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25704?vs=75178=75226#toc Repository: rL

[PATCH] D25796: [CUDA] Create __host__ and device variants of standard allocator declarations.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. Implicit functions are treated as if they were __host__ __device__ and clang does not allow overloading those with __host__ or __device__ variants. In order for users to provide their own standard

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

mgorny added a comment. Do you think I should just focus on the suffix, or maybe try to make the whole path configurable? https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25793: Don't crash generating debug info for VLA in function prototype.

efriedma created this revision. efriedma added a reviewer: dblaikie. efriedma added a subscriber: cfe-commits. efriedma set the repository for this revision to rL LLVM. Fixes regression from r279445. Repository: rL LLVM https://reviews.llvm.org/D25793 Files: lib/CodeGen/CGDebugInfo.cpp

r284648 - [CMake] Add clang-bootstrap-deps target

Author: cbieneman Date: Wed Oct 19 16:18:48 2016 New Revision: 284648 URL: http://llvm.org/viewvc/llvm-project?rev=284648=rev Log: [CMake] Add clang-bootstrap-deps target Having this target allows other parts of the build system to add to the bootstrap dependencies without needing to be defined

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

bruno added a comment. Thanks for looking into this. It's a nice FixIt to have. I don't see any dep cycle; clangFormat depends on clangToolingCore, which also depends clangRewrite, which means there are going to be 3 new dependencies for libSema in the end: clangToolingCore, clangRewrite and

[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC

bruno added inline comments. Comment at: lib/Driver/ToolChains.cpp:3903 +if (!Data.split('.').first.getAsInteger(10, MajorVersion)) { + switch (MajorVersion) { +case 5: clang-format the `switch`: `case`'s should be aligned with it.

r284642 - [ubsan] Drop dependency on a 64-bit arch in a test (NFC)

Author: vedantk Date: Wed Oct 19 15:53:16 2016 New Revision: 284642 URL: http://llvm.org/viewvc/llvm-project?rev=284642=rev Log: [ubsan] Drop dependency on a 64-bit arch in a test (NFC) This should fix: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/46184 Modified:

[PATCH] D25779: MS ABI: Don't assert when generating virtual function call with virtual bases and -flto (PR30731)

majnemer added a comment. Why did this only fail with -flto? Seems strange. Repository: rL LLVM https://reviews.llvm.org/D25779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL284636: [ubsan] Use the object pointer's type info for devirtualized calls (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25448?vs=75168=75211#toc Repository: rL LLVM

r284644 - [AST] Add CanonicalDeclPtr.

Author: jlebar Date: Wed Oct 19 16:03:42 2016 New Revision: 284644 URL: http://llvm.org/viewvc/llvm-project?rev=284644=rev Log: [AST] Add CanonicalDeclPtr. Summary: CanonicalDeclPtr is just like a T*, except it calls T::getCanonicalDecl() on construction. This is useful as the key in a "set of

r284643 - [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

Author: jlebar Date: Wed Oct 19 16:03:38 2016 New Revision: 284643 URL: http://llvm.org/viewvc/llvm-project?rev=284643=rev Log: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls. Summary: This fixes two related bugs: 1) Previously, if you had a non-wrong

r284636 - [ubsan] Use the object pointer's type info for devirtualized calls

Author: vedantk Date: Wed Oct 19 15:21:16 2016 New Revision: 284636 URL: http://llvm.org/viewvc/llvm-project?rev=284636=rev Log: [ubsan] Use the object pointer's type info for devirtualized calls ubsan reports a false positive 'invalid member call' diagnostic on the following example (PR30478):

[PATCH] D25703: [AST] Add CanonicalDeclPtr.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284644: [AST] Add CanonicalDeclPtr. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25703?vs=74911=75222#toc Repository: rL LLVM https://reviews.llvm.org/D25703 Files:

[PATCH] D25702: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284643: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25702?vs=74910=75220#toc Repository:

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

Hi All, Sorry about the delay. I'll unbreak the tests tomorrow afternoon (I have a midterm in the morning) /Eric On Oct 18, 2016 9:00 PM, "Tim Northover" wrote: > On 15 October 2016 at 13:08, Eric Fiselier via cfe-commits > wrote: > > Are

r284573 - [clang-format] Add comment manipulation header

Author: ioeric Date: Wed Oct 19 03:19:46 2016 New Revision: 284573 URL: http://llvm.org/viewvc/llvm-project?rev=284573=rev Log: [clang-format] Add comment manipulation header Summary: Introduces a separate target for comment manipulation. Currently, comment manipulation is in

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a

[PATCH] D25762: [clang-move] Move using-decl in old cc.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:356 Finder->addMatcher( - namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())), -inAnonymousNamespace) - .bind("decls_in_anonymous_ns"), +

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

I totally misinterpreted this revert. I was confused it reverted r284284. Sorry for the noise. With the fix introduced in r284577 our bots should be happy. On 19/10/16 09:50, Vassil Vassilev wrote: On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

srhines created this revision. srhines added a reviewer: cfe-commits. srhines added subscribers: danalbert, pirama. Herald added subscribers: tberghammer, rengolin, aemerson. This is only forced on if there is no non-Cortex-A53 CPU specified as well. Android's platform and NDK builds need to

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

srhines added a comment. From what I can tell, there is no nice way to generate tests for Clang's driver when producing linker flags. -### only works for the -cc1 command line (which won't see this flag, since it is only for linking, and not compilation). If there is a suggestion for how to

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

srhines added a comment. In https://reviews.llvm.org/D25761#573902, @rengolin wrote: > In https://reviews.llvm.org/D25761#573892, @srhines wrote: > > > From what I can tell, there is no nice way to generate tests for Clang's > > driver when producing linker flags. -### only works for the -cc1

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r284577. https://reviews.llvm.org/D25678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev Log: [modules] Do not report missing definitions of demoted constexpr variable templates. This is a followup to regression introduced in r284284. This should fix our

[PATCH] D25762: [clang-move] Move using-decl in old cc.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. Another fix is to move the whole anonymous namespace declaration completely instead of moving fun/var declarations only. https://reviews.llvm.org/D25762 Files: clang-move/ClangMove.cpp

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

rengolin added a comment. In https://reviews.llvm.org/D25761#573892, @srhines wrote: > From what I can tell, there is no nice way to generate tests for Clang's > driver when producing linker flags. -### only works for the -cc1 command line > (which won't see this flag, since it is only for

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

bader accepted this revision. bader added a comment. LGTM https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

jmolloy accepted this revision. jmolloy added a reviewer: jmolloy. jmolloy added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

rengolin added a comment. In https://reviews.llvm.org/D25761#573903, @srhines wrote: > > I think "clang -v" will show the linker invocation, with all its flags. > > But is there a way to get a dry-run of the linker? I don't want to run > /usr/bin/ld for ARM targets. It seems like all of the

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284579: [Sema] Gcc compatibility of vector shift (authored by asbokhan). Changed prior to commit: https://reviews.llvm.org/D24669?vs=74269=75130#toc Repository: rL LLVM

[PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

efriedma added a comment. Ping https://reviews.llvm.org/D24378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r284624 - MS ABI: Fix assert when generating virtual function call with virtual bases and -flto (PR30731)

On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Wed Oct 19 13:04:27 2016 > New Revision: 284624 > > URL: http://llvm.org/viewvc/llvm-project?rev=284624=rev > Log: > MS ABI: Fix assert when generating virtual function call

[PATCH] D25797: [CUDA] Use FunctionDeclAndLoc for the Sema::LocsWithCUDACallDiags hashtable.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284669 - Extend hack to work around bad exception specifications for 'swap' members to

Author: rsmith Date: Wed Oct 19 18:47:37 2016 New Revision: 284669 URL: http://llvm.org/viewvc/llvm-project?rev=284669=rev Log: Extend hack to work around bad exception specifications for 'swap' members to also cover libstdc++'s std::__debug::array and std::__profile::array. Modified:

Re: r284624 - MS ABI: Fix assert when generating virtual function call with virtual bases and -flto (PR30731)

On Wed, Oct 19, 2016 at 3:38 PM, David Majnemer wrote: > > > On Wed, Oct 19, 2016 at 2:04 PM, Hans Wennborg via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: hans >> Date: Wed Oct 19 13:04:27 2016 >> New Revision: 284624 >> >> URL:

r284683 - Upgrade debug-info-vla test: we do not pass default alignment now

Author: vleschuk Date: Wed Oct 19 19:37:07 2016 New Revision: 284683 URL: http://llvm.org/viewvc/llvm-project?rev=284683=rev Log: Upgrade debug-info-vla test: we do not pass default alignment now Modified: cfe/trunk/test/CodeGenCXX/debug-info-vla.cpp Modified:

[PATCH] D25793: Don't crash generating debug info for VLA in function prototype.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284652: Don't crash generating debug info for VLA in function prototype. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D25793?vs=75219=75243#toc Repository: rL LLVM

r284652 - Don't crash generating debug info for VLA in function prototype.

Author: efriedma Date: Wed Oct 19 17:16:32 2016 New Revision: 284652 URL: http://llvm.org/viewvc/llvm-project?rev=284652=rev Log: Don't crash generating debug info for VLA in function prototype. Fixes regression from r279445. Differential Revision: https://reviews.llvm.org/D25793 Modified:

r284667 - Use noexcept instead of LLVM_NOEXCEPT now that all compilers support it

Author: rnk Date: Wed Oct 19 18:39:55 2016 New Revision: 284667 URL: http://llvm.org/viewvc/llvm-project?rev=284667=rev Log: Use noexcept instead of LLVM_NOEXCEPT now that all compilers support it Modified: cfe/trunk/include/clang/AST/Attr.h cfe/trunk/include/clang/AST/Stmt.h

[PATCH] D25806: Module: correctly set the module file kind when emitting diagnostics for file_modified

manmanren created this revision. manmanren added reviewers: bruno, rsmith, benlangmuir. manmanren added a subscriber: cfe-commits. I don't quite like the if statement in the patch, but given that ASTReader::Error and DelayedDiagnostic only take strings, it is hard to just change

r284673 - Fix crash on noreturn conversion in unprototyped function type. Thanks to Keith

Author: rsmith Date: Wed Oct 19 19:01:36 2016 New Revision: 284673 URL: http://llvm.org/viewvc/llvm-project?rev=284673=rev Log: Fix crash on noreturn conversion in unprototyped function type. Thanks to Keith Walker for spotting the bug. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande added a comment. ping - seems I'm unable to commit this myself. Thanks! https://reviews.llvm.org/D25153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284658 - [cmake] Follow LLVM's lead in creating exported tool targets for clang tools.

Author: mgottesman Date: Wed Oct 19 17:46:06 2016 New Revision: 284658 URL: http://llvm.org/viewvc/llvm-project?rev=284658=rev Log: [cmake] Follow LLVM's lead in creating exported tool targets for clang tools. This is needed by downstream projects such as swift to get proper cmake dependency

[PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Sunil_Srivastava added a comment. ping https://reviews.llvm.org/D22057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

kparzysz created this revision. kparzysz added a reviewer: EricWF. kparzysz added a subscriber: cfe-commits. kparzysz set the repository for this revision to rL LLVM. The characters like '\xDA' or '\xFA' are not valid representations of anything in UTF-8, so toupper and tolower return the

r284653 - Add optimization to sizeof...(X) handling: if none of parameter pack X's

Author: rsmith Date: Wed Oct 19 17:18:42 2016 New Revision: 284653 URL: http://llvm.org/viewvc/llvm-project?rev=284653=rev Log: Add optimization to sizeof...(X) handling: if none of parameter pack X's corresponding arguments are unexpanded pack expansions, we can compute the result without

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D25595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, looks good with some nits Comment at: lib/CodeGen/CGDebugInfo.cpp:1397 const auto *Base = cast(BI.getType()->getAs()->getDecl()); rnk

[libcxx] r284691 - Attempt to workaround XPASS for aligned allocation tests

Author: ericwf Date: Wed Oct 19 22:31:07 2016 New Revision: 284691 URL: http://llvm.org/viewvc/llvm-project?rev=284691=rev Log: Attempt to workaround XPASS for aligned allocation tests Modified:

r284690 - Replace uses of LLVM_FUNCTION_NAME with __func__, this was macro was removed from llvm/Support in r284681

Author: epilk Date: Wed Oct 19 21:46:22 2016 New Revision: 284690 URL: http://llvm.org/viewvc/llvm-project?rev=284690=rev Log: Replace uses of LLVM_FUNCTION_NAME with __func__, this was macro was removed from llvm/Support in r284681 Modified: cfe/trunk/tools/libclang/CIndexHigh.cpp

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

EricWF added a comment. Seems like we should figure out why these pass on ToT OS X. Repository: rL LLVM https://reviews.llvm.org/D25811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25760: [AVX512][Clang] Adding missing instructions' variations

craig.topper added inline comments. Comment at: lib/Headers/avx512vbmivlintrin.h:225 static __inline__ __m256i __DEFAULT_FN_ATTRS -_mm256_maskz_multishift_epi64_epi8 (__mmask32 __M, __m256i __X, __m256i __Y) +_mm256_maskz_multishift_epi64_epi8 (__mmask8 __M, __m256i __X,

[PATCH] D25813: [CodeGen] Devirtualize calls to methods marked final in a derived class

vsk created this revision. vsk added reviewers: rjmccall, pcc. vsk added a subscriber: cfe-commits. If we see a virtual method call to Base::foo() but can infer that the object is an instance of Derived, and that 'foo' is marked 'final' in Derived, we can devirtualize the call to Derived::foo().

Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

Brad Smith wrote: > On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote: > > On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: > > > Author: emaste > > > Date: Fri Oct 14 12:59:53 2016 > > > New Revision: 284256 > > > > > > URL:

[PATCH] D25762: [clang-move] Move using-decl in old cc.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-move/ClangMove.cpp:356 Finder->addMatcher( - namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())), -inAnonymousNamespace) -

[PATCH] D25760: [AVX512][Clang] Adding missing instructions' variations

coby created this revision. coby added reviewers: m_zuckerman, igorb, AsafBadouh, craig.topper. coby added a subscriber: cfe-commits. coby set the repository for this revision to rL LLVM. The following patch introduces the following alternations: 1. correcting the 'vpmulshiftqb' instruction,

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

eladcohen added a comment. In https://reviews.llvm.org/D25337#571877, @rsmith wrote: > I really don't like the command-line interface you're proposing here. It > seems like it will be extremely confusing what something like `-fmodules > -fexclusive-builtin-modules` means, for instance

[PATCH] D25762: [clang-move] Move using-decl in old cc.

hokein updated this revision to Diff 75139. hokein marked 2 inline comments as done. hokein added a comment. Address comments. - Cover type alias declarations. - Fix an issue of moving function-scope static definitions in non-moved classes. https://reviews.llvm.org/D25762 Files:

[PATCH] D25768: [Format] Cleanup after replacing constructor body with = default

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D25768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25741: [libc++] Add configuration define for off_t functions

smeenai updated this revision to Diff 75142. smeenai added a comment. Addressing @mclow.lists's comment https://reviews.llvm.org/D25741 Files: include/__config include/fstream Index: include/fstream === --- include/fstream

[PATCH] D25770: [clang-tidy] Add cert-err09-cpp check alias.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, thanks. https://reviews.llvm.org/D25770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25771: [change-namespace] shorten namespace qualifier based on UsingDecl and UsingDirectiveDecl.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. when replacing symbol references in moved namespaces, trying to make the replace name as short as possible by considering UsingDecl (i.e. UsingShadow) and UsingDirectiveDecl (i.e. using

[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

malcolm.parsons added inline comments. Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85 + // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default' + // CHECK-FIXES: /* don't delete */ = default; int Field; I don't know why cleanup removes

r284589 - Don't copy replacements in for-range loop. NFC.

Author: d0k Date: Wed Oct 19 08:50:17 2016 New Revision: 284589 URL: http://llvm.org/viewvc/llvm-project?rev=284589=rev Log: Don't copy replacements in for-range loop. NFC. Modified: cfe/trunk/lib/Format/TokenAnalyzer.cpp Modified: cfe/trunk/lib/Format/TokenAnalyzer.cpp URL:

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added a subscriber: rsmith. v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; bkramer wrote:

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; Using emplace seems to break our modules libstdc++ 4.7

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai added a comment. Ping. The way I see it, this doesn't change anything for people not building with hidden visibility (which should be most people, including the buildbots), but it does make `_LIBCPP_TYPE_VIS` more useful (and consistent with the existing Windows behavior) for people

[clang-tools-extra] r284589 - Don't copy replacements in for-range loop. NFC.

Author: d0k Date: Wed Oct 19 08:50:17 2016 New Revision: 284589 URL: http://llvm.org/viewvc/llvm-project?rev=284589=rev Log: Don't copy replacements in for-range loop. NFC. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp Modified:

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

eladcohen added a comment. In https://reviews.llvm.org/D25337#571845, @bruno wrote: > > The long answer is that there is a history of problems regarding the > > intrinsic files: > > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html > >

[PATCH] D25767: [Modules] Add a command line option for loading the clang builtins modulemap file.

eladcohen created this revision. eladcohen added reviewers: rsmith, bruno, zvi. eladcohen added a subscriber: cfe-commits. -fbuiltin-module-map loads the clang builtins modulemap file. (This is equivalent to -fmodule-map-file=/include/module.modulemap) It can be used for enabling clang's

r284595 - Remove unused diagnostics. NFC.

Author: d0k Date: Wed Oct 19 09:22:38 2016 New Revision: 284595 URL: http://llvm.org/viewvc/llvm-project?rev=284595=rev Log: Remove unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

[clang-tools-extra] r284596 - [clang-tidy] Add cert-err09-cpp check alias.

Author: mkurdej Date: Wed Oct 19 09:28:19 2016 New Revision: 284596 URL: http://llvm.org/viewvc/llvm-project?rev=284596=rev Log: [clang-tidy] Add cert-err09-cpp check alias. Summary: This adds cert-err09-cpp alias for completeness, similar to cert-err61-cpp. Reviewers: alexfh, hokein

[PATCH] D25621: DebugInfo: use uin32_t for alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL284651: DebugInfo: use uint32_t for alignment variables. (authored by vleschuk). Changed prior to commit: https://reviews.llvm.org/D25621?vs=75143=75241#toc Repository: rL LLVM

r284651 - DebugInfo: use uint32_t for alignment variables.

Author: vleschuk Date: Wed Oct 19 17:11:07 2016 New Revision: 284651 URL: http://llvm.org/viewvc/llvm-project?rev=284651=rev Log: DebugInfo: use uint32_t for alignment variables. LLVM now uses uint32_t for DebugInfo alignment for space efficiency, in this patch we change frontend

[PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

This revision was automatically updated to reflect the committed changes. Closed by commit rL284679: DebugInfo: pass alignment value only if it was forced (authored by vleschuk). Changed prior to commit: https://reviews.llvm.org/D24426?vs=74686=75261#toc Repository: rL LLVM

r284679 - DebugInfo: pass alignment value only if it was forced

Author: vleschuk Date: Wed Oct 19 19:13:19 2016 New Revision: 284679 URL: http://llvm.org/viewvc/llvm-project?rev=284679=rev Log: DebugInfo: pass alignment value only if it was forced Preparation to implement DW_AT_alignment support: - We pass non-zero align value to DIBuilder only when

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra created this revision. tra added reviewers: jlebar, rsmith. tra added a subscriber: cfe-commits. Current behavior: - __host__ __device__ (HD) functions are considered to be redeclarations of `__host__` (H) of `__device__` (D) functions with same signature. - Target attributes are not taken

r284684 - PR26276: Fix detection of non-cast-expressions as operands of fold-expressions.

Author: rsmith Date: Wed Oct 19 19:55:15 2016 New Revision: 284684 URL: http://llvm.org/viewvc/llvm-project?rev=284684=rev Log: PR26276: Fix detection of non-cast-expressions as operands of fold-expressions. Modified: cfe/trunk/include/clang/AST/ExprCXX.h cfe/trunk/lib/AST/ExprCXX.cpp

r284685 - Refactor and simplify Sema::FindCompositePointerType. No functionality change intended.

Author: rsmith Date: Wed Oct 19 20:20:00 2016 New Revision: 284685 URL: http://llvm.org/viewvc/llvm-project?rev=284685=rev Log: Refactor and simplify Sema::FindCompositePointerType. No functionality change intended. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp Modified:

[clang-tools-extra] r284592 - [clang-move] Move using-decl in old cc.

Author: hokein Date: Wed Oct 19 09:13:21 2016 New Revision: 284592 URL: http://llvm.org/viewvc/llvm-project?rev=284592=rev Log: [clang-move] Move using-decl in old cc. Summary: Another fix is to move the whole anonymous namespace declaration completely instead of moving fun/var declarations

[PATCH] D25762: [clang-move] Move using-decl in old cc.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rL284592: [clang-move] Move using-decl in old cc. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25762?vs=75139=75146#toc Repository:

[PATCH] D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Target/X86/X86ISelLowering.cpp:32315 +} + // Else fall through (handle "Y" constraint). case 'v': Use LLVM_FALLTHROUGH here to avoid

[PATCH] D25703: [AST] Add CanonicalDeclPtr.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25702: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm I'm assuming you're going to follow this up with CanonicalDeclPtr usage. https://reviews.llvm.org/D25702 ___

[PATCH] D25702: [CUDA] Emit errors for wrong-side calls made on the same line as non-wrong-side calls.

jlebar added a comment. In https://reviews.llvm.org/D25702#574289, @rnk wrote: > lgtm > > I'm assuming you're going to follow this up with CanonicalDeclPtr usage. Yes, that's in https://reviews.llvm.org/D25704. https://reviews.llvm.org/D25702

  1   2   >