r299354 - [ASTImporter] Lookup SearchName instead of Name

Author: xazax Date: Mon Apr 3 04:30:20 2017 New Revision: 299354 URL: http://llvm.org/viewvc/llvm-project?rev=299354=rev Log: [ASTImporter] Lookup SearchName instead of Name When the SearchName is already calculated we should use that for the lookup. Patch by Peter Szecsi! Differential

[PATCH] D26953: clang-format: handle formatting on constexpr if

gnzlbg added a comment. any progress on this? https://reviews.llvm.org/D26953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr updated this revision to Diff 93841. huntergr added a reviewer: kkwli0. huntergr added a comment. Changed to transform combined constructs to simd in ParseOpenMP.cpp instead of creating a new pragma handler. This also made it easier to add support for 'declare simd': only needed the

[libcxx] r299401 - Fix C++17 dylib build

Author: ericwf Date: Mon Apr 3 18:23:44 2017 New Revision: 299401 URL: http://llvm.org/viewvc/llvm-project?rev=299401=rev Log: Fix C++17 dylib build Modified: libcxx/trunk/include/algorithm Modified: libcxx/trunk/include/algorithm URL:

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34 + + if (const auto *B = Result.Nodes.getNodeAs("binary")) { +switch (B->getOpcode()) { alexfh wrote: > aaron.ballman wrote: > > mgehre wrote: > > >

[PATCH] D31637: [Sema] Implement LWG 2015 for the builtin type-traits.

EricWF created this revision. This patch implements LWG 2015 , which requires than arrays used with [meta.unary.prop] traits have a complete element type. If I'm not mistaken the correct thing to do is to retroactively apply it to C++11

[libcxx] r299411 - Fix more -Wshadow warnings introduced by recent Clang change

Author: ericwf Date: Mon Apr 3 21:54:27 2017 New Revision: 299411 URL: http://llvm.org/viewvc/llvm-project?rev=299411=rev Log: Fix more -Wshadow warnings introduced by recent Clang change Modified: libcxx/trunk/test/std/containers/associative/map/map.cons/iter_iter_comp_alloc.pass.cpp

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Makes sense to me. Some questions inline, but they may not necessitate changes, so I'm accepting. Comment at: lib/CMakeLists.txt:166 + if (NOT

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34 + + if (const auto *B = Result.Nodes.getNodeAs("binary")) { +switch (B->getOpcode()) { aaron.ballman wrote: > alexfh wrote: > > aaron.ballman wrote:

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

EricWF added a comment. This started making the libc++ bots fail, and I'm not convinced the case is reasonable to warn on. That case is: struct path { using value_type = char; struct iterator { using value_type = path; }; }; Obviously both typedefs are necessary, and

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

EricWF updated this revision to Diff 93991. EricWF retitled this revision from "[libcxx] Alternative fix for compressed pair" to "[libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.". EricWF edited the summary of this revision. EricWF added a

[PATCH] D27564: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times

EricWF abandoned this revision. EricWF added a comment. Abandoning in favor of https://reviews.llvm.org/D27565 https://reviews.llvm.org/D27564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 94008. https://reviews.llvm.org/D31408 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst === ---

[libcxxabi] r299414 - Uses quote to include cxxabi.h to make sure the local one is included

Author: mehdi_amini Date: Tue Apr 4 00:38:38 2017 New Revision: 299414 URL: http://llvm.org/viewvc/llvm-project?rev=299414=rev Log: Uses quote to include cxxabi.h to make sure the local one is included Modified: libcxxabi/trunk/src/cxa_exception.hpp

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) Has Microsoft already implemented this? If not, do we want to wait

[PATCH] D31633: test for thinlto handling of internal linkage

inglorion added a comment. This is the test for https://reviews.llvm.org/D31632. https://reviews.llvm.org/D31633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31513: [Sema] Add __is_aggregate type-trait

EricWF updated this revision to Diff 93987. EricWF retitled this revision from "[Sema] Add __is_aggregate type-trait and implement LWG 2015" to "[Sema] Add __is_aggregate type-trait". EricWF edited the summary of this revision. EricWF added a comment. - Remove LWG 2015 implementation.

[PATCH] D31637: [Sema] Implement LWG 2015 for the builtin type-traits.

aaron.ballman added a comment. > If I'm not mistaken the correct thing to do is to retroactively apply it to > C++11 even though it first appeared in the C++14 standard. That is how we typically handle DRs. Do you also need to change the implementation of `EvaluateBinaryTypeTrait()` for the

[PATCH] D31276: Add #pragma clang fp

anemet added a comment. In https://reviews.llvm.org/D31276#717390, @aaron.ballman wrote: > This continues to look good to me with the new name. Thank you, Aaron! https://reviews.llvm.org/D31276 ___ cfe-commits mailing list

[PATCH] D31646: [coroutines] Build GRO declaration and return GRO statement

GorNishanov created this revision. 1. build declaration of the gro local variable that keeps the result of get_return_object. 2. build return statement returning the gro variable 3. emit them during CodeGen 4. sema and CodeGen tests updated https://reviews.llvm.org/D31646 Files:

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi updated this revision to Diff 94007. ahmedasadi added a comment. Updated diff to address Eric's comment - it's best not to issue a warning if the shadowing declaration is part of a class (this is what GCC currently does). I will need someone to commit this new patch for me.

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc updated this revision to Diff 93974. ddcc added a comment. Fix support for 128-bit APInt creation, drop pkg-config from CMake module https://reviews.llvm.org/D28952 Files: CMakeLists.txt cmake/modules/FindZ3.cmake include/clang/Config/config.h.cmake

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:348 +static const char *getInitializer(QualType type, bool LiteralInitializers) { + const char *DefaultInitializer = "{}"; `type` doesn't follow our usual

[PATCH] D31633: test for thinlto handling of internal linkage

inglorion created this revision. Herald added a subscriber: Prazek. https://reviews.llvm.org/D31633 Files: test/CodeGenCXX/thinlto-promote-internals.cpp Index: test/CodeGenCXX/thinlto-promote-internals.cpp === --- /dev/null +++

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

Thanks, that makes sense, I forgot to check for noexcept function types in template arguments. (Though I think GCC's diagnostic is sort of wrong or at least missing the point in this case, which is that 't' will have a different type in C++17.) On 3 Apr 2017 1:33 pm, "Eric Fiselier"

[PATCH] D31637: [Sema] Implement LWG 2015 for the builtin type-traits.

EricWF updated this revision to Diff 93985. EricWF edited the summary of this revision. https://reviews.llvm.org/D31637 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits-incomplete.cpp Index: test/SemaCXX/type-traits-incomplete.cpp

[PATCH] D31637: [Sema] Implement LWG 2015 for the builtin type-traits.

EricWF planned changes to this revision. EricWF added a comment. Woops. This may actually be entirely unneeded. Comment at: lib/Sema/SemaExprCXX.cpp:4083 case UTT_HasTrivialDestructor: case UTT_HasVirtualDestructor: +// C++14 [meta.unary.prop]

r299410 - Modules/builtins.m requires shell.

Author: gkistanova Date: Mon Apr 3 21:50:40 2017 New Revision: 299410 URL: http://llvm.org/viewvc/llvm-project?rev=299410=rev Log: Modules/builtins.m requires shell. Modified: cfe/trunk/test/Modules/builtins.m Modified: cfe/trunk/test/Modules/builtins.m URL:

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

EricWF created this revision. Herald added a subscriber: mgorny. Recent commits broke the check-cxx-abilist by changing the default OS X to use `-rexport_library` instead of `-reexport_symbol_list`. Apparently `-reexport_library` doesn't export the symbols into `libc++.dylib`s symbol table,

[PATCH] D31276: Add #pragma clang fp

aaron.ballman added a comment. This continues to look good to me with the new name. https://reviews.llvm.org/D31276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some minor nits about newlines, LGTM! Comment at: docs/clang-tidy/checks/misc-forwarding-reference-overload.rst:51-52 + + + You can

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) EricWF wrote: > aaron.ballman wrote: > > Has Microsoft already

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

STL_MSFT added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) aaron.ballman wrote: > EricWF wrote: > > aaron.ballman wrote: > > > Has

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

dcoughlin added a comment. Dominic: I don't have a bot set up yet, but let's get this committed. Thanks for all your hard work on this! https://reviews.llvm.org/D28952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) STL_MSFT wrote: > aaron.ballman wrote: > > EricWF wrote: > > >

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:941 + ContinuationIndentWidth: 2 + ColumnLimit: 15 + djasper wrote: > You could force line wraps with tailing //-comments instead. much better. thanks

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

EricWF added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4089 +// See LWG 2015 +QualType ElTy = S.Context.getBaseElementType(ArgTy); if (ElTy->isVoidType()) aaron.ballman wrote: > If I understand properly, this change is required by LWG

[libcxx] r299407 - Work around recent -Wshadow changes in Clang

Author: ericwf Date: Mon Apr 3 20:05:59 2017 New Revision: 299407 URL: http://llvm.org/viewvc/llvm-project?rev=299407=rev Log: Work around recent -Wshadow changes in Clang Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/include/regex Modified:

Re: r299410 - Modules/builtins.m requires shell.

What was your issue? Seems nothing to do "shell". On Tue, Apr 4, 2017 at 12:03 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gkistanova > Date: Mon Apr 3 21:50:40 2017 > New Revision: 299410 > > URL: http://llvm.org/viewvc/llvm-project?rev=299410=rev > Log:

Re: r299410 - Modules/builtins.m requires shell.

Just wanted temporarily disable this test on Windows bots while investigating the clang assert which happens once in a while By the way, do you see something like this on your bots? Assertion failed: (Imported == nullptr || Imported == SuggestedModule.getModule()) && "the imported module is

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

EricWF updated this revision to Diff 94000. EricWF added a comment. - Remove silly changes to `libc++abi2.exp` https://reviews.llvm.org/D31644 Files: lib/CMakeLists.txt lib/libc++abi-new-delete.exp lib/libc++abi2.exp Index: lib/libc++abi2.exp

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

Here is a reduced version. void glibc_function() throw() {} template struct Test { Test() {} // expected-error {{mangled name for 'Test::Test()' will change in C++17}} ~Test() {} // expected-error {{mangled name for 'Test::~Test()' will change in C++17}} }; Test t;

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

EricWF added a subscriber: STL_MSFT. EricWF added inline comments. Comment at: docs/LanguageExtensions.rst:996 * ``__is_abstract`` (GNU, Microsoft) +* ``__is_aggregate`` (GNU, Microsoft) * ``__is_base_of`` (GNU, Microsoft) aaron.ballman wrote: > Has Microsoft

[PATCH] D27565: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times, and add constexpr.

EricWF added a reviewer: K-ballo. EricWF added a subscriber: K-ballo. EricWF added a comment. @K-ballo if you have time would you do me the favor and looking this over. In particular that I didn't accidentally change the layout of `__compressed_pair`. I don't think I did but I need a second set

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl marked 31 inline comments as done. yaxunl added inline comments. Comment at: include/clang/AST/ASTContext.h:2328 +return AddrSpaceMapMangling || + AS >= LangAS::target_first; } Anastasia wrote: > So we couldn't use the LangAS::Count

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye added inline comments. Comment at: include/clang/AST/Type.h:339-340 +auto Addr = getAddressSpace(); +if (Addr == 0) + return 0; +return Addr - LangAS::target_first; Anastasia wrote: > yaxunl wrote: > > t-tye wrote: > > > Since you mention

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

m_zuckerman updated this revision to Diff 93915. https://reviews.llvm.org/D31394 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512dq-builtins.c test/CodeGen/avx512vlbw-builtins.c test/CodeGen/avx512vldq-builtins.c Index:

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

EricWF updated this revision to Diff 93917. EricWF marked 6 inline comments as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D31487 Files: include/clang/AST/StmtCXX.h lib/AST/StmtCXX.cpp lib/Sema/CoroutineStmtBuilder.h lib/Sema/SemaCoroutine.cpp

r299382 - Revert r299321 '[X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards enabled.' to see if recovers a

Author: ctopper Date: Mon Apr 3 14:43:47 2017 New Revision: 299382 URL: http://llvm.org/viewvc/llvm-project?rev=299382=rev Log: Revert r299321 '[X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards

[PATCH] D31022: Implement P0298R3: `std::byte`

jyknight added a comment. I believe this needs compiler support, too, in order to treat namespace std { enum class byte : unsigned char {}; } as directly having tbaa type "omnipotent char" instead of a subtype. That is, given: void foo(char* x, int *y) { x[1] = char(y[0] & 0xff);

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea updated this revision to Diff 93859. gtbercea added a comment. Herald added a subscriber: rengolin. Update test. Repository: rL LLVM https://reviews.llvm.org/D29905 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

olista01 added a comment. That all sounds sensible from an assembler perspective, especially the ability to gradually move diagnostics into categories rather than having one big change that touches every assembler diag. However, I've not done much work in clang, so it would be good to get

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

yamaguchi updated this revision to Diff 93864. yamaguchi added a comment. Made unified diff for the testcase and SemaInit.cpp. https://reviews.llvm.org/D31591 Files: SemaInit.cpp sema-segvcheck.c Index: sema-segvcheck.c ===

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

sanwou01 added a comment. Hi Oli, Thanks for taking a look! You're right, -w and -Werror could be implemented by passing them as MCTargetOptions flags. This patch is indeed intended to enable -W options to promote or silence (categories of) warnings. To enable that, the first step is to be

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

yamaguchi updated this revision to Diff 93860. yamaguchi added a comment. Moved comment inside if (ExistingInit). https://reviews.llvm.org/D31591 Files: SemaInit.cpp Index: SemaInit.cpp === --- SemaInit.cpp +++ SemaInit.cpp @@

[PATCH] D31594: [OpenCL] Enables passing sampler initializer to function argument

yaxunl added a comment. I am not sure if this is going to work. At least you need to add a codegen test for this new usage. https://reviews.llvm.org/D31594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r299340 - Fixes for modernize-use-using check:

Author: krystynka Date: Sun Apr 2 14:12:20 2017 New Revision: 299340 URL: http://llvm.org/viewvc/llvm-project?rev=299340=rev Log: Fixes for modernize-use-using check: - removed unnessacary namespaces - added option to print warning in macros - no fix for typedef with array - removed "void" word

Quantum computing and C

hi. I heard Quantum Computers are coming. Are we able to compile and run programs written in C or C++ on them? ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

sdardis added a comment. Do you need me to commit this for you? Repository: rL LLVM https://reviews.llvm.org/D30465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

rengolin added a comment. Hi Graham, It looks much simpler now, thanks! I'm ok with the change, but I'd like @ABataev to confirm that the semantics is the expected one for all cases and approve. cheers, --renato Comment at: lib/Parse/ParseOpenMP.cpp:174 + case

r299355 - [ASTImporter] Fix for importing unnamed structs

Author: xazax Date: Mon Apr 3 06:57:11 2017 New Revision: 299355 URL: http://llvm.org/viewvc/llvm-project?rev=299355=rev Log: [ASTImporter] Fix for importing unnamed structs Patch by Peter Szecsi! Differential Revision: https://reviews.llvm.org/D30876 Modified:

[PATCH] D31597: [ObjC++] Conversions from specialized to non-specialized objective-c object type should be preferred over conversions to other object pointers

arphaman created this revision. Right now Clang will select incorrect overload when the Objective-C interface type is specialized, e.g.: void overload(Base *b); void overload(Derived *d); void test(Base b) { overload(b); // This will select (Derived *) overload } This patch ensures

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; rengolin wrote: > I'd like @ABataev to confirm this is the right semantics. Yes, would be good. I

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

Anastasia added inline comments. Comment at: include/clang/AST/ASTContext.h:2328 +return AddrSpaceMapMangling || + AS >= LangAS::target_first; } So we couldn't use the LangAS::Count instead? I have the same comment in other places that use

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

arphaman added a comment. Thanks! I'll commit it for you right now. https://reviews.llvm.org/D31235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl updated this revision to Diff 93870. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Tony's comments. https://reviews.llvm.org/D31404 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h

[PATCH] D26953: clang-format: handle formatting on constexpr if

outcoldman added a comment. In https://reviews.llvm.org/D26953#716504, @gnzlbg wrote: > any progress on this? It is getting tracked in mailing list http://lists.llvm.org/pipermail/cfe-dev/2017-April/053397.html https://reviews.llvm.org/D26953

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

m_zuckerman added a comment. Ping https://reviews.llvm.org/D31394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31594: [OpenCL] Enables passing sampler initializer to function argument

Anastasia added inline comments. Comment at: test/SemaOpenCL/sampler_t.cl:68 foo(argsmp); - foo(5); // expected-error{{sampler_t variable required - got 'int'}} + foo(CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR); sampler_t sa[] = {argsmp,

r299363 - Enhance -Wshadow to warn when shadowing typedefs or type aliases

Author: arphaman Date: Mon Apr 3 11:43:21 2017 New Revision: 299363 URL: http://llvm.org/viewvc/llvm-project?rev=299363=rev Log: Enhance -Wshadow to warn when shadowing typedefs or type aliases Enhance -Wshadow to emit a warning when typedefs or type aliases are shadowed. Fixes bug

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL299363: Enhance -Wshadow to warn when shadowing typedefs or type aliases (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31235?vs=93583=93878#toc Repository: rL LLVM

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2055 + << AllocType.getUnqualifiedType() + << AllocType.getQualifiers().getAddressSpacePrintValue(); else if (getLangOpts().ObjCAutoRefCount) { Would suggest renaming

r299364 - [TargetInfo] Use llvm::alignOf() instead of rewriting it. NFCI.

Author: davide Date: Mon Apr 3 11:51:39 2017 New Revision: 299364 URL: http://llvm.org/viewvc/llvm-project?rev=299364=rev Log: [TargetInfo] Use llvm::alignOf() instead of rewriting it. NFCI. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

craig.topper added a comment. Y Comment at: lib/CodeGen/CGBuiltin.cpp:7176 + return CGF.Builder.CreateSExt( + Mask, llvm::VectorType::get(IT, NumberOfElements), "vpmovm2"); +} Why can't we just use DstTy here to create the SExt?

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

ahatanak added inline comments. Comment at: lib/Basic/TargetInfo.cpp:506 case '!': // Disparage severely. case '*': // Ignore for choosing register preferences. +case 'i': // Ignore i as output constraint (match from the other chars) If we are

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet updated this revision to Diff 93882. anemet added a comment. Address John's comment. https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ffp-contract-fast-option.cpp Index: test/CodeGen/ffp-contract-fast-option.cpp

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

GorNishanov updated this revision to Diff 93889. GorNishanov added a comment. Added a CHECK that for a final suspend we correctly set "IsFinalSuspend" argument of @llvm.coro.suspend https://reviews.llvm.org/D31608 Files: lib/CodeGen/CGCoroutine.cpp test/CodeGenCoroutines/coro-await.cpp

[PATCH] D31440: PR32382: Adapt to LLVM changes in DIExpression.

aprantl updated this revision to Diff 93897. aprantl added a comment. Add accidentally removed check for the debug info level back in. https://reviews.llvm.org/D31440 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h

[PATCH] D31422: Add builder for libunwind docs

jroelofs added a comment. The 0th build seems to have been successful: http://lab.llvm.org:8011/builders/libunwind-sphinx-docs/builds/0 That being said, I did have to kick it off manually. I'll make a no-op change later this afternoon, and see if the builder picks it up.

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

echuraev updated this revision to Diff 93837. echuraev marked an inline comment as done. https://reviews.llvm.org/D30643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/Parser/opencl-atomics-cl20.cl test/SemaOpenCL/atomic-init.cl

[PATCH] D31594: [OpenCL] Enables passing sampler initializer to function argument

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D31594 Files: lib/Sema/SemaInit.cpp test/SemaOpenCL/sampler_t.cl Index: test/SemaOpenCL/sampler_t.cl === ---

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

gtbercea updated this revision to Diff 93883. gtbercea added a comment. Update test. Repository: rL LLVM https://reviews.llvm.org/D29659 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D31440: PR32382: Adapt to LLVM changes in DIExpression.

aprantl updated this revision to Diff 93900. https://reviews.llvm.org/D31440 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenObjC/debug-info-block-captured-self.m test/CodeGenObjC/debug-info-blocks.m Index:

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

GorNishanov created this revision. https://reviews.llvm.org/D31608 Files: lib/CodeGen/CGCoroutine.cpp test/CodeGenCoroutines/coro-await.cpp test/CodeGenCoroutines/coro-cleanup.cpp Index: test/CodeGenCoroutines/coro-cleanup.cpp

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

t-tye added inline comments. Comment at: include/clang/AST/Type.h:339-340 +auto Addr = getAddressSpace(); +if (Addr == 0) + return 0; +return Addr - LangAS::target_first; Since you mention this is only used for

[PATCH] D31029: [analyzer] Fix logical not for pointers with different bit width

danielmarjamaki added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D31029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D30295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25596: alpha.core.Conversion - Fix false positive for 'U32 += S16; ' expression, that is not unsafe

danielmarjamaki added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D25596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

danielmarjamaki added inline comments. Comment at: tools/xtu-analysis/xtu-analyze.py:29 + +threading_factor = int(multiprocessing.cpu_count() * 1.5) +analyser_output_formats = ['plist-multi-file', 'plist', 'plist-html', gerazo wrote: > danielmarjamaki wrote: > >

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet added a comment. In https://reviews.llvm.org/D31168#716153, @rjmccall wrote: > I may have missed earlier steps in this patch series. Why is this being done > statefully and contextually in the IRBuilder instead of just applying the > flag from the BinaryOperator to the instruction when

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 93901. gtbercea added a comment. Update test. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D31440: PR32382: Adapt to LLVM changes in DIExpression.

dblaikie added a comment. In https://reviews.llvm.org/D31440#713396, @aprantl wrote: > In https://reviews.llvm.org/D31440#713308, @dblaikie wrote: > > > I'm a bit confused - the alloca was only emitted at -O0, by the looks of > > it. Presumably it's pessimizing in some way at higher

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

EricWF updated this revision to Diff 93939. EricWF added a comment. - Merge with master - Fix `coro-alloc.cpp` test so that it declares new. - Add FIXME comment regarding assertion about an MaybeODRUsedExpr that hasn't been correctly handled. (the VarDecl for `std::nothrow` is broken).

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

m_zuckerman updated this revision to Diff 93941. https://reviews.llvm.org/D31394 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512dq-builtins.c test/CodeGen/avx512vlbw-builtins.c test/CodeGen/avx512vldq-builtins.c Index:

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

Author: ericwf Date: Mon Apr 3 15:53:15 2017 New Revision: 299385 URL: http://llvm.org/viewvc/llvm-project?rev=299385=rev Log: suppress GCC warning about noexcept functions changing mangling Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/utils/libcxx/test/config.py Modified:

[PATCH] D31627: [coroutines] Skip over passthrough operator co_await

GorNishanov created this revision. https://reviews.llvm.org/D31627 Files: lib/CodeGen/CGCoroutine.cpp test/CodeGenCoroutines/coro-await.cpp Index: test/CodeGenCoroutines/coro-await.cpp === ---

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

EricWF planned changes to this revision. EricWF added a comment. This patch currently triggers an assertion in `SemaDecl.cpp:12290` `assert(MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking");` I'll have to come up with a fix for that before this is committed.

[PATCH] D31394: [X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into generic intrinsics.

m_zuckerman added a comment. Thanks :) https://reviews.llvm.org/D31394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r299386 - Revert r299355 "[ASTImporter] Fix for importing unnamed structs"

Author: xazax Date: Mon Apr 3 16:06:45 2017 New Revision: 299386 URL: http://llvm.org/viewvc/llvm-project?rev=299386=rev Log: Revert r299355 "[ASTImporter] Fix for importing unnamed structs" It breaks windows bots. Modified: cfe/trunk/lib/AST/ASTImporter.cpp

  1   2   >