chrib updated this revision to Diff 94329.
chrib added a comment.
- NeedsUnwindTable check thumb arch
https://reviews.llvm.org/D31140
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
Index: lib/CodeGen/CodeGenModule.h
===
echuraev added a comment.
In https://reviews.llvm.org/D27334#700521, @Anastasia wrote:
> I don't actually. But remembering the follow up discussion:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161205/178846.html
> and since we have to deviate from the standard C/C++ implementati
echuraev created this revision.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D31745
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/clang-builtin-version.cl
test/SemaOpenCL/to_addr_builtin.cl
Index: test/SemaOpenCL/to_addr_builtin.cl
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
Thank you for tracking down this bug and fixing it!
Comment at: lib/Basic/SourceManager.cpp:1153
+ if (FilePos + 1 == LineEnd && FilePos > LineStart) {
bradfier updated this revision to Diff 94334.
bradfier added a reviewer: klimek.
bradfier added a comment.
Add more diff context, add klimek as reviewer.
Repository:
rL LLVM
https://reviews.llvm.org/D31652
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/TokenKinds.def
li
teemperor updated this revision to Diff 94337.
teemperor added a comment.
- Renamed variable from 'S' to 'Child' to make the buildbots happy (and because
it's more expressive)
- Fixed the name of the unit test.
https://reviews.llvm.org/D23418
Files:
include/clang/Analysis/CloneDetection.h
teemperor added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:395
+
+ for (const Stmt *Child : S->children()) {
+if (Child == nullptr) {
I couldn't reproduce, but from what I assume form the warning and the crash
that we confused the compiler
ioeric added a comment.
Still LGTM. Please run `ninja check-clang` and fix the warning. I'll land this
patch for you afterwards.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:222
+}
+default:
+ llvm_unreachable("Element.Type not recognized");
`
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299638: [clang-tidy] Check for forwarding reference overload
in constructors. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D30547?vs=94028&id=94339#toc
Repository:
rL LLVM
Author: xazax
Date: Thu Apr 6 04:56:42 2017
New Revision: 299638
URL: http://llvm.org/viewvc/llvm-project?rev=299638&view=rev
Log:
[clang-tidy] Check for forwarding reference overload in constructors.
Patch by András Leitereg!
Differential Revision: https://reviews.llvm.org/D30547
Added:
c
Author: vvassilev
Date: Thu Apr 6 05:05:46 2017
New Revision: 299639
URL: http://llvm.org/viewvc/llvm-project?rev=299639&view=rev
Log:
PR16106: Correct the docs to reflect the actual behavior of the interface.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/I
sdardis marked an inline comment as done.
sdardis added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9736
+ }
+
+ if (TypeSize == Context.getTypeSize(Context.LongLongTy))
ahatanak wrote:
> This isn't particularly urgent, but can we use ASTContext
> ::get
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299641: [Sema] Extend GetSignedVectorType to deal with non
ExtVector types (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D31667?vs=94205&id=94344#toc
Repository:
rL LLVM
h
Author: sdardis
Date: Thu Apr 6 05:38:03 2017
New Revision: 299641
URL: http://llvm.org/viewvc/llvm-project?rev=299641&view=rev
Log:
[Sema] Extend GetSignedVectorType to deal with non ExtVector types
This improves some error messages which would otherwise refer to
ext_vector_type types in contex
NoQ added a comment.
$ cat test.c
#include
int main() {
int i = 5;
{
int i = i;
printf("%d\n", i);
}
return 0;
}
$ clang test.c
$ ./a.out
32767
$ clang test.c -Xclang -ast-dump
...
`-FunctionDecl 0x7ff82d8eac78 line:2:5 main 'int ()'
`-Compound
Author: rksimon
Date: Thu Apr 6 05:49:02 2017
New Revision: 299642
URL: http://llvm.org/viewvc/llvm-project?rev=299642&view=rev
Log:
Wdocumentation fix
Modified:
clang-tools-extra/trunk/clang-rename/USRLocFinder.h
Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.h
URL:
http://ll
arphaman added a comment.
Are the `<<<` and `>>>` operators handled correctly?
Repository:
rL LLVM
https://reviews.llvm.org/D31652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: include/clang/Basic/LangOptions.def:95
LANGOPT(ObjC2 , 1, 0, "Objective-C 2")
+LANGOPT(Java , 1, 0, "Java")
BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0,
I don't think we should have a `Ja
Author: sdardis
Date: Thu Apr 6 06:12:14 2017
New Revision: 299643
URL: http://llvm.org/viewvc/llvm-project?rev=299643&view=rev
Log:
[Sema] Retarget test to a specific platform for consistent datasizes
Attempt to satisfy llvm-clang-x86_64-expensive-checks-win by targeting
x86_64-apple-darwin10 f
teemperor added a comment.
I think for range loops work differently:
#include
#include
#include
struct Foo {
int* begin() const { assert(false); }
int* end() const { assert(false); }
void bar() const { std::cout << "Different behavior" << std::endl; }
};
int main() {
std::vector F;
F
bradfier added a comment.
In https://reviews.llvm.org/D31652#719990, @arphaman wrote:
> Are the `<<<` and `>>>` operators handled correctly?
Yes, as a side-effect of CUDA kernel-call syntax which uses `>>>` and `<<<`,
those tokens are recognised as punctuators.
Repository:
rL LLVM
https:/
bradfier added inline comments.
Comment at: include/clang/Basic/LangOptions.def:95
LANGOPT(ObjC2 , 1, 0, "Objective-C 2")
+LANGOPT(Java , 1, 0, "Java")
BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0,
arphaman wrote:
> I don't think we
krasimir added a comment.
Looks great! I'm wondering, can you think of ways to test the `didClose` method
similarly to how it's done for other handlers?
Comment at: clangd/ASTManager.cpp:203
+ // TODO(ibiryukov): at this point DocDatasLock can be unlocked in
asynchronous
+
v.g.vassilev updated this revision to Diff 94350.
v.g.vassilev added a comment.
Found out which is the right place to avoid the linkage computation issues.
https://reviews.llvm.org/D29877
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-unused-filescoped.cpp
Index: test/S
v.g.vassilev updated this revision to Diff 94352.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Improve comment.
https://reviews.llvm.org/D29877
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-unused-filescoped.cpp
Index: test/SemaCXX/warn-
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D31401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mgorny created this revision.
Add the 'z3' subdirectory to the list of possible path suffixes for
libz3 header search. The z3 headers are installed in /usr/include/z3
on Gentoo.
Repository:
rL LLVM
https://reviews.llvm.org/D31756
Files:
cmake/modules/FindZ3.cmake
Index: cmake/modules/Fin
hokein created this revision.
Herald added a subscriber: mgorny.
The "performance-inefficient-vector-operation" check finds vector oprations in
for-loop statements which may cause multiple memory reallocations.
This is the first version, only detects typical for-loop:
std::vector v;
for (int
hokein updated this revision to Diff 94356.
hokein added a comment.
Fix a small nit.
https://reviews.llvm.org/D31757
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/performance/InefficientVectorOperationCheck.h
clang-tid
Author: xazax
Date: Thu Apr 6 07:49:35 2017
New Revision: 299645
URL: http://llvm.org/viewvc/llvm-project?rev=299645&view=rev
Log:
Attempt to fix build bots after r299638.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-forwarding-reference-overload.cpp
Modified:
clang-tools-extra/
Author: arphaman
Date: Thu Apr 6 07:53:43 2017
New Revision: 299646
URL: http://llvm.org/viewvc/llvm-project?rev=299646&view=rev
Log:
Fix lambda to block conversion in C++17 by avoiding copy elision for the
lambda capture used by the created block
The commit r288866 introduced guaranteed copy el
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299646: Fix lambda to block conversion in C++17 by avoiding
copy elision for the (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D31669?vs=94177&id=94358#toc
Repository:
rL
Author: arphaman
Date: Thu Apr 6 08:06:34 2017
New Revision: 299648
URL: http://llvm.org/viewvc/llvm-project?rev=299648&view=rev
Log:
[ObjC++] Conversions from specialized to non-specialized Objective-C generic
object types should be preferred over conversions to other object pointers
This chang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299648: [ObjC++] Conversions from specialized to
non-specialized Objective-C generic (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D31597?vs=93845&id=94360#toc
Repository:
thakis added inline comments.
Comment at: include/clang/Basic/TokenKinds.def:230
+PUNCTUATOR(greatergreatergreaterequal, ">>>=")
+PUNCTUATOR(lesslesslessequal, "<<<=")
+
I think this is the wrong approach to go about this. clang is a C compiler, and
its tokenize
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D31515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: alexfh
Date: Thu Apr 6 08:41:29 2017
New Revision: 299649
URL: http://llvm.org/viewvc/llvm-project?rev=299649&view=rev
Log:
[clang-tidy] Add FormatStyle configuration option.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
clang-tools-extra/trunk/clang-tidy/ClangTidy.h
m.ostapenko created this revision.
Herald added subscribers: rengolin, aemerson.
This is a compiler part of https://reviews.llvm.org/D29586. Enable LSan on arm
Linux.
Repository:
rL LLVM
https://reviews.llvm.org/D31760
Files:
lib/Driver/ToolChains/Linux.cpp
test/Driver/fsanitize.c
Ind
Author: arphaman
Date: Thu Apr 6 09:03:25 2017
New Revision: 299650
URL: http://llvm.org/viewvc/llvm-project?rev=299650&view=rev
Log:
Avoid the -Wdocumentation-unknown-command warning in Clang's C API docs
rdar://20441985
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/incl
yaxunl added a comment.
What happens if user declared a function without parameter as `void f();`
instead of `void f(void)` then try to use it? Will this be treated as implicit
declaration and results in an error instead of warning?
https://reviews.llvm.org/D31745
__
Author: alexfh
Date: Thu Apr 6 09:27:00 2017
New Revision: 299651
URL: http://llvm.org/viewvc/llvm-project?rev=299651&view=rev
Log:
[clang-tidy] Update docs and help message
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-extra/trunk/docs/clang-tidy/index.
Author: marshall
Date: Thu Apr 6 09:32:42 2017
New Revision: 299652
URL: http://llvm.org/viewvc/llvm-project?rev=299652&view=rev
Log:
Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and
proposing this as https://reviews.llvm.org/D16541
Modified:
libcxx/trunk/test/std/re/
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
committed as revision 299652
https://reviews.llvm.org/D16541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299653: [analyzer] Reland r299544 "Add a modular constraint
system to the CloneDetector" (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D23418?vs=94337&id=94370#toc
Reposito
Author: dergachev
Date: Thu Apr 6 09:34:07 2017
New Revision: 299653
URL: http://llvm.org/viewvc/llvm-project?rev=299653&view=rev
Log:
[analyzer] Reland r299544 "Add a modular constraint system to the CloneDetector"
Hopefully fix crashes by unshadowing the variable.
Original commit message:
A
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:358-360
+ /// Do the check specified in \a Check to all component lists at a given
level
+ /// and return true if any issue is found.
+ bool checkMappableExprComponentListsForDeclAtLevel(
Coul
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430
+bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC,
+ const ArgList &Args, const JobAction &JA,
+ bool GompNeedsRT)
Hahnfeld updated this revision to Diff 94372.
Hahnfeld marked 2 inline comments as done.
Hahnfeld retitled this revision from "[Driver] Unify linking of OpenMP runtime"
to "[Driver] Unify linking of OpenMP runtime. NFCI.".
Hahnfeld edited the summary of this revision.
https://reviews.llvm.org/D30
tstellar added a comment.
Why is this necessary?
Repository:
rL LLVM
https://reviews.llvm.org/D29651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
Ping! Any further questions? Thanks.
https://reviews.llvm.org/D31404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
This bot is broken:
http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/
https://reviews.llvm.org/D16541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
salari01 created this revision.
When using the C preprocessor with assembly files, either with a capital `S`
file extension, or with `-xassembler-with-cpp`, the Unicode escape sequence
`\u` is ignored. The `\u` pattern can be used for expanding a macro argument
that starts with `u`.
https://r
ABataev added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:122-123
createOpenCLRuntime();
- if (LangOpts.OpenMP)
+ if (LangOpts.OpenMP || LangOpts.OpenMPSimd)
createOpenMPRuntime();
if (LangOpts.CUDA)
I don't think you need to create
RKSimon created this revision.
MOVNTDQA non-temporal aligned vector loads can be correctly represented using
generic builtin loads, allowing us to remove the existing x86 intrinsics.
The LLVM companion patch will be published shortly.
Repository:
rL LLVM
https://reviews.llvm.org/D31766
Fil
Author: mehdi_amini
Date: Thu Apr 6 10:56:55 2017
New Revision: 299656
URL: http://llvm.org/viewvc/llvm-project?rev=299656&view=rev
Log:
Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and
proposing this as https://reviews.llvm.org/D16541";
This reverts commit r29965
Author: xazax
Date: Thu Apr 6 10:58:57 2017
New Revision: 299657
URL: http://llvm.org/viewvc/llvm-project?rev=299657&view=rev
Log:
[clang-tidy] Temporarily disable a test-case that does not work on windows.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-forwarding-reference-overload
Hi,
I reverted in r299656. MacOS bot is broken both on 64 and 32 bits:
http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/
http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/
It shouldn’t be too hard to fix though, it is full of the same error:
/Users/buildslave/jenkins/share
mclow.lists created this revision.
As proposed in http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190
I'm leaving `unary_function` and `binary_function` in place until I can figure
out a non-ABI breaking way to remove them.
To get them back in C++17, you can `-D _LIBCPP_ENABLE_CXX17_R
yaxunl created this revision.
Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl.
Change constant address space from 4 to 2 for the new address space mapping in
Clang.
https://reviews.llvm.org/D31771
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/address-space-constant-ini
ddcc accepted this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D31756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
Other than one comment:
LGTM
Comment at: lib/Basic/Targets.cpp:2083
Local = 3;
-Constant = 4;
+Constant = 2;
Private = 5;
---
t-tye added a comment.
LGTM
Comment at: lib/Basic/Targets.cpp:2083
Local = 3;
-Constant = 4;
+Constant = 2;
Private = 5;
t-tye wrote:
> Since Constant is now the same regardless of the GIZ setting, should it be
> moved
Anastasia added inline comments.
Comment at: include/clang/AST/ASTContext.h:2328
+return AddrSpaceMapMangling ||
+ AS >= LangAS::target_first;
}
yaxunl wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > Anastasia wrote:
> > > > yaxunl wrote:
> >
Eugene.Zelenko added a comment.
Isn't such analysis is path-sensitive and should be implemented in Static
Analyzer?
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at:
docs/clang-tidy/checks/performance-inefficient-vector-operation.rst:6
+
kkwli0 added inline comments.
Comment at: docs/ClangCommandLineReference.rst:1454
+.. option:: -fopenmp-simd, -fno-openmp-simd
+
I am not sure if it is target architecture specific or not. If it is, should
we be under the target flag instead?
https://review
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8254
"%0 cannot be used as the type of a kernel parameter">;
+def err_opencl_implicit_function_decl : Error<
+ "implicit declaration of function %0 is invalid in OpenCL">;
Anastasia added a comment.
In https://reviews.llvm.org/D26794#598784, @Anastasia wrote:
> I have created a bug to Khronos regarding this, but unfortunately I don't see
> it being progressed yet.
> https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659
>
> The problem here is that I am not sure
Author: krasin
Date: Thu Apr 6 12:35:35 2017
New Revision: 299666
URL: http://llvm.org/viewvc/llvm-project?rev=299666&view=rev
Log:
Fix unused typedef. Follow up to r299575.
Modified:
libunwind/trunk/src/AddressSpace.hpp
Modified: libunwind/trunk/src/AddressSpace.hpp
URL:
http://llvm.org/
Author: krasin
Date: Thu Apr 6 12:42:05 2017
New Revision: 299671
URL: http://llvm.org/viewvc/llvm-project?rev=299671&view=rev
Log:
Fix unused lambda capture. Follow up to r299653.
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp
URL:
ABataev added inline comments.
Comment at: test/Driver/openmp-offload.c:622
+/// Check that the lib folder pointed to by the LIBRARY_PATH is correctly
passsed to the loader script.
+// RUN: LIBRARY_PATH=/a/b/c/lib %clang -### -fopenmp=libomp
-fopenmp-targets=powerpc64le-ibm-l
yaxunl marked 11 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/AST/ASTContext.h:2328
+return AddrSpaceMapMangling ||
+ AS >= LangAS::target_first;
}
Anastasia wrote:
> yaxunl wrote:
> > yaxunl wrote:
> > > Anas
zturner added reviewers: beanz, rnk, chandlerc.
zturner added a comment.
Not really sure who to add as a reviewer here, so + a few random people.
BTW, kimgr@, is there any particular reason you haven't tried to upstream the
tool? Maybe even as not a standalone tool but as a set of checks in
`c
yaxunl updated this revision to Diff 94399.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments.
https://reviews.llvm.org/D31404
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/AddressSpaces.h
lib/AST/ASTCon
bruno created this revision.
Allow ODR for ObjC/C in the sense that we won't keep more that one definition
around (merge them). However, ensure the decl pass the structural compatibility
check in C11 6.2.7/1, for that, reuse the structural equivalence checks used by
the ASTImporter.
Few other
chh updated this revision to Diff 94402.
chh marked an inline comment as done.
https://reviews.llvm.org/D31713
Files:
lib/Basic/SourceManager.cpp
Index: lib/Basic/SourceManager.cpp
===
--- lib/Basic/SourceManager.cpp
+++ lib/Basi
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D31043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: rampitec
Date: Thu Apr 6 13:15:44 2017
New Revision: 299678
URL: http://llvm.org/viewvc/llvm-project?rev=299678&view=rev
Log:
[AMDGPU] Translate reqd_work_group_size into amdgpu_flat_work_group_size
These two attributes specify the same info in a different way.
AMGPU BE only checks the l
bruno created this revision.
Removing this restriction will make it handy to explore local submodule
visibility without c++ being turned on. We're currently testing it out with
C/ObjC.
https://reviews.llvm.org/D31781
Files:
lib/Frontend/CompilerInvocation.cpp
Index: lib/Frontend/CompilerI
Author: marshall
Date: Thu Apr 6 13:34:36 2017
New Revision: 299680
URL: http://llvm.org/viewvc/llvm-project?rev=299680&view=rev
Log:
Recommit awk tests with warnings removed. Initial commit r299652, reverted
r299656.
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp
Modi
Author: chh
Date: Thu Apr 6 13:36:50 2017
New Revision: 299681
URL: http://llvm.org/viewvc/llvm-project?rev=299681&view=rev
Log:
[Basic] getColumnNumber returns location of CR+LF on Windows
When fixing a Clang-Tidy bug in D31406,
reuse of FileID enabled the missing highlightRange function.
Asser
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299681: [Basic] getColumnNumber returns location of CR+LF on
Windows (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D31713?vs=94402&id=94410#toc
Repository:
rL LLVM
https://rev
Author: marshall
Date: Thu Apr 6 13:54:37 2017
New Revision: 299686
URL: http://llvm.org/viewvc/llvm-project?rev=299686&view=rev
Log:
Some of Eric's buildbots don't like this test. Disable it while I figure out
why.
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp
Modifi
Author: yaxunl
Date: Thu Apr 6 14:18:36 2017
New Revision: 299691
URL: http://llvm.org/viewvc/llvm-project?rev=299691&view=rev
Log:
[AMDGPU] Temporarily change constant address space from 4 to 2 for the new
address space mapping
Change constant address space from 4 to 2 for the new address spac
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299691: [AMDGPU] Temporarily change constant address space
from 4 to 2 for the new… (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D31771?vs=94386&id=94418#toc
Repository:
rL
kimgr added a comment.
> BTW, kimgr@, is there any particular reason you haven't tried to upstream the
> tool?
> Maybe even as not a standalone tool but as a set of checks in clang-tidy.
Lack of time, mostly. IWYU was written before there was libtooling, and follows
Google style, so we've felt
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6818-6819
+ISAData);
+}
+if (CGM.getTriple().getArch() == llvm::Triple::aarch64) {
+ ISADataTy ISAData[] = {
else if
Com
eugenis added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:867
getTriple().getArch() == llvm::Triple::aarch64_be;
+ const bool IsArmArch = getTriple().getArch() == llvm::Triple::arm;
SanitizerMask Res = ToolChain::getSupportedSanitize
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299700: [clang-tidy] Reuse FileID in getLocation (authored
by chh).
Repository:
rL LLVM
https://reviews.llvm.org/D31406
Files:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
Index: clang-tools-e
Author: chh
Date: Thu Apr 6 15:19:26 2017
New Revision: 299700
URL: http://llvm.org/viewvc/llvm-project?rev=299700&view=rev
Log:
[clang-tidy] Reuse FileID in getLocation
One FileID per warning will increase and overflow NextLocalOffset
when input file is large with many warnings.
Reusing FileID
hans updated this revision to Diff 94433.
hans added a comment.
Add comment.
https://reviews.llvm.org/D31736
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
=
hans added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:570
+llvm::AtomicOrdering::SequentiallyConsistent);
+llvm::Value *Shifted = Builder.CreateLShr(RMWI, Bit);
+llvm::Value *Truncated =
rnk wrote:
> Can you comment that this shifts th
aprantl added a comment.
Thanks!
Added a couple of superficial coding style comments.
I think there should also be a test for C99 and one for C11 (and potentially
ObjC2).
Comment at: include/clang/AST/ASTStructuralEquivalence.h:52
+ /// \brief Whether warn or error on tag
sdardis updated this revision to Diff 94434.
sdardis marked 7 inline comments as done.
sdardis added a comment.
Addressed review comments.
I've changed InvalidVectorOperands() to not use InvalidOperands() after
updating some tests. InvalidOperands() was receiving expressions with implicit
casts
Author: phosek
Date: Thu Apr 6 16:06:33 2017
New Revision: 299711
URL: http://llvm.org/viewvc/llvm-project?rev=299711&view=rev
Log:
[CMake][libcxx] Use check_c_compiler_flag to check for nodefaultlibs
We're using -nodefaultlibs to avoid the dependency on C++ library
when using check_cxx_compiler
bradfier updated this revision to Diff 94438.
bradfier edited the summary of this revision.
bradfier added a comment.
Switch to a more appropriate (and much simpler) method of identifying these
Java-specific operators.
Also removed any references to fictitious "logical left shifts", I think I ma
bradfier added a comment.
Thanks for that @thakis, that's a much better solution than the first attempt!
Repository:
rL LLVM
https://reviews.llvm.org/D31652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/CGBuiltin.cpp:570
+llvm::AtomicOrdering::SequentiallyConsistent);
+llvm::Value *Shifted = Builder.CreateLShr(RMWI, Bit);
+llvm::Value *
ahatanak added inline comments.
Comment at: lib/Sema/SemaExprObjC.cpp:3358
var &&
- var->getStorageClass() == SC_Extern &&
+ !var->isThisDeclarationADefinition() &&
var->getType().isConstQualified()) {
rjmccall wrote:
> Hmm
ahatanak updated this revision to Diff 94460.
ahatanak marked an inline comment as done.
https://reviews.llvm.org/D31673
Files:
lib/Sema/SemaExprObjC.cpp
test/SemaObjCXX/arc-bridged-cast.mm
Index: test/SemaObjCXX/arc-bridged-cast.mm
==
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D31702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 114 matches
Mail list logo