[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

timshen added inline comments. Comment at: clang/include/clang/Driver/Options.td:971-973 +def fexperimental_new_pass_manager_EQ : Joined<["-"], "fexperimental-new-pass-manager=">, + Group, Flags<[CC1Option]>, + HelpText<"Enables an experimental new pass manager in LLVM.">,

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

yawanng updated this revision to Diff 104574. yawanng added a comment. Herald added subscribers: mgorny, srhines. rename the check. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp

r306628 - Track the set of module maps read while building a .pcm file and reload those when preprocessing from that .pcm file.

Author: rsmith Date: Wed Jun 28 19:19:42 2017 New Revision: 306628 URL: http://llvm.org/viewvc/llvm-project?rev=306628=rev Log: Track the set of module maps read while building a .pcm file and reload those when preprocessing from that .pcm file. Added:

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

yaxunl created this revision. Herald added a subscriber: Anastasia. Clang assumes coerced function argument is in address space 0, which is not always true and results in invalid bitcasts. This patch fixes failure in OpenCL conformance test api/get_kernel_arg_info with amdgcn---amdgizcl

Buildbot numbers for the week of 06/18/2017 - 06/24/2017

Hello everyone, Below are some buildbot numbers for the last week of 06/18/2017 - 06/24/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh created this revision. When profile data is given, .hot/.unlikely section prefix is added to hot/cold functions for linker to improve code locality. GCC controls this behavior with '-f(no)-reorder-functions' flag, while LLVM uses opt tool option '-profile-guided-section-prefix=true/false'.

Buildbot numbers for the week of 06/11/2017 - 06/17/2017

Hello everyone, Below are some buildbot numbers for the week of 06/11/2017 - 06/17/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak updated this revision to Diff 104579. ahatanak added a comment. The updated patch produces diagnostics if an aligned allocation function is selected that is not implemented in the c++ standard library of the deployment target (except when the function is defined by the user and its

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak added a comment. I'll revert the changes I made to libc++ that annotates the allocation functions with availability later. https://reviews.llvm.org/D34574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r306632 - [libc++] Hoist explicit instantiation above implicit. NFC

Author: smeenai Date: Wed Jun 28 19:52:46 2017 New Revision: 306632 URL: http://llvm.org/viewvc/llvm-project?rev=306632=rev Log: [libc++] Hoist explicit instantiation above implicit. NFC The string literal operators have implicit instantiations of basic_string and basic_string, which prevent the

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me. Now if we could only figure out when aligned allocation is unavailable on other platforms this easily :) Comment at:

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc planned changes to this revision. mibintc added a comment. I'm planning to rework this patch again. sorry for the churn. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!

zaks.anna added a comment. I agree that we should not print the values of all variables. The users will be overwhelmed with the huge amount of information. It is very valuable to highlight just the right information. (I believe even the current diagnostics often produce too much info and

RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Hahnfeld added a subscriber: cfe-commits. Hahnfeld edited reviewers, added: rsmith, rengolin; removed: cfe-commits. Hahnfeld added a comment. Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi created this revision. Herald added a subscriber: hiraditya. We don't want to autocomplete flags whose Flags class has `NoDriverOption` when argv[1] is not `-cc1`. Another idea for this implementation is to make --autocomplete a cc1 option and handle it in clang Frontend, by porting

[PATCH] D34779: Fix floating point promotions for overload purposes

t.p.northover created this revision. Herald added a subscriber: mcrosier. This has a couple of changes to how Clang determines whether a floating-point promotion has occurred for C++ (and `__attribute__((overloadable))`) purposes. First, I think the special rules for C are based on a

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added a comment. In https://reviews.llvm.org/D33932#793994, @djasper wrote: > Just make clang-format always do this. I don't think anyone is relying on the > current behavior. Done, PTAL. https://reviews.llvm.org/D33932 ___

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

Anastasia added a comment. Sure, no problem! We might add some note on this feature to Clang manual. But we can do it later as well. Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104490. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h

[libcxx] r306580 - Added failing tests for index out of range for tuple_element<pair<T1, T2>> and variant_alternative<>

Author: marshall Date: Wed Jun 28 11:18:30 2017 New Revision: 306580 URL: http://llvm.org/viewvc/llvm-project?rev=306580=rev Log: Added failing tests for index out of range for tuple_element> and variant_alternative<> Added:

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

Anastasia added a comment. In https://reviews.llvm.org/D34342#792350, @bader wrote: > Note: `get_sampler_initializer` from my test case returns integer, not a > sampler, but having function is not relevant to the problem. > Here is a bit simplified test case without function calls that still

Re: r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Hi Graydon, Can you please add a testcase for this? Thanks, On Wed, Jun 28, 2017 at 11:36 AM, Graydon Hoare via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: graydon > Date: Wed Jun 28 11:36:27 2017 > New Revision: 306583 > > URL: http://llvm.org/viewvc/llvm-project?rev=306583=rev

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes

[libcxx] r306581 - Updated notest on 2974

Author: marshall Date: Wed Jun 28 11:19:34 2017 New Revision: 306581 URL: http://llvm.org/viewvc/llvm-project?rev=306581=rev Log: Updated notest on 2974 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL:

r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Author: graydon Date: Wed Jun 28 11:36:27 2017 New Revision: 306583 URL: http://llvm.org/viewvc/llvm-project?rev=306583=rev Log: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. Summary: In change 2ba19793512, the ASTReader logic for ObjC interfaces was modified to

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306583: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34741 Files:

[clang-tools-extra] r306598 - [clangd] Cleanup ClangdUnit.cpp, update docs; NFC

Author: omtcyfz Date: Wed Jun 28 13:57:28 2017 New Revision: 306598 URL: http://llvm.org/viewvc/llvm-project?rev=306598=rev Log: [clangd] Cleanup ClangdUnit.cpp, update docs; NFC * Enforce 80 characters limit where appropriate * Use slightly more descriptive names for searched locations * Update

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

vsk added a comment. Do you know which function clang was processing when it crashed? That would help us find a test case. https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

hokein added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; aaron.ballman wrote: > xazax.hun wrote: > > hokein wrote: > > > hokein wrote: > > > >

[PATCH] D34771: [clang-tidy] follow-up on misc-definitions-in-header check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. - add `-std=c++11` to `.hpp` file by default. - add constexpr function to test and doc. https://reviews.llvm.org/D34771 Files: docs/clang-tidy/checks/misc-definitions-in-headers.rst

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc updated this revision to Diff 104471. chandlerc added a comment. Update based an Daniel's feedback. https://reviews.llvm.org/D33932 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/SortIncludesTest.cpp

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; hokein wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > hokein wrote: > > > >

[PATCH] D34771: [clang-tidy] follow-up on misc-definitions-in-header check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea updated this revision to Diff 104527. gtbercea added a comment. Split previous diff into a "device offloading kind" patch (show here) and a **new** patch which relies on a new compiler flag. A TODO has been added to signal that the compute capability is to be handled in the **new**

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807 + case 0: +return PassBuilder::O0; + case 1: tejohnson wrote: > chandlerc wrote: > > Why is this change needed? > I assume it is just cleanup since this isn't currently

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen updated this revision to Diff 104533. timshen marked 5 inline comments as done. timshen added a comment. Added -fexperimental-new-pass-manager=off/on/debug for printing debug information. Added a Clang test. Do tell if you want me to split this patch. I didn't, becuase then I don't

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

tejohnson added a comment. In https://reviews.llvm.org/D34728#794508, @timshen wrote: > Added -fexperimental-new-pass-manager=off/on/debug for printing debug > information. > > Added a Clang test. > > Do tell if you want me to split this patch. I didn't, becuase then I don't > have to write a

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 104532. Repository: rL LLVM https://reviews.llvm.org/D34784 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 104535. gtbercea added a comment. [Update regression tests] Add a test for propagating the compute capability to the OpenMP device offloading toolchain which targets NVIDIA GPUs. This is a test for patch D34784 which is

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

chandlerc added inline comments. Comment at: clang/include/clang/Driver/Options.td:971-973 +def fexperimental_new_pass_manager_EQ : Joined<["-"], "fexperimental-new-pass-manager=">, + Group, Flags<[CC1Option]>, + HelpText<"Enables an experimental new pass manager in LLVM.">,

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea created this revision. OpenMP has the ability to offload target regions to devices which may have different architectures. A new -fopenmp-target-arch flag is introduced to specify the device architecture. In this patch I use the new flag to specify the compute capability of the

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

timshen created this revision. Herald added subscribers: hiraditya, mehdi_amini, sanjoy. https://reviews.llvm.org/D34790 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/CodeGenOptions.def clang/include/clang/Frontend/CodeGenOptions.h

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen updated this revision to Diff 104551. timshen added a comment. Splitted into two patches. I'll commit this one (ThinLTO change) without the test first, then commit the flag change with the Clang ThinLTO pipeline test. https://reviews.llvm.org/D34728 Files:

r306622 - CodeGen: handle missed case of COMDAT handling

Author: compnerd Date: Wed Jun 28 17:54:44 2017 New Revision: 306622 URL: http://llvm.org/viewvc/llvm-project?rev=306622=rev Log: CodeGen: handle missed case of COMDAT handling When Protocol references are constructed, we need to add the reference symbol to a COMDAT group on non-MachO object

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM as well. https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r306612 - clangDaemon requires clangLex.

Author: chapuni Date: Wed Jun 28 15:57:15 2017 New Revision: 306612 URL: http://llvm.org/viewvc/llvm-project?rev=306612=rev Log: clangDaemon requires clangLex. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL:

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

graydon created this revision. Add a test for the change to ASTReader that reproduces the logic for consolidating multiple ObjC interface definitions to the case of multiple ObjC protocol definitions. This test is a modified copy of the test that accompanied the original change to interfaces, in

Re: r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Yes, I wasn't sure how to test it at this level (there's a pending test at the swift level) but, as you pointed out in separate email, there was an adaptable test in the original commit this is a copy-and-modification of, so I copied-and-modified the test as well. Posted for review in

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

rogfer01 added a comment. I agree with the spirit of the change but I think you want to use `AArch64::` enumerators instead of those in `ARM::` Comment at: lib/Basic/Targets.cpp:6190 unsigned HasFullFP16; + unsigned ArchKind; There is an

[clang-tools-extra] r306530 - [clangd] Allow to override resource dir in ClangdServer.

Author: ibiryukov Date: Wed Jun 28 03:34:50 2017 New Revision: 306530 URL: http://llvm.org/viewvc/llvm-project?rev=306530=rev Log: [clangd] Allow to override resource dir in ClangdServer. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits Tags:

[PATCH] D34470: [clangd] Allow to override resource dir in ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306530: [clangd] Allow to override resource dir in ClangdServer. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D34470 Files: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1 -// RUN: %check_clang_tidy %s misc-definitions-in-headers %t +// RUN: %check_clang_tidy %s

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D34687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

xazax.hun added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1 -// RUN: %check_clang_tidy %s misc-definitions-in-headers %t +// RUN: %check_clang_tidy %s misc-definitions-in-headers %t -- -- -std=c++1z hokein wrote: > hokein

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

SjoerdMeijer updated this revision to Diff 104380. SjoerdMeijer added a comment. Thanks! I am now using llvm::AArch64::ArchKind. And I agree that the check for setting __ARM_FEATURE_QRDMX is suspicious. I will address this separately. https://reviews.llvm.org/D34686 Files:

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > Do not evaluate numbers. > > > Check for != "=" is needed not to mess with

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793594, @klimek wrote: > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > > > Do not

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

puneetha added a comment. This is committed by karthik, at r306519. Thank you. https://reviews.llvm.org/D34198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793573, @klimek wrote: > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > Do not evaluate numbers. > > Check for != "=" is needed not to mess with invalid default arguments or > > their types (without it I get "const Bar&

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 104390. mharoush added a comment. Updated inline asm tests to look for decimal immediate value instead of looking for the original string e.g. 10 vs 0xA and other variations. Also updated the test cases to use check-same etc. Repository: rL LLVM

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104394. johannes added a comment. - remove unused struct - rename getNodeValueI -> getNodeValueImpl https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 104391. mharoush marked an inline comment as done. mharoush added a comment. simplified the rewrite condition of complex expressions and eliminated the need to use the ReplaceEnumIdentifier flag. This requires making small adjustments to some of the older

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM for when the dependent patches are in. https://reviews.llvm.org/D34721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

klimek added a comment. The main thing I'm concerned about is having the main code in core, but having all tests in tools-extra. I think if we go that route we should also move clang-rename and its tests to core. Thoughts? Repository: rL LLVM https://reviews.llvm.org/D34696

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793601, @yvvan wrote: > In https://reviews.llvm.org/D33644#793594, @klimek wrote: > > > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > > > In

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush marked 4 inline comments as done. mharoush added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1382 +if (const MCConstantExpr *CE = +dyn_cast_or_null(Val)) { + StringRef ErrMsg; rnk wrote: > rnk

[PATCH] D34686: [AArch64] ARMV8-A archkind and target defines helper functions

SjoerdMeijer updated this revision to Diff 104393. SjoerdMeijer retitled this revision from "[AArch64] Add hasFP16VectorArithmetic helper function. NFCI" to "[AArch64] ARMV8-A archkind and target defines helper functions". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306538: [clang-tidy] Enable inline variable definitions in headers (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34449?vs=104379=104389#toc Repository: rL LLVM

[clang-tools-extra] r306538 - [clang-tidy] Enable inline variable definitions in headers

Author: xazax Date: Wed Jun 28 05:47:35 2017 New Revision: 306538 URL: http://llvm.org/viewvc/llvm-project?rev=306538=rev Log: [clang-tidy] Enable inline variable definitions in headers Differential Revision: https://reviews.llvm.org/D34449 Added:

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104395. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104401. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; xazax.hun wrote: > hokein wrote: > > hokein wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

ioeric added a comment. In https://reviews.llvm.org/D34696#793613, @klimek wrote: > The main thing I'm concerned about is having the main code in core, but > having all tests in tools-extra. I think if we go that route we should also > move clang-rename and its tests to core. Thoughts?

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

tejohnson added a comment. In https://reviews.llvm.org/D34728#793131, @timshen wrote: > A question I have is that I don't know how to test this. Ideally we want > -debug-pass-manager from opt, but that flag is not part of the LLVM libraries. How about add a clang test that builds with "-mllvm

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel wrote: > gtbercea wrote: > > hfinkel

[PATCH] D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306549: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D34469 Files: cfe/trunk/include/clang/Frontend/Utils.h

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. gtbercea wrote: > hfinkel wrote: > > gtbercea

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov created this revision. https://reviews.llvm.org/D34755 Files: unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp === --- unittests/clangd/ClangdTests.cpp +++ unittests/clangd/ClangdTests.cpp

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov added a comment. I wonder if it's gonna fail on Windows. Maybe enable it only on Linux? https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir added a comment. I think this is ready for a review. https://reviews.llvm.org/D34749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov added a comment. I wonder if it's gonna fail on Windows. Maybe enable it only on Linux? https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r306549 - Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

Author: ibiryukov Date: Wed Jun 28 08:06:34 2017 New Revision: 306549 URL: http://llvm.org/viewvc/llvm-project?rev=306549=rev Log: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. Summary: It used to always call into the RealFileSystem before. Reviewers: bkramer, krasimir,

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. gtbercea wrote: > hfinkel wrote: > > Why is this a

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson updated this revision to Diff 104413. malaperle-ericsson added a comment. Remove use of unique_ptr https://reviews.llvm.org/D34269 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir created this revision. Herald added a subscriber: klimek. This patch makes the `{` in `msg_field{field: OK}` in a proto option scope be treated as an assignment operator. Previosly the added test case was formatted as: option (MyProto.options) = { field_a: OK field_b{field_c:

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir updated this revision to Diff 104410. krasimir added a comment. - Add a msg-style test too https://reviews.llvm.org/D34749 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestProto.cpp Index: unittests/Format/FormatTestProto.cpp

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel

Re: r306127 - [GSoC] Add support for CC1 options.

Thank you for your feedback! For options which have `NoDriverOption` Flags (such as -mrelocation-model), I agree that we should expose these flags to users only when `-cc1` is also passed. However, as to `-mrelocation-model [tab]`, I think it is fine to provide possible values for this option

RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Hahnfeld added a comment. Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux if the file is present. >> Thank you Adding Richard (general maintainer) and Renato (ARM Linux) so they are aware.

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

djasper added a comment. Just make clang-format always do this. I don't think anyone is relying on the current behavior. https://reviews.llvm.org/D33932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D34741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 104437. erik.pilkington added a comment. Improve diagnostics for unnamed types. https://reviews.llvm.org/D33816 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DelayedDiagnostic.h include/clang/Sema/Sema.h

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

yamaguchi created this revision. When user build clang and used completion Eg. `build/bin/clang -fno[tab]`, we want to invoke `build/bin/clang --autocomplete=-fno`, rather than `clang --autocomplete=-fno`. https://reviews.llvm.org/D34761 Files: clang/utils/bash-autocomplete.sh Index:

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

ruiu accepted this revision. ruiu added a comment. LGTM https://reviews.llvm.org/D34761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >