modocache created this revision.
Depends on https://reviews.llvm.org/D34864.
To unify Clang and LLVM's spelling of "diagnostic[s] hotness", use the
new "diagnostics hotness" spelling in LLVM, which was added in
https://reviews.llvm.org/D34864.
https://reviews.llvm.org/D34865
Files:
modocache created this revision.
Herald added a subscriber: fhahn.
Depends on https://reviews.llvm.org/D34867.
Add a Clang frontend option to enable optimization remark hotness
thresholds, which were added to LLVM in https://reviews.llvm.org/D34867.
This prevents diagnostics that do not meet a
Author: echristo
Date: Thu Jun 29 23:03:47 2017
New Revision: 306790
URL: http://llvm.org/viewvc/llvm-project?rev=306790=rev
Log:
Add -no-canonical-prefixes to the test line so that we can handle different
build modes.
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified:
Author: sberg
Date: Fri Jun 30 00:22:02 2017
New Revision: 306799
URL: http://llvm.org/viewvc/llvm-project?rev=306799=rev
Log:
Fold exception-warnings.cpp into warn-throw-out-noexcept-func.cpp
I had failed to notice the latter existed when I recently introduced the former.
Removed:
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
This LGTM. Thanks for the refactoring and the fix.
https://reviews.llvm.org/D34686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Please re-upload the patch with full context (see
http://llvm.org/docs/Phabricator.html).
Comment at: lib/Tooling/CommonOptionsParser.cpp:119
joey created this revision.
Herald added subscribers: Anastasia, yaxunl.
Slightly improve the diagnostic by including the function name.
This has been separated out from https://reviews.llvm.org/D33945.
https://reviews.llvm.org/D34871
Files:
Sema/Sema.cpp
SemaOpenCL/extension-begin.cl
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Please upload a diff with full context (http://llvm.org/docs/Phabricator.html).
Comment at: include/clang/Tooling/DiagnosticsYaml.h:86-95
-std::vector
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306805: ARMV8-A archkind and target defines helper functions
(authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D34686?vs=104393=104830#toc
Repository:
rL LLVM
Author: sjoerdmeijer
Date: Fri Jun 30 01:07:34 2017
New Revision: 306805
URL: http://llvm.org/viewvc/llvm-project?rev=306805=rev
Log:
ARMV8-A archkind and target defines helper functions
This introduces helper functions that set target defines for different ARMV8-A
architecture kinds. It fixes
On 30/06/17 01:03, Evgenii Stepanov wrote:
This change broke clang/ubsan bot.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio
It looks like the value you are initializing SavedAK with may itself
be uninitialized? I see a few
arphaman added a comment.
Ah, I see, so this is more of a stylistic warning rather than "suspicious" use
one.
In https://reviews.llvm.org/D34810#795926, @rtrieu wrote:
> What is the reason to exclude void expressions now? For the function case,
> it is more consistent to warn on all
Author: djasper
Date: Fri Jun 30 01:02:37 2017
New Revision: 306804
URL: http://llvm.org/viewvc/llvm-project?rev=306804=rev
Log:
Fix heap use after free introduced by r306769.
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
Author: vvassilev
Date: Fri Jun 30 02:25:43 2017
New Revision: 306809
URL: http://llvm.org/viewvc/llvm-project?rev=306809=rev
Log:
Ambiguity might be also uninitialized. Use llvm::Optional.
Modified:
cfe/trunk/include/clang/Sema/Lookup.h
Modified: cfe/trunk/include/clang/Sema/Lookup.h
URL:
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Just one minor comment.
Thanks.
Comment at: clang/Sema/Sema.h:8435
/// \return true if type is disabled.
- bool checkOpenCLDisabledDecl(const Decl , const Expr );
+
teemperor added a comment.
I didn't have time to have a close look at this patch, but it seems you're
interested in the specific TU-independent data of a Stmt to compare them. So if
you are interested in the such data and don't want to write your own function
to collect data it for each Stmt
joey added a comment.
Thanks!
Making that change, going to re-run the tests and then I'll commit.
https://reviews.llvm.org/D34871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG, thx for bearing with me, this looks great.
(and sorry if I didn't send this earlier, just noticed I forgot to hit submit
:( )
Comment at:
arphaman added a comment.
I think that it's pretty much ready. I think that the test should be expanded
though. At the very least it should check that all of the node types that are
supported by `SyntaxTreeImpl::getNodeValueImpl` get matched.
https://reviews.llvm.org/D34329
yvvan created this revision.
With that patch applied my 32-bit libclang.dll built with mingw does not crash
anymore
unit tests are not affected by that change
https://reviews.llvm.org/D34873
Files:
lib/AST/ExprConstant.cpp
Index: lib/AST/ExprConstant.cpp
arphaman added a comment.
I think I'd rather move `clang-rename` first.
Comment at: tools/extra/clang-rename/tool/ClangRename.cpp:167
FindingAction.getUSRList();
const std::vector = FindingAction.getUSRSpellings();
if (PrintName) {
alexshap
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D34865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
anemet added a comment.
Great!
Comment at: docs/UsersManual.rst:330-332
This option, which defaults to off, controls whether Clang prints the
profile hotness associated with a diagnostics in the presence of
profile-guided optimization information. This is
Author: abataev
Date: Fri Jun 30 06:50:13 2017
New Revision: 306825
URL: http://llvm.org/viewvc/llvm-project?rev=306825=rev
Log:
[OPENMP] Initial support for taskloop reductions.
Add sema/parsupping ort for taskloop [simd] reductions.
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.def
teemperor added a comment.
Yes, it does indeed skip identifiers and literals for this reason :). It was
planned to make this template more configurable for use cases like yours, so
I'm totally fine with adding configuration parameters. I just opened
https://reviews.llvm.org/D34880 where I make
djasper added a comment.
Can you add a test? Tests for this kind of behavior of the clang-format command
line go in test/Format/.
Comment at: tools/clang-format/ClangFormat.cpp:380
+if (Verbose.getNumOccurrences() != 0)
+outs() << "Formatting " << FileNames[0] <<
johannes marked an inline comment as done.
johannes added a comment.
In https://reviews.llvm.org/D34329#796574, @teemperor wrote:
> I didn't have time to have a close look at this patch, but it seems you're
> interested in the specific TU-independent data of a Stmt to compare them. So
> if you
Author: d0k
Date: Fri Jun 30 06:23:24 2017
New Revision: 306823
URL: http://llvm.org/viewvc/llvm-project?rev=306823=rev
Log:
Revert "Modify test so that it looks for patterns in stderr as well"
This reverts commit r303735. No longer needed after r306822 sends the
diagnostics to the proper output
Hahnfeld created this revision.
Combined directives like 'target parallel' have two captured statements. Sema
has to check the right one from the right direction.
Previously, Sema::IsOpenMPCapturedByRef would return false for mapped scalars
on combined directives. This results in a wrong
Author: kuba.brecka
Date: Fri Jun 30 09:28:15 2017
New Revision: 306837
URL: http://llvm.org/viewvc/llvm-project?rev=306837=rev
Log:
[objc] Don't require null-check and don't emit memset when result is ignored
for struct-returning method calls [clang part]
This fixes an issue with the emission
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
It worked!
On 30 June 2017 at 18:15, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Fri Jun 30 10:15:48 2017
> New Revision: 306844
>
> URL: http://llvm.org/viewvc/llvm-project?rev=306844=rev
> Log:
> Attempt to fix the linkage error caused by r306840
andrew.zhogin updated this revision to Diff 104893.
andrew.zhogin added a comment.
Herald added a subscriber: aprantl.
Updated to the current repository state.
https://reviews.llvm.org/D18240
Files:
lib/Frontend/PrintPreprocessedOutput.cpp
test/Misc/asm_hash_comments.s
Index:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D34888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added a comment.
Sorry about the breakage. I'll redo this limiting it to windows-itanium (and
add a comment explaining why we want it).
Repository:
rL LLVM
https://reviews.llvm.org/D34850
___
cfe-commits mailing list
Author: compnerd
Date: Fri Jun 30 08:15:39 2017
New Revision: 306830
URL: http://llvm.org/viewvc/llvm-project?rev=306830=rev
Log:
Driver: fix option declaration
The option is a "joined" argument. Fix silly copy-paste error. This
allows the parsing to work at runtime.
Modified:
Author: compnerd
Date: Fri Jun 30 08:15:38 2017
New Revision: 306829
URL: http://llvm.org/viewvc/llvm-project?rev=306829=rev
Log:
Driver: honor -nostdinc and -isystem-after on CrossWindows
This changes CrossWindows to look for -nostdinc instead of -nostdlibinc.
In addition, fixes a bug where
compnerd closed this revision.
compnerd added a comment.
SVN r306829
https://reviews.llvm.org/D34839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 104881.
bruno added a comment.
> Digging into this a bit more, I think the root of the problem is that the
> `ND->isExternallyVisible()` call in
> `LookupResult::isHiddenDeclarationVisible` is wrong. Redeclaration lookup
> should never find hidden
rnk added a comment.
This appears to affect our behavior under the MS ABI. We still seem to use this
logic from CGVTables, even though that code is primarily Itanium related. In
http://crbug.com/738468 we're seeing the LNK4102 linker warning, which says:
"export of deleting destructor (name);
arphaman added a comment.
I didn't notice that ClassReplacements.cpp had a dependency on
clang-apply-replacements. I moved it back to clang-tools-extra to the
clang-apply-replacements tests.
Repository:
rL LLVM
https://reviews.llvm.org/D34696
Author: rnk
Date: Fri Jun 30 09:12:14 2017
New Revision: 306836
URL: http://llvm.org/viewvc/llvm-project?rev=306836=rev
Log:
[MS] Test that deleting destructor thunks are not exported
The MSVC linker emits the LNK4102 warning if they are.
Added:
Author: rnk
Date: Fri Jun 30 09:11:49 2017
New Revision: 306835
URL: http://llvm.org/viewvc/llvm-project?rev=306835=rev
Log:
Revert "[CodeGen] Propagate dllexport to thunks"
This reverts r306770, it causes LNK4102 warnings in MSVC builds.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of comments.
On the LLVM side, X86.td GoldMont class looks like it needs RDRAND as well.
Comment at: lib/Basic/Targets.cpp:3310
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
Author: arphaman
Date: Fri Jun 30 09:58:36 2017
New Revision: 306843
URL: http://llvm.org/viewvc/llvm-project?rev=306843=rev
Log:
Move ClassReplacements.cpp test from clang-rename tests to the
clang-apply-replacements tests
The ClassReplacements.cpp test in the clang-rename tests uses
Author: arphaman
Date: Fri Jun 30 09:43:00 2017
New Revision: 306841
URL: http://llvm.org/viewvc/llvm-project?rev=306841=rev
Log:
Use add_clang_unittest in the CMakeLists.txt for the moved unittest
The unittest was moved in r306840
Modified:
cfe/trunk/unittests/Rename/CMakeLists.txt
Author: arphaman
Date: Fri Jun 30 10:15:48 2017
New Revision: 306844
URL: http://llvm.org/viewvc/llvm-project?rev=306844=rev
Log:
Attempt to fix the linkage error caused by r306840 on the mingw-RA-on-linux bot
Modified:
cfe/trunk/tools/clang-rename/CMakeLists.txt
Modified:
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
lgtm with a nitpick.
Comment at: include/clang/Sema/Sema.h:3351
+ ObjCInterfaceDecl *IDecl, SourceRange
AtEnd);
+ void
craig.topper added a comment.
There's a separate review for X86.d https://reviews.llvm.org/D34828
https://reviews.llvm.org/D34842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh created this revision.
Herald added subscribers: eraman, inglorion, mehdi_amini, sanjoy.
This patch should be enabled after https://reviews.llvm.org/D34895
https://reviews.llvm.org/D34896
Files:
test/CodeGen/pgo-sample-thinlto-summary.c
Index:
bruno added a comment.
Hi @v.g.vassilev, sorry for the delay.
Just updated https://reviews.llvm.org/D31778. I agree with Richard's
observations, do you think you can extend it to work in the same way as
https://reviews.llvm.org/D31778 does? The structural checking is already
abstracted there
hfinkel added a comment.
...
>
Okay, good, this is exactly where I was going when I said I was worried
about generalization. -march seems like one of many flags I might want to
pass to the target compilation. Moreover, it doesn't seem special in what
regard.
v.g.vassilev created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
Files:
include/clang/AST/Redeclarable.h
lib/AST/ExprConstant.cpp
lib/Basic/SourceManager.cpp
lib/Lex/PreprocessingRecord.cpp
lib/Sema/SemaType.cpp
lib/Serialization/ASTReader.cpp
rnk added a comment.
Have a minute to get to this? My attempt to work around the bug in Chromium was
incomplete.
https://reviews.llvm.org/D34714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: arphaman
Date: Fri Jun 30 09:36:09 2017
New Revision: 306840
URL: http://llvm.org/viewvc/llvm-project?rev=306840=rev
Log:
[refactor] Move clang-rename into the clang repository
The core engine of clang-rename will be used for local and global renames in the
new refactoring engine, as
Author: modocache
Date: Fri Jun 30 12:37:11 2017
New Revision: 306862
URL: http://llvm.org/viewvc/llvm-project?rev=306862=rev
Log:
[ORE] Use LLVM's "diagnostics hotness" spelling
Summary:
Depends on https://reviews.llvm.org/D34864.
To unify Clang and LLVM's spelling of "diagnostic[s] hotness",
bob.wilson added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1350
+Minor = 99;
+ }
} else if (Platform == TvOS) {
What about Micro = 99?
https://reviews.llvm.org/D34529
___
kastiglione added a comment.
There are other drivers with the same issue. If there's no opposition to this,
I can update those here as well.
https://reviews.llvm.org/D34909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added a comment.
Committed as r306878-360881.
Repository:
rL LLVM
https://reviews.llvm.org/D34907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Fri Jun 30 11:14:02 2017
New Revision: 306850
URL: http://llvm.org/viewvc/llvm-project?rev=306850=rev
Log:
[X86] Add a break to the last case of a few switches to prevent accidents in
the future. NFC
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified:
Author: ctopper
Date: Fri Jun 30 11:14:01 2017
New Revision: 306849
URL: http://llvm.org/viewvc/llvm-project?rev=306849=rev
Log:
[X86] Move all atom CPUs to the same section of the switch and use fallthroughs
like we do for other CPU generations. NFC
This is prep work to add MOVBE to all Atom
Author: ctopper
Date: Fri Jun 30 11:14:04 2017
New Revision: 306851
URL: http://llvm.org/viewvc/llvm-project?rev=306851=rev
Log:
[X86] Add RDRND feature to Goldmont. Add MOVBE to all Atom CPUs.
Diffential Revision: https://reviews.llvm.org/D34842
Modified:
cfe/trunk/lib/Basic/Targets.cpp
mibintc updated this revision to Diff 104911.
mibintc added a subscriber: ilya-biryukov.
mibintc added a comment.
The previous (n-1) version didn't work: I wanted to iterate through the system
include directories to check for the existence of stdc-predef.h but clang is
using a different kind of
vsk added a comment.
Thanks for the stack trace. Clang shouldn't ever be assigning counters to decls
without bodies. As far as I can tell, this has only been happening when the
microsoft ABI is in use, which may explain why we don't hit the issue more
often. The fix required changing the way
kastiglione created this revision.
Using both -nostdinc and -nostdinc++ should not emit diagnostics.
https://reviews.llvm.org/D34909
Files:
lib/Driver/ToolChains/CrossWindows.cpp
test/Driver/windows-cross.c
Index: test/Driver/windows-cross.c
Author: vedantk
Date: Fri Jun 30 14:02:14 2017
New Revision: 306882
URL: http://llvm.org/viewvc/llvm-project?rev=306882=rev
Log:
Fix a typo. NFC.
Modified:
cfe/trunk/test/Profile/cxx-structors.cpp
Modified: cfe/trunk/test/Profile/cxx-structors.cpp
URL:
v.g.vassilev created this revision.
Patch by Axel Naumann!
Repository:
rL LLVM
https://reviews.llvm.org/D34912
Files:
lib/AST/TemplateBase.cpp
Index: lib/AST/TemplateBase.cpp
===
--- lib/AST/TemplateBase.cpp
+++
ahatanak updated this revision to Diff 104906.
ahatanak added a comment.
Address review comments.
- Change the error message from "invalid iOS deployment version '%0', maximum
allowable version is iOS 10" to "invalid iOS deployment version '%0', iOS 10 is
the maximum deployment target for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306874: clang-format: add options to merge empty record body
(authored by Typz).
Repository:
rL LLVM
https://reviews.llvm.org/D34395
Files:
cfe/trunk/include/clang/Format/Format.h
Author: typz
Date: Fri Jun 30 13:25:55 2017
New Revision: 306874
URL: http://llvm.org/viewvc/llvm-project?rev=306874=rev
Log:
clang-format: add options to merge empty record body
Summary:
This patch introduces a few extra BraceWrapping options, similar to
`SplitEmptyFunction`, to allow merging
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared-header.cpp:1
+// RUN: cp %S/Inputs/modernize-smart-ptr/shared_ptr.h %T/shared_ptr.h
+// RUN: %check_clang_tidy %s modernize-make-shared %t -- \
alexfh wrote:
> Maybe just add
hokein updated this revision to Diff 104922.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: JDevlieghere.
Rebase and address review comments.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaDecl.cpp:13693-13694
+ // passes the structural compatibility check in C11 6.2.7/1.
+ bool AllowODR =
Author: typz
Date: Fri Jun 30 13:00:02 2017
New Revision: 306868
URL: http://llvm.org/viewvc/llvm-project?rev=306868=rev
Log:
clang-format: Do not binpack initialization lists
Summary:
This patch tries to avoid binpacking when initializing lists/arrays, to allow
things like:
static int
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306868: clang-format: Do not binpack initialization lists
(authored by Typz).
Changed prior to commit:
https://reviews.llvm.org/D34238?vs=103057=104914#toc
Repository:
rL LLVM
Author: d0k
Date: Fri Jun 30 13:24:32 2017
New Revision: 306873
URL: http://llvm.org/viewvc/llvm-project?rev=306873=rev
Log:
[clang-rename] Just return instead of calling exit(3) from main.
Modified:
cfe/trunk/tools/clang-rename/ClangRename.cpp
Modified:
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D34909#797252, @kastiglione wrote:
> There are other drivers with the same issue. If there's no opposition to
> this, I can update those here as well.
Yes,
Author: ahatanak
Date: Fri Jun 30 11:50:23 2017
New Revision: 306859
URL: http://llvm.org/viewvc/llvm-project?rev=306859=rev
Log:
Revert "[libcxx] Annotate c++17 aligned new/delete operators with availability"
This reverts commit r306310.
r306310 causes clang to reject a call to an aligned
rsmith created this revision.
Herald added subscribers: aheejin, hiraditya, sbc100, nhaehnle, sanjoy, klimek.
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remove all the places where we use the LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
macros to try to
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I don't have any comments, this seems fine to me. Long term I think the best
solution is to get rid of these global specializations entirely, and instead
provide adapters called `flow` and
Author: rsmith
Date: Fri Jun 30 13:57:16 2017
New Revision: 306879
URL: http://llvm.org/viewvc/llvm-project?rev=306879=rev
Log:
Fix ODR violations due to abuse of LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remove
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306878: Fix ODR violations due to abuse of
LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR (authored by rsmith).
Changed prior to commit:
https://reviews.llvm.org/D34907?vs=104923=104928#toc
Repository:
rL
Author: rsmith
Date: Fri Jun 30 13:57:39 2017
New Revision: 306881
URL: http://llvm.org/viewvc/llvm-project?rev=306881=rev
Log:
Fix ODR violations due to abuse of LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR
This is a short-term fix for PR33650 aimed to get the modules build bots green
again.
Remove
rsmith added a comment.
You should remove the code after the `assert(0)`, or you'll trigger
"unreachable code" warnings.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith accepted this revision.
rsmith added a comment.
Thanks, do you need someone to commit this for you?
https://reviews.llvm.org/D33833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357
+: Warning<
+ "%0 has a non-throwing exception specification but can " "still "
+ "throw">,
+
yawanng created this revision.
yawanng added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, JDevlieghere, mgorny, srhines.
socket() is better to include SOCK_CLOEXEC in its type argument to avoid the
file descriptor leakage.
Repository:
rL LLVM
Author: echristo
Date: Fri Jun 30 19:55:23 2017
New Revision: 306928
URL: http://llvm.org/viewvc/llvm-project?rev=306928=rev
Log:
Update clang support for -mexecute-only/-mpure-code for backend change to use
subtarget feature rather than command line option.
Added:
v.g.vassilev added a comment.
Sure, I can do this, as long as this semantic change is ok.
Repository:
rL LLVM
https://reviews.llvm.org/D34891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bob.wilson accepted this revision.
bob.wilson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gtbercea updated this revision to Diff 104962.
gtbercea added a comment.
Check -fopenmp-targets has one entry when using default toolchain in
-Xopenmp-target.
https://reviews.llvm.org/D34784
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Cuda.cpp
chh accepted this revision.
chh added a comment.
This revision is now accepted and ready to land.
LGTM. If nobody needs this during the long weekend, it's better to submit after
the long weekend.
Repository:
rL LLVM
https://reviews.llvm.org/D34913
modocache updated this revision to Diff 104964.
modocache marked 4 inline comments as done.
modocache added a comment.
Address comments, for the most part. As for the documentation: I think this is
OK for now, but there are definitely a few more options that I'd like to
document, and those will
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Tested it locally, we actually need all these changes on top of
https://reviews.llvm.org/D31778.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D34510
jyu2 updated this revision to Diff 104959.
jyu2 added a comment.
Hi Aaron,
Thank you so much for your review. I just update change to address your
comments.
Let me kwon if you see more problems.
Thanks again.
Jennifer
Repository:
rL LLVM
https://reviews.llvm.org/D34671
Files:
jyu2 added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357
+: Warning<
+ "%0 has a non-throwing exception specification but can " "still "
+ "throw">,
+
rsmith added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409
+<< (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange()
+ : FD->getSourceRange());
+} else
Underlining the entire
Author: ahatanak
Date: Fri Jun 30 17:57:52 2017
New Revision: 306922
URL: http://llvm.org/viewvc/llvm-project?rev=306922=rev
Log:
[Driver] Check that the iOS deployment target is iOS 10 or earlier if
the target is 32-bit.
The following changes are made to the driver since 32-bit apps do not
run
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306922: [Driver] Check that the iOS deployment target is iOS
10 or earlier if (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D34529?vs=104958=104972#toc
Repository:
rL
1 - 100 of 137 matches
Mail list logo
