[PATCH] D35825: [clangd] Reuse compile commands during reparse

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:248 + VFS->setCurrentWorkingDirectory(Command.Directory); + Also have to call it in `codeComplete`. https://reviews.llvm.org/D35825 ___

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

NoQ added a comment. Yeah, right, good point =) https://reviews.llvm.org/D34260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35825: [clangd] Reuse compile commands during reparse

This revision was automatically updated to reflect the committed changes. Closed by commit rL308970: [clangd] Reuse compile commands during reparse (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D35825 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D35825: [clangd] Reuse compile commands during reparse

krasimir updated this revision to Diff 108033. krasimir added a comment. - Address review comment https://reviews.llvm.org/D35825 Files: clangd/ClangdUnit.cpp clangd/ClangdUnitStore.h Index: clangd/ClangdUnitStore.h === ---

[PATCH] D35828: Fix incorrect use of current directory to find moved paths in ASTReader.

klimek created this revision. CurrentDir was set as the path of the current module, but that can change as part of a chain of loaded modules. When we try to locate a file mentioned in a module that does not exist, we use a heuristic to look at the relative path between the original location of

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

szepet added a comment. In https://reviews.llvm.org/D34260#819721, @NoQ wrote: > ... and add the extra run-line that'd show you the backtrace. We made > changes, so the issue might have been wiped out accidentally (or maybe you're > actually right!), and if it wasn't, at least we'd have the

[PATCH] D35825: [clangd] Reuse compile commands during reparse

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r308969 - Fix spelling of FileCheck in test.

Author: klimek Date: Tue Jul 25 04:34:55 2017 New Revision: 308969 URL: http://llvm.org/viewvc/llvm-project?rev=308969=rev Log: Fix spelling of FileCheck in test. Modified: cfe/trunk/test/CodeGen/x86-ms-inline-asm-enum_feature.cpp Modified:

[PATCH] D35557: clang-format: merge short case labels with trailing comments

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thanks! https://reviews.llvm.org/D35557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35825: [clangd] Reuse compile commands during reparse

krasimir created this revision. Previously we always queried the compilation database and discarded the results if the file was already opened. https://reviews.llvm.org/D35825 Files: clangd/ClangdUnit.cpp clangd/ClangdUnitStore.h Index: clangd/ClangdUnitStore.h

r308957 - [analyzer] Further improve suppress-on-sink behavior in incomplete analyses.

Author: dergachev Date: Tue Jul 25 02:25:10 2017 New Revision: 308957 URL: http://llvm.org/viewvc/llvm-project?rev=308957=rev Log: [analyzer] Further improve suppress-on-sink behavior in incomplete analyses. If a certain memory leak (or other similar bug) found by the analyzer is known to be

[PATCH] D35673: [analyzer] A better CFG-based suppress-on-sink.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308957: [analyzer] Further improve suppress-on-sink behavior in incomplete analyses. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D35673?vs=107871=108024#toc Repository:

r308967 - [PM] Setup TargetLibraryInfo correctly for the new pass manager.

Author: chandlerc Date: Tue Jul 25 03:46:07 2017 New Revision: 308967 URL: http://llvm.org/viewvc/llvm-project?rev=308967=rev Log: [PM] Setup TargetLibraryInfo correctly for the new pass manager. Without this, -fno-builtin and friends doesn't work. Added the obvious RUN lines to the test for

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. FWIW, I went ahead and implemented this functionality in GCC. It has been merged into its c++-modules branch. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant

ogoffart added a comment. ping https://reviews.llvm.org/D35190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r308961 - [analyzer] Treat throws as sinks for suppress-on-sink purposes.

Author: dergachev Date: Tue Jul 25 02:44:02 2017 New Revision: 308961 URL: http://llvm.org/viewvc/llvm-project?rev=308961=rev Log: [analyzer] Treat throws as sinks for suppress-on-sink purposes. Because since r308957 the suppress-on-sink feature contains its own mini-analysis, it also needs to

[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308961: [analyzer] Treat throws as sinks for suppress-on-sink purposes. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D35674?vs=107873=108029#toc Repository: rL LLVM

[PATCH] D35828: Fix incorrect use of current directory to find moved paths in ASTReader.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D35828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r308962 - Fix incorrect use of current directory to find moved paths in ASTReader.

Author: klimek Date: Tue Jul 25 03:22:06 2017 New Revision: 308962 URL: http://llvm.org/viewvc/llvm-project?rev=308962=rev Log: Fix incorrect use of current directory to find moved paths in ASTReader. CurrentDir was set as the path of the current module, but that can change as part of a chain of

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

This revision was automatically updated to reflect the committed changes. Closed by commit rL308965: This patch enables the usage of constant Enum identifiers within Microsoft… (authored by mharoush). Changed prior to commit: https://reviews.llvm.org/D33277?vs=104390=108044#toc Repository:

[clang-tools-extra] r308959 - [clangd] Workaround Windows test failures.

Author: ibiryukov Date: Tue Jul 25 02:31:51 2017 New Revision: 308959 URL: http://llvm.org/viewvc/llvm-project?rev=308959=rev Log: [clangd] Workaround Windows test failures. To properly fix this, Unix-specific paths should not be used when running tests on Windows. Modified:

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

NoQ added a comment. > I suspect that the usage of the CFGStmtMap* caused the undefined behaviour > since its lifetime was depending on its LocationContext. Yeah, it lives in `AnalysisDeclContextManager`, which lives in `AnalysisManager`, which lives throughout a single analysis (top-level

[clang-tools-extra] r308970 - [clangd] Reuse compile commands during reparse

Author: krasimir Date: Tue Jul 25 04:37:43 2017 New Revision: 308970 URL: http://llvm.org/viewvc/llvm-project?rev=308970=rev Log: [clangd] Reuse compile commands during reparse Summary: Previously we always queried the compilation database and discarded the results if the file was already

[PATCH] D35826: [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.

fhahn created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. M-class profiles do not support ARM execution mode, so providing -marm/-mno-thumb does not make sense in combination with -mcpu/-march options that support the M-profile. This is a follow-up patch to

[PATCH] D35828: Fix incorrect use of current directory to find moved paths in ASTReader.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308962: Fix incorrect use of current directory to find moved paths in ASTReader. (authored by klimek). Repository: rL LLVM https://reviews.llvm.org/D35828 Files:

r308965 - This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements.

Author: mharoush Date: Tue Jul 25 03:43:43 2017 New Revision: 308965 URL: http://llvm.org/viewvc/llvm-project?rev=308965=rev Log: This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements. Differential Revision: https://reviews.llvm.org/D33277

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk updated this revision to Diff 108061. kfunk added a comment. Addressed concerns https://reviews.llvm.org/D35194 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml

[PATCH] D35624: Removal of microMIPS64R6

abeserminji marked 2 inline comments as done. abeserminji added a comment. Comments resolved Repository: rL LLVM https://reviews.llvm.org/D35624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman updated this revision to Diff 108078. arphaman added a comment. Simplified the implementation of `LexicallyOrderedRecursiveASTVisitor` and removed redundant DenseMap checks. Ping. Repository: rL LLVM https://reviews.llvm.org/D35012 Files:

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

kfunk added a comment. Seems to have worked: Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ... A test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml A test/clang-apply-replacements/invalid-files.cpp M

[PATCH] D35796: [analyzer] Misused polymorphic object checker

NoQ added a comment. It seems that this check is more powerful because it works by knowing the dynamic type of the object. However, i still suspect that `-Wnon-virtual-dtor` (the other one, without `delete-`, that simply asks to make the destructor of polymorphic classes virtual) covers most

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked 16 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/Builtins.def:713 +ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t") +ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t") + Anastasia wrote: > What about

[clang-tools-extra] r308974 - [clang-tidy] clang-apply-replacements: Don't insert null entry

Author: kfunk Date: Tue Jul 25 07:28:16 2017 New Revision: 308974 URL: http://llvm.org/viewvc/llvm-project?rev=308974=rev Log: [clang-tidy] clang-apply-replacements: Don't insert null entry Summary: [clang-tidy] clang-apply-replacements: Don't insert null entry Fix crash when running

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/Builtins.def:713 +ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t") +ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t") + b-sumner wrote: > yaxunl wrote: >

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Do you need someone to commit the patch for you? https://reviews.llvm.org/D35194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35624: Removal of microMIPS64R6

abeserminji updated this revision to Diff 108067. abeserminji added a comment. Comments resolved and patch adapted to current revision. Repository: rL LLVM https://reviews.llvm.org/D35624 Files: Basic/Targets/Mips.cpp clang/Basic/DiagnosticCommonKinds.td Index: Basic/Targets/Mips.cpp

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 108073. yaxunl marked 16 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a reviewer: kzhuravl. yaxunl added a comment. Herald added a subscriber: nhaehnle. Rebased to ToT and revised by Anastasia's comments.

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

b-sumner added inline comments. Comment at: include/clang/Basic/Builtins.def:713 +ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t") +ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t") + yaxunl wrote: > Anastasia wrote: > > What about min/max? I believe they

[PATCH] D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry

This revision was automatically updated to reflect the committed changes. Closed by commit rL308974: [clang-tidy] clang-apply-replacements: Don't insert null entry (authored by kfunk). Repository: rL LLVM https://reviews.llvm.org/D35194 Files:

[PATCH] D35796: [analyzer] Misused polymorphic object checker

aaron.ballman added a comment. How does this check differ from the `-Wdelete-non-virtual-dtor` warning class that comes out of the frontend? https://reviews.llvm.org/D35796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33672#819683, @xazax.hun wrote: > Aaron, could you comment on the applicability of this check to C? Thanks in > advance. C has different rules for their enumerations in that the enumerators are all ints, but the enumeration type is

[PATCH] D35624: Removal of microMIPS64R6

sdardis added a reviewer: cfe-commits. sdardis added a comment. Also, this need to be posted to cfe-commits. Repository: rL LLVM https://reviews.llvm.org/D35624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r308975 - [clang-tidy] Fixup clang-apply-replacements/invalid-files test

Author: kfunk Date: Tue Jul 25 07:39:08 2017 New Revision: 308975 URL: http://llvm.org/viewvc/llvm-project?rev=308975=rev Log: [clang-tidy] Fixup clang-apply-replacements/invalid-files test Modified: clang-tools-extra/trunk/test/clang-apply-replacements/invalid-files.cpp Modified:

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added a comment. In https://reviews.llvm.org/D32210#819577, @ahatanak wrote: > In https://reviews.llvm.org/D32210#810508, @rjmccall wrote: > > > Hmm. Unfortunately, I'm not sure that's valid. The retains and releases > > of block captures don't protect against anything related to

[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

peter.smith updated this revision to Diff 108092. peter.smith added a comment. Herald added a subscriber: javed.absar. I've added a clang test that will check that none of the floating point helper functions defined in the Runtime ABI for the ARM Architecture are directly called by clang. Given

r308990 - [analyzer] Add diagnostic text for generalized refcount annotations.

Author: dcoughlin Date: Tue Jul 25 10:17:09 2017 New Revision: 308990 URL: http://llvm.org/viewvc/llvm-project?rev=308990=rev Log: [analyzer] Add diagnostic text for generalized refcount annotations. Add a 'Generalized' object kind to the retain-count checker and suitable generic diagnostic text

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added a comment. Hi Bruno, Yes, GCC has similar option (-mtp=soft/hard), but name is not same. I put the same option name as in backend (https://reviews.llvm.org/D34408). https://reviews.llvm.org/D34878 ___ cfe-commits mailing list

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

dcoughlin added a comment. I will commit. Repository: rL LLVM https://reviews.llvm.org/D35613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Sorry for the delay! This looks good to me. We have a really embarrassing FIXMELATER from 2012 (!!!) that disabled the plist tests for diagnostics. This means we're not getting testing

[PATCH] D35674: [analyzer] Treat C++ throw as sink during CFG-based suppress-on-sink.

dcoughlin added a comment. Do we have a radar for this? It sounds familiar. Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp:3313 +static bool isNoReturnBlock(const CFGBlock *Blk) { + if (Blk->hasNoReturnElement()) Maybe a better name for this

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

GorNishanov updated this revision to Diff 108111. GorNishanov added a comment. Thank you for the review. Feedback implemented. Preparing to land https://reviews.llvm.org/D35383 Files: include/clang/AST/StmtCXX.h include/clang/Serialization/ASTBitCodes.h lib/AST/StmtCXX.cpp

[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL308990: [analyzer] Add diagnostic text for generalized refcount annotations. (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D35613?vs=107471=108115#toc Repository: rL

Re: r308897 - Work around an MSVC2017 update 3 codegen bug.

r308988. Thanks! On Mon, Jul 24, 2017 at 9:55 AM, Nico Weber wrote: > We probably want this in 5.0. > > On Mon, Jul 24, 2017 at 12:54 PM, Nico Weber via cfe-commits > wrote: >> >> Author: nico >> Date: Mon Jul 24 09:54:11 2017 >> New Revision:

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

Quuxplusone added inline comments. Comment at: test/CodeGenCXX/std-byte.cpp:7 +enum byte : unsigned char {}; +} + Would it be worth adding an explicit test that `::byte`, `::my::byte`, `::my::std::byte` are or are not handled in the same way?

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This seems reasonable to me. Comment at: lib/Driver/ToolChain.cpp:660 + assert(!Args.hasArg(options::OPT_nostdlibxx) && + "should not have called this");

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

bruno added a comment. If there's a precedence for a flag name there, it's nice to be compatible here. You don't necessarily need to use the same name as the backend. https://reviews.llvm.org/D34878 ___ cfe-commits mailing list

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

majnemer updated this revision to Diff 108105. majnemer added a comment. - Address review feedback. https://reviews.llvm.org/D35824 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/CodeGen/CodeGenTBAA.cpp test/CodeGenCXX/std-byte.cpp Index: test/CodeGenCXX/std-byte.cpp

r308985 - This test case is causing all PPC and SystemZ bots to remain red.

Author: nemanjai Date: Tue Jul 25 10:04:12 2017 New Revision: 308985 URL: http://llvm.org/viewvc/llvm-project?rev=308985=rev Log: This test case is causing all PPC and SystemZ bots to remain red. Notifying the author via Diffusion did not yield any answer. Therefore, I'm adding the missing

r308979 - [OPENMP] Codegen for 'task_reduction' clause.

Author: abataev Date: Tue Jul 25 08:53:26 2017 New Revision: 308979 URL: http://llvm.org/viewvc/llvm-project?rev=308979=rev Log: [OPENMP] Codegen for 'task_reduction' clause. Added codegen for taskgroup directive with task_reduction clause. ``` ``` The next code is emitted: ```

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. In https://reviews.llvm.org/D34030#819699, @MontyKutyi wrote: > As I can see the `clang/test` contains a lot of different simple tests, but > for testing this I think it is not enough to run the clang with some > arguments on a specific input. So I should create a new

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

euhlmann created this revision. euhlmann added a project: clang. Change 272124* introduced a regression in spaceRequiredBetween for left aligned pointers to decltype and typeof expressions. This fix adds logic to fix this. The test added is based on a related test in determineStarAmpUsage. Also

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

kzhuravl added a comment. Seems like SyncScope.h file is missing? https://reviews.llvm.org/D28691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

thakis closed this revision. thakis added a comment. r308997, thanks! https://reviews.llvm.org/D35780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

The test also fails on many other bots on http://lab.llvm.org:8011/console , a short excerpt: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/9702/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ax86-ms-inline-asm-enum_feature.cpp

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Otherwise this looks good to me. Comment at: examples/clang-interpreter/CMakeLists.txt:73 +set_property(TARGET ${TARGET} PROPERTY COMPILE_FLAGS ${editedFlags}) +

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

vsk added a reviewer: vsk. vsk added a comment. This won't do the right thing if more than one sanitizer with a default blacklist is enabled. It's also problematic that a default blacklist for one sanitizer can blacklist code for a different sanitizer. See: https://reviews.llvm.org/D32043

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

shenhan created this revision. This is to provide a default blacklist filename for UBSan. While UBSan is turned on, it's better that clang pick up a blacklist file (when exists), just as what ASan / MSan does, so we do not end up adding the "-fsanitize-blacklist" option to every command line.

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked an inline comment as done. yaxunl added a comment. In https://reviews.llvm.org/D28691#820375, @kzhuravl wrote: > Seems like SyncScope.h file is missing? Right. I will add it. https://reviews.llvm.org/D28691 ___ cfe-commits mailing

r308996 - [coroutines] Add serialization/deserialization of coroutines

Author: gornishanov Date: Tue Jul 25 11:01:49 2017 New Revision: 308996 URL: http://llvm.org/viewvc/llvm-project?rev=308996=rev Log: [coroutines] Add serialization/deserialization of coroutines Reviewers: rsmith Reviewed By: rsmith Subscribers: EricWF, cfe-commits Differential Revision:

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl added a comment. In https://reviews.llvm.org/D28691#820466, @b-sumner wrote: > Can we drop the "opencl" part of the name and use something like > __scoped_atomic_*? Also, it may not make sense to support non-constant > scope here since we can't predict what other scopes may be added

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 108127. yaxunl added a comment. Add min/max and missing file. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote: > If you need this behavior for something, that sounds like something a > -nodefaultlibs++ could do. -nostdlib++ is really meant to disable the c++ > stdlib and nothing else. But the -lm is only there because -lc++ alone

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

majnemer updated this revision to Diff 108166. majnemer added a comment. - Address review comments https://reviews.llvm.org/D35824 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/CodeGen/CodeGenTBAA.cpp test/CodeGenCXX/std-byte.cpp Index: test/CodeGenCXX/std-byte.cpp

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. This fixes compiling with headers from the Windows SDK for ARM64. https://reviews.llvm.org/D35862 Files: lib/Headers/armintr.h Index: lib/Headers/armintr.h

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a tweaked comment. Thanks! Comment at: lib/CodeGen/CodeGenTBAA.cpp:88-90 + // C++1z [intro.object]p3: If a complete object is created in storage + // associated

Re: r309036 - [StaticAnalyzer] LoopUnrolling - Attempt to fix a crash in r309006.

Looks like one more failure (this time under ubsan) remains in this code http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6708/steps/check-clang%20ubsan/logs/stdio Please fix asap.

r309052 - clang/StaticAnalyzer/Core/PathSensitive/LoopUnrolling.h: Add a forward decl AnalysisManager, to unbreak modules build.

Author: chapuni Date: Tue Jul 25 16:23:17 2017 New Revision: 309052 URL: http://llvm.org/viewvc/llvm-project?rev=309052=rev Log: clang/StaticAnalyzer/Core/PathSensitive/LoopUnrolling.h: Add a forward decl AnalysisManager, to unbreak modules build. Modified:

r309054 - Reorder tests to match latest SD-6 draft.

Author: rsmith Date: Tue Jul 25 16:31:42 2017 New Revision: 309054 URL: http://llvm.org/viewvc/llvm-project?rev=309054=rev Log: Reorder tests to match latest SD-6 draft. Modified: cfe/trunk/test/Lexer/cxx-features.cpp Modified: cfe/trunk/test/Lexer/cxx-features.cpp URL:

[PATCH] D35824: [Sema] Implicitly apply the may_alias attribute to std::byte

This revision was automatically updated to reflect the committed changes. Closed by commit rL309058: [CodeGen] Correctly model std::byte's aliasing properties (authored by majnemer). Changed prior to commit: https://reviews.llvm.org/D35824?vs=108166=108185#toc Repository: rL LLVM

r309058 - [CodeGen] Correctly model std::byte's aliasing properties

Author: majnemer Date: Tue Jul 25 16:33:58 2017 New Revision: 309058 URL: http://llvm.org/viewvc/llvm-project?rev=309058=rev Log: [CodeGen] Correctly model std::byte's aliasing properties std::byte, when defined as an enum, needs to be given special treatment with regards to its aliasing

Re: r309058 - [CodeGen] Correctly model std::byte's aliasing properties

Should this go into 5.0 ? On Tue, Jul 25, 2017 at 4:33 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Tue Jul 25 16:33:58 2017 > New Revision: 309058 > > URL: http://llvm.org/viewvc/llvm-project?rev=309058=rev > Log: > [CodeGen] Correctly model

r309061 - [StaticAnalyzer] LoopUnrolling - Attempt #2 to fix a crash in r309006.

Author: szepet Date: Tue Jul 25 16:49:16 2017 New Revision: 309061 URL: http://llvm.org/viewvc/llvm-project?rev=309061=rev Log: [StaticAnalyzer] LoopUnrolling - Attempt #2 to fix a crash in r309006. Modified: cfe/trunk/lib/StaticAnalyzer/Core/LoopUnrolling.cpp Modified:

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

lebedev.ri added a comment. How does this relate to the gcc behavior? I suspect not everyone would want to have this relaxed `-Wshadow` mode. Perhaps it could be hidden under some new flag, which is not going to be automatically enabled by `-Weverything`. Like, `-Wshadow-in-macros` which does

Re: [PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

I've reverted this and Nemanja's attempt at fixing in: echristo@athyra ~/s/l/t/clang> git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... D test/CodeGen/x86-ms-inline-asm-enum_feature.cpp M lib/Sema/SemaStmtAsm.cpp M test/CodeGen/ms-inline-asm.c M

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. In https://reviews.llvm.org/D28691#820489, @yaxunl wrote: > In https://reviews.llvm.org/D28691#820466, @b-sumner wrote: > > > Can we drop the "opencl" part of the name and use something like > > __scoped_atomic_*? Also, it may not make sense to support non-constant

r309014 - [ExternalASTMerger] Import Objective-C classes

Author: spyffe Date: Tue Jul 25 12:54:22 2017 New Revision: 309014 URL: http://llvm.org/viewvc/llvm-project?rev=309014=rev Log: [ExternalASTMerger] Import Objective-C classes This patch adds functionality and a test for importing Objective-C classes and their methods. It also adds a flag to

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. In https://reviews.llvm.org/D28691#820541, @b-sumner wrote: > There are other languages for heterogeneous compute that have scopes, > although not exposed quite as explicitly as OpenCL. For example AMD's "HC" > language. And any language making use of clang and

Re: [PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

And this: echristo@athyra ~/s/llvm> git svn dcommit Committing to https://llvm.org/svn/llvm-project/llvm/trunk ... M include/llvm/MC/MCParser/MCAsmParser.h M lib/Target/X86/AsmParser/X86AsmParser.cpp Committed r309005 On Tue, Jul 25, 2017 at 12:18 PM Eric Christopher

[PATCH] D35736: [ubsan] -fsanitize=vptr now requires -fsanitize=null, update tests

vsk closed this revision. vsk added a comment. Thanks! This landed in r309008. https://reviews.llvm.org/D35736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

vsk marked an inline comment as done. vsk added a comment. I made the suggested test changes and updated the release notes: r309007 Repository: rL LLVM https://reviews.llvm.org/D35735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

b-sumner added a comment. In https://reviews.llvm.org/D28691#820526, @rjmccall wrote: > In https://reviews.llvm.org/D28691#820489, @yaxunl wrote: > > > In https://reviews.llvm.org/D28691#820466, @b-sumner wrote: > > > > > Can we drop the "opencl" part of the name and use something like > > >

r309018 - Fix a bot by linking clang-import-test against libclangDriver

Author: spyffe Date: Tue Jul 25 13:09:30 2017 New Revision: 309018 URL: http://llvm.org/viewvc/llvm-project?rev=309018=rev Log: Fix a bot by linking clang-import-test against libclangDriver Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt Modified:

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

shenhan added a comment. Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include "ubsan_blacklist.txt"? https://reviews.llvm.org/D32842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r309004 - Revert "This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements." as it is causing msan failures.

Author: echristo Date: Tue Jul 25 12:17:32 2017 New Revision: 309004 URL: http://llvm.org/viewvc/llvm-project?rev=309004=rev Log: Revert "This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements." as it is causing msan failures. This reverts

[PATCH] D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309007: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D35735?vs=107741=108133#toc Repository: rL LLVM

[PATCH] D35729: [Frontend] - Mark some ASTUnit methods as const

This revision was automatically updated to reflect the committed changes. Closed by commit rL309013: [Frontend] Mark some ASTUnit methods as const. NFC. (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D35729?vs=107689=108138#toc Repository: rL LLVM

Re: [PATCH] D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library.

On Tue, Jul 25, 2017 at 2:53 PM, Joerg Sonnenberger wrote: > On Sun, Jul 23, 2017 at 07:06:25PM -0400, Nico Weber via cfe-commits wrote: > > If you need this behavior for something, that sounds like something a > > -nodefaultlibs++ could do. -nostdlib++ is really meant to disable

r309006 - [StaticAnalyzer] Completely unrolling specific loops with known bound option

Author: szepet Date: Tue Jul 25 12:23:23 2017 New Revision: 309006 URL: http://llvm.org/viewvc/llvm-project?rev=309006=rev Log: [StaticAnalyzer] Completely unrolling specific loops with known bound option This feature allows the analyzer to consider loops to completely unroll. New

r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

Author: vedantk Date: Tue Jul 25 12:34:23 2017 New Revision: 309007 URL: http://llvm.org/viewvc/llvm-project?rev=309007=rev Log: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881) The instrumentation generated by -fsanitize=vptr does not null check a user pointer before loading from it.

  1   2   >