[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

Anastasia added a comment. In https://reviews.llvm.org/D28691#820684, @rjmccall wrote: > In https://reviews.llvm.org/D28691#820641, @b-sumner wrote: > > > In https://reviews.llvm.org/D28691#820595, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D28691#820541, @b-sumner wrote: > > > > > >

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi updated this revision to Diff 108626. MontyKutyi added a comment. I run the clang-format with -style=llvm on the added code parts. https://reviews.llvm.org/D34030 Files: include/clang/AST/RecursiveASTVisitor.h unittests/AST/PostOrderASTVisitor.cpp Index:

r309383 - Strip trailing whitespace. NFCI.

Author: rksimon Date: Fri Jul 28 07:01:51 2017 New Revision: 309383 URL: http://llvm.org/viewvc/llvm-project?rev=309383=rev Log: Strip trailing whitespace. NFCI. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h URL:

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz updated this revision to Diff 108651. Typz added a comment. Rebase https://reviews.llvm.org/D33589 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108620. yvvan added a comment. Provide a workaround without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp === ---

[PATCH] D35986: [clangd] Add ':' to completion trigger characters.

ilya-biryukov created this revision. Without it we don't get completion requests from VSCode after nested name qualifiers (e.g. after 'std::'). https://reviews.llvm.org/D35986 Files: clangd/ClangdLSPServer.cpp Index: clangd/ClangdLSPServer.cpp

[clang-tools-extra] r309378 - [clangd] Workaround for a test failure on Windows.

Author: ibiryukov Date: Fri Jul 28 05:25:51 2017 New Revision: 309378 URL: http://llvm.org/viewvc/llvm-project?rev=309378=rev Log: [clangd] Workaround for a test failure on Windows. Previous workaround (r308959) didn't account for a case when system drive letter is not 'C:'. Modified:

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:34 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through instance [readability-static-accessed-through-instance] + // CHECK-FIXES: {{^}}

[clang-tools-extra] r309380 - [clang-tidy] Expand readability-redundant-function-ptr-dereference test

Author: alexfh Date: Fri Jul 28 05:46:08 2017 New Revision: 309380 URL: http://llvm.org/viewvc/llvm-project?rev=309380=rev Log: [clang-tidy] Expand readability-redundant-function-ptr-dereference test Modified:

[clang-tools-extra] r309379 - [clang-tidy] readability-redundant-declaration: ignore friends and macros

Author: alexfh Date: Fri Jul 28 05:46:02 2017 New Revision: 309379 URL: http://llvm.org/viewvc/llvm-project?rev=309379=rev Log: [clang-tidy] readability-redundant-declaration: ignore friends and macros Added:

RE: [PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added a comment. Hmm... I tried this patch and now the following worries me: - it passes -finclude-if-exists stdc-predef.h on all platforms (say, including my Solaris platform that has no system stdc-predef.h) - it searches all the paths, not just "system include" ones That

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg under the precondition that clang-tidy tests still work. https://reviews.llvm.org/D27104 ___ cfe-commits mailing list

r309382 - [X86] Add tests showing inability of vector non-temporal load/store intrinsic to force pointer alignment (PR33830)

Author: rksimon Date: Fri Jul 28 06:47:02 2017 New Revision: 309382 URL: http://llvm.org/viewvc/llvm-project?rev=309382=rev Log: [X86] Add tests showing inability of vector non-temporal load/store intrinsic to force pointer alignment (PR33830) Clang specifies a max type alignment of 16 bytes on

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 108644. m.ostapenko added a comment. Updated some comments. Could someone take a look please? Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h

[PATCH] D35996: [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

RKSimon created this revision. Clang specifies a max type alignment of 16 bytes on darwin targets (annoyingly in the driver not via cc1), meaning that the builtin nontemporal stores don't correctly align the loads/stores to 32 or 64 bytes when required, resulting in lowering to temporal

[PATCH] D35925: [Coverage] Precise region termination with deferred regions

arphaman added a comment. This is awesome! I noticed in the sample output that llvm-cov is now forced to print some new region markers because the terminator introduces a new region on the same line, e.g. |// CHECK-LABEL: _Z10while_loopv: 88| 1|void while_loop() { 89| 1|

Re: [PATCH] D34158: For standards compatibility, preinclude if the file is available

On Fri, Jul 28, 2017 at 02:07:29PM +, Blower, Melanie wrote: > > > fedor.sergeev added a comment. > > Hmm... I tried this patch and now the following worries me: > > - it passes -finclude-if-exists stdc-predef.h on all platforms (say, > including my Solaris platform that has no system

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#824079, @jyknight wrote: > In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote: > > > Hmm... I tried this patch and now the following worries me: > > > > - it passes -finclude-if-exists stdc-predef.h on all platforms

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. @erichkeane contacted me offline and pointed out I'm twine-ing with " not <. i'm planning to change the option name from "finclude if exists" to "fsystem include if exists", then i'll quote with < not ". hope to get this updated

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. dim: Does putting the target listing behind a different flag work for you? Which problem are you trying to solve here? https://reviews.llvm.org/D33900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34158: For standards compatibility, preinclude if the file is available

jyknight added a comment. In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote: > Hmm... I tried this patch and now the following worries me: > > - it passes -finclude-if-exists stdc-predef.h on all platforms (say, > including my Solaris platform that has no system stdc-predef.h)

r309386 - Recommit r308327 3rd time: Add a warning for missing

Author: arphaman Date: Fri Jul 28 07:41:21 2017 New Revision: 309386 URL: http://llvm.org/viewvc/llvm-project?rev=309386=rev Log: Recommit r308327 3rd time: Add a warning for missing '#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files The second recommit (r309106) was

Re: r309106 - Recommit r308327 2nd time: Add a warning for missing

Thanks, I recommitted it in r309386. On 27 July 2017 at 15:53, Hans Wennborg wrote: > On Thu, Jul 27, 2017 at 3:41 AM, Alex L wrote: > > > > > > On 26 July 2017 at 22:32, Hans Wennborg wrote: > >> > >> On Wed, Jul 26, 2017 at 11:27 AM,

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. In https://reviews.llvm.org/D28691#823810, @Anastasia wrote: > In https://reviews.llvm.org/D28691#820684, @rjmccall wrote: > > > In https://reviews.llvm.org/D28691#820641, @b-sumner wrote: > > > > > In https://reviews.llvm.org/D28691#820595, @rjmccall wrote: > > > > > >

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

Quuxplusone accepted this revision. Quuxplusone added a comment. > But if I'm overseeing reasons to issue a warning in this case, we could add > an analogue of `-Wshadow-uncaptured-local` for this case. WDYT? I still think "any warning" is a marginally better UX than "no warning" on the

RE: [PATCH] D34158: For standards compatibility, preinclude if the file is available

jyknight added a comment. In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote: > Hmm... I tried this patch and now the following worries me: > > - it passes -finclude-if-exists stdc-predef.h on all platforms (say, > including my Solaris platform that has no system stdc-predef.h)

r309390 - [CMake] NFC. Add clang-tablegen-targets utility target

Author: cbieneman Date: Fri Jul 28 08:33:47 2017 New Revision: 309390 URL: http://llvm.org/viewvc/llvm-project?rev=309390=rev Log: [CMake] NFC. Add clang-tablegen-targets utility target By creating this target other projects that depend on clang-generated headers (like LLDB) will no longer be

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

chh added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1887 +// greater than the one after packing. +if (Packed && UnpackedAlignment <= Alignment) Diag(D->getLocation(), diag::warn_unnecessary_packed) chh wrote: > With this change,

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added inline comments. Comment at: include/clang/Basic/SyncScope.h:1 +//===--- SyncScope.h - atomic synchronization scopes *- C++ -*-===// +// Capitalization. Comment at: include/clang/Basic/SyncScope.h:20 + +namespace

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

rnk added inline comments. Comment at: lib/AST/ExprConstant.cpp:583 +uint64_t& GetArrayInitIndex() { +return reinterpret_cast(ArrayInitIndex[0]); +} Surely this will fault on SPARC or ARM or other ISAs that care about alignment?

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

t.p.northover added inline comments. Comment at: lib/AST/ExprConstant.cpp:583 +uint64_t& GetArrayInitIndex() { +return reinterpret_cast(ArrayInitIndex[0]); +} rnk wrote: > Surely this will fault on SPARC or ARM or other ISAs that care

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

baloghadamsoftware added inline comments. Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:34 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through instance [readability-static-accessed-through-instance] + // CHECK-FIXES:

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

baloghadamsoftware added a comment. I am not sure whether we should copy with such ugly things as overloaded member access operators with side effects, but they can also cause troubles using this fix: #include using std::cout; using std::endl; struct C { static int N;

[PATCH] D35483: clang-format: fix block OpeningLineIndex around preprocessor

This revision was automatically updated to reflect the committed changes. Closed by commit rL309369: clang-format: fix block OpeningLineIndex around preprocessor (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D35483?vs=107843=108598#toc Repository: rL LLVM

[PATCH] D35557: clang-format: merge short case labels with trailing comments

This revision was automatically updated to reflect the committed changes. Closed by commit rL309370: clang-format: merge short case labels with trailing comments (authored by Typz). Repository: rL LLVM https://reviews.llvm.org/D35557 Files: cfe/trunk/lib/Format/UnwrappedLineFormatter.cpp

r309369 - clang-format: fix block OpeningLineIndex around preprocessor

Author: typz Date: Fri Jul 28 00:56:14 2017 New Revision: 309369 URL: http://llvm.org/viewvc/llvm-project?rev=309369=rev Log: clang-format: fix block OpeningLineIndex around preprocessor Summary: The current code would return an incorrect value when a preprocessor directive is present

r309370 - clang-format: merge short case labels with trailing comments

Author: typz Date: Fri Jul 28 00:56:18 2017 New Revision: 309370 URL: http://llvm.org/viewvc/llvm-project?rev=309370=rev Log: clang-format: merge short case labels with trailing comments Summary: Allow merging short case labels when they actually end with a comment (like a comment after the

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

xazax.hun added inline comments. Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:34 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through instance [readability-static-accessed-through-instance] + // CHECK-FIXES: {{^}}

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

abeserminji created this revision. Herald added a subscriber: arichardson. In patch https://reviews.llvm.org/D3274 using abs.[ds] instruction is forced, as they should behave in accordance with flags Has2008 and ABS2008. Unfortunately for revisions prior mips32r6 and mips64r6, abs.[ds] is not

[PATCH] D35932: [clang-tidy] Add integer division check

rnkovacs updated this revision to Diff 108605. rnkovacs edited the summary of this revision. https://reviews.llvm.org/D35932 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/IntegerDivisionCheck.cpp

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

klimek updated this revision to Diff 108608. klimek added a comment. Update to handle hasDeclaration for type alias template decls. https://reviews.llvm.org/D27104 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

baloghadamsoftware added inline comments. Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:34 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through instance [readability-static-accessed-through-instance] + // CHECK-FIXES:

[PATCH] D35932: [clang-tidy] Add integer division check

rnkovacs added a comment. I run the check on LLVM-Clang, and got this one hit: /home/reka/codechecker_dev_env/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:1000:43: warning: integer division; possible precision loss [bugprone-integer-division] SDValue TWOHW = DAG.getConstantFP(1 <<

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

klimek added a reviewer: bkramer. klimek added a comment. Adding Ben as reviewer. https://reviews.llvm.org/D27104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35948: [CommonOptionsParser] Expose ArgumentsAdjustingCompilationDatabase

arphaman added a comment. This looks fine to me, just an NFC move. @klimek , is this change ok with you? https://reviews.llvm.org/D35948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > Another data point is that GCC doesn't warn in this case. That seems like a reasonable tie breaker when implementing these kinds of style-enforcement warnings. :)

[PATCH] D35996: [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r309112 - [Bash-completion] Fixed a bug that file doesn't autocompleted after =

Merged to 5.0 in r309435. On Wed, Jul 26, 2017 at 6:30 AM, Yuka Takahashi via cfe-commits wrote: > Author: yamaguchi > Date: Wed Jul 26 06:30:36 2017 > New Revision: 309112 > > URL: http://llvm.org/viewvc/llvm-project?rev=309112=rev > Log: > [Bash-completion] Fixed a

Re: r309113 - [Bash-autocompletion] Show HelpText with possible flags

Merged to 5.0 in r309438. On Wed, Jul 26, 2017 at 6:36 AM, Yuka Takahashi via cfe-commits wrote: > Author: yamaguchi > Date: Wed Jul 26 06:36:58 2017 > New Revision: 309113 > > URL: http://llvm.org/viewvc/llvm-project?rev=309113=rev > Log: > [Bash-autocompletion] Show

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

vsk edited reviewers, added: eugenis; removed: efriedma. vsk added a comment. Ping. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commit adds support for syscalls that acquire/release handles in an array for MagentaHandleChecker introduced in https://reviews.llvm.org/D35968 and https://reviews.llvm.org/D36022. Most magenta handle related syscalls

[PATCH] D35959: Summary: For powerpc64, disable tests that assume long double is 80-bits.

saugustine updated this revision to Diff 108727. saugustine added a comment. Herald added subscribers: aheejin, mgorny. - Add clear_cache implementation for ppc64. Fix buffer to meet ppc64 alignment. - Merge branch 'master' of https://github.com/llvm-project/llvm-project-20170507 - Merge branch

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commits add actual code for analyzing magenta handle misuse issues to MagentaHandleChecker, which is introduced in https://reviews.llvm.org/D35968. It supports magenta syscalls that acquires/release/use handle through

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

jtbandes created this revision. Herald added a subscriber: klimek. This fixes a bug in `ENAS_DontAlign` (introduced in https://reviews.llvm.org/D32733) where blank lines had an EscapedNewlineColumn of 0, causing a subtraction to overflow when converted back to `unsigned` and leading to runaway

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commit improves the bug reporting of MagentaHandleChecker introduced in https://reviews.llvm.org/D35968 , https://reviews.llvm.org/D36022 and https://reviews.llvm.org/D36023. After this commit, the allocation and release

[PATCH] D36013: Fix logic for generating llvm.type.test()s

vlad.tsyrklevich created this revision. `CodeGenFunction::EmitTypeMetadataCodeForVCall()` could output an `llvm.assume(llvm.type.test())`when CFI was enabled, optimizing out the vcall check. This case was only reached when: 1) CFI-vcall was enabled, 2) -fwhole-program-tables was specified, and

[PATCH] D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D36016 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h test/clang-tidy/modernize-make-unique.cpp Index:

[PATCH] D36013: Fix logic for generating llvm.type.test()s

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGenCXX/cfi-vcall-no-trap.cpp:2 +// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and whole-program-vtables is enabled +// RUN:

r309427 - Adopt to LLVM API change (llvm.dbg.value no longer has an offset)

Author: adrian Date: Fri Jul 28 13:21:08 2017 New Revision: 309427 URL: http://llvm.org/viewvc/llvm-project?rev=309427=rev Log: Adopt to LLVM API change (llvm.dbg.value no longer has an offset) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D36013: Fix logic for generating llvm.type.test()s

vlad.tsyrklevich updated this revision to Diff 108702. vlad.tsyrklevich marked 2 inline comments as done. https://reviews.llvm.org/D36013 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/cfi-vcall-no-trap.cpp Index: test/CodeGenCXX/cfi-vcall-no-trap.cpp

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108665. yawanng marked 3 inline comments as done. https://reviews.llvm.org/D34114 Files: lib/AST/RecordLayoutBuilder.cpp test/CodeGenCXX/warn-padded-packed.cpp Index: test/CodeGenCXX/warn-padded-packed.cpp

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

chh added a comment. LGTM. rsmith, srhines, akyrtzi, rtrieu, do you have any comment? https://reviews.llvm.org/D34114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial marked 3 inline comments as done. marsupial added a comment. Done, thanks. Would it be possible to look at https://reviews.llvm.org/D30709 as this depends on that. (ELF does not like Windows exceptions). https://reviews.llvm.org/D35103

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

On Fri, Jul 28, 2017 at 10:24 AM Kevin Enderby wrote: > On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator < > revi...@reviews.llvm.org> wrote: > > compnerd added a comment. > > Does anyone use the overload with the `O` for `exports` with `nullptr` > instead of

[PATCH] D33900: Print registered targets in clang's version information

dim added a comment. In https://reviews.llvm.org/D33900#824172, @thakis wrote: > dim: Does putting the target listing behind a different flag work for you? > Which problem are you trying to solve here? I'm fine with a different flag. For the problem I was trying to solve, see my earlier

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial updated this revision to Diff 108676. marsupial added a comment. Use include guards, not pragma once and remove commented CMake debug lines. https://reviews.llvm.org/D35103 Files: examples/clang-interpreter/CMakeLists.txt examples/clang-interpreter/Invoke.cpp

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

> On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator > wrote: > > compnerd added a comment. > > Does anyone use the overload with the `O` for `exports` with `nullptr` > instead of `this`? If not, we could just inline `this` throughout. This will break

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi updated this revision to Diff 108678. MontyKutyi added a comment. Did the renamings. https://reviews.llvm.org/D34030 Files: include/clang/AST/RecursiveASTVisitor.h unittests/AST/PostOrderASTVisitor.cpp Index: unittests/AST/PostOrderASTVisitor.cpp

Re: [PATCH] D33900: Print registered targets in clang's version information

Cool, then let's revert this and add it back under a different flag. Thanks! On Fri, Jul 28, 2017 at 1:37 PM, Dimitry Andric via Phabricator via cfe-commits wrote: > dim added a comment. > > In https://reviews.llvm.org/D33900#824172, @thakis wrote: > > > dim: Does

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108669. mibintc added a comment. Here's an updated patch which is using angle brackets to do the include, so the search for stdc-predef.h is limited to system directories. Also my previous revision was missing the new test cases since i had gotten a new

[PATCH] D35925: [Coverage] Precise region termination with deferred regions

vsk added a comment. In https://reviews.llvm.org/D35925#823978, @arphaman wrote: > This is awesome! > > I noticed in the sample output that llvm-cov is now forced to print some new > region markers because the terminator introduces a new region on the same > line, e.g. > > |// CHECK-LABEL:

r309407 - [CMake] Add Android toolchain CMake cache files.

Author: aoli Date: Fri Jul 28 10:40:28 2017 New Revision: 309407 URL: http://llvm.org/viewvc/llvm-project?rev=309407=rev Log: [CMake] Add Android toolchain CMake cache files. Summary: Thoes files are used to build Android toolchain. D32816 makes it possible to build runtimes for targets.

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

> On Jul 28, 2017, at 10:30 AM, David Blaikie wrote: > > > > On Fri, Jul 28, 2017 at 10:24 AM Kevin Enderby > wrote: >> On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator >>

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

On Fri, Jul 28, 2017 at 4:01 PM Kevin Enderby wrote: > On Jul 28, 2017, at 10:30 AM, David Blaikie wrote: > > > > On Fri, Jul 28, 2017 at 10:24 AM Kevin Enderby wrote: > >> On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator

Re: r309386 - Recommit r308327 3rd time: Add a warning for missing

On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits wrote: > Author: arphaman > Date: Fri Jul 28 07:41:21 2017 > New Revision: 309386 > > URL: http://llvm.org/viewvc/llvm-project?rev=309386=rev > Log: > Recommit r308327 3rd time: Add a warning for missing >

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309459: [ubsan] Diagnose invalid uses of builtins (clang) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34590?vs=103827=108753#toc Repository: rL LLVM

[PATCH] D34591: [ubsan] Diagnose invalid uses of builtins (compiler-rt)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309461: [ubsan] Diagnose invalid uses of builtins (compiler-rt) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34591?vs=103828=108754#toc Repository: rL LLVM

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

Looks fine to me. Kev > On Jul 28, 2017, at 3:49 PM, Alexander Shaposhnikov > wrote: > > Hi, > many thanks for looking at the diff. > (i started working on this because this interface change broke some > out-of-tree code, but that's expected and not a big

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

dcoughlin requested changes to this revision. dcoughlin added a comment. This revision now requires changes to proceed. Artem, Anna, and I discussed this a bit in person. We think that even though the benefits look great, it can't be generally applied. Maybe we could apply it in cases where

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35693: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions

ahatanak added a comment. In https://reviews.llvm.org/D35693#816994, @rjmccall wrote: > Does the ARM64 ABI call for unwind tables to be emitted for all functions, > like the x86-64 ABI does? > > Anyway, it seems pretty unfortunate that the default behavior breaks > exceptions. According to

[PATCH] D35923: Fix PR32332 - PCM nondeterminism with builtins caused by global module index

aprantl added a comment. After thinking about this some more, I think it should be safe to use the global module index as a negative cache like in this example. The conditions under which a module is rebuilt should not affect the contents, and if the module were out-of-date it would have been

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

Hi, many thanks for looking at the diff. (i started working on this because this interface change broke some out-of-tree code, but that's expected and not a big issue, i just wanted to clean it up a bit). I assume I might be missing smth, however my diff doesn't change the static method /// For

r309459 - [ubsan] Diagnose invalid uses of builtins (clang)

Author: vedantk Date: Fri Jul 28 17:19:51 2017 New Revision: 309459 URL: http://llvm.org/viewvc/llvm-project?rev=309459=rev Log: [ubsan] Diagnose invalid uses of builtins (clang) On some targets, passing zero to the clz() or ctz() builtins has undefined behavior. I ran into this issue while

r309460 - [test] FileCheck-ify a test to avoid a spurious failure, NFC

Author: vedantk Date: Fri Jul 28 17:19:52 2017 New Revision: 309460 URL: http://llvm.org/viewvc/llvm-project?rev=309460=rev Log: [test] FileCheck-ify a test to avoid a spurious failure, NFC The path to one of my source trees contains 'builtin' as a substring, so this test failed. Fix it with

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. Nice! One more comment: please also fix names of local variables, member variables and function parameters. See https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly. Yes, there is precedence for violations in other places in

[libcxx] r309463 - [libcxx] [test] Strip trailing whitespace, NFC.

Author: stl_msft Date: Fri Jul 28 17:54:49 2017 New Revision: 309463 URL: http://llvm.org/viewvc/llvm-project?rev=309463=rev Log: [libcxx] [test] Strip trailing whitespace, NFC. Modified: libcxx/trunk/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan.pass.cpp

[libcxx] r309468 - [libcxx] [test] Change comments to say C++ instead of c++. NFC.

Author: stl_msft Date: Fri Jul 28 17:55:35 2017 New Revision: 309468 URL: http://llvm.org/viewvc/llvm-project?rev=309468=rev Log: [libcxx] [test] Change comments to say C++ instead of c++. NFC. This makes them consistent (many comments already used uppercase). The special REQUIRES, UNSUPPORTED,

[libcxx] r309466 - [libcxx] [test] In func.wrap.func.con/alloc_F.pass.cpp, fix REQUIRES whitespace. NFC.

Author: stl_msft Date: Fri Jul 28 17:55:25 2017 New Revision: 309466 URL: http://llvm.org/viewvc/llvm-project?rev=309466=rev Log: [libcxx] [test] In func.wrap.func.con/alloc_F.pass.cpp, fix REQUIRES whitespace. NFC. Modified:

[libcxx] r309465 - [libcxx] [test] Make files consistently end with newlines, NFC.

Author: stl_msft Date: Fri Jul 28 17:55:22 2017 New Revision: 309465 URL: http://llvm.org/viewvc/llvm-project?rev=309465=rev Log: [libcxx] [test] Make files consistently end with newlines, NFC. Modified: libcxx/trunk/test/libcxx/algorithms/debug_less.pass.cpp

[libcxx] r309467 - [libcxx] [test] The entire file futures.shared_future/wait_until.pass.cpp was indented by 1 space. NFC.

Author: stl_msft Date: Fri Jul 28 17:55:27 2017 New Revision: 309467 URL: http://llvm.org/viewvc/llvm-project?rev=309467=rev Log: [libcxx] [test] The entire file futures.shared_future/wait_until.pass.cpp was indented by 1 space. NFC. Modified:

[PATCH] D35693: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. Sounds fine to me. https://reviews.llvm.org/D35693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r309474 - [libc++] Hoist extern template above first use

Author: smeenai Date: Fri Jul 28 19:54:41 2017 New Revision: 309474 URL: http://llvm.org/viewvc/llvm-project?rev=309474=rev Log: [libc++] Hoist extern template above first use This function template is referenced inside class basic_string as a friend function. The extern template declaration

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote: