Re: r313907 - Suppress Wsign-conversion for enums with matching underlying type

On 9/21/2017 12:58 PM, Erich Keane via cfe-commits wrote: Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here:

[PATCH] D34512: Add preliminary Cross Translation Unit support library

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. > But I also think it wouldn't be good to block this until ClanD indexing > reaching a mature state. I agree 100%. > All in all, we are willing to reuse as much of ClangD indexing as

r313928 - Resubmit "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 15:16:40 2017 New Revision: 313928 URL: http://llvm.org/viewvc/llvm-project?rev=313928=rev Log: Resubmit "[lit] Refactor out some more common lit configuration code." There were two issues, one Python 3 specific related to Unicode, and another which is that the

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl added a comment. In https://reviews.llvm.org/D37822#877903, @Anastasia wrote: > In https://reviews.llvm.org/D37822#877572, @yaxunl wrote: > > > In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > > > > > In

r313945 - Add support for attribute 'noescape'.

Author: ahatanak Date: Thu Sep 21 17:41:05 2017 New Revision: 313945 URL: http://llvm.org/viewvc/llvm-project?rev=313945=rev Log: Add support for attribute 'noescape'. The attribute informs the compiler that the annotated pointer parameter of a function cannot escape and enables IRGen to attach

r313913 - [libclang] Keep track of TranslationUnit instance when annotating tokens

Author: jbcoe Date: Thu Sep 21 13:48:43 2017 New Revision: 313913 URL: http://llvm.org/viewvc/llvm-project?rev=313913=rev Log: [libclang] Keep track of TranslationUnit instance when annotating tokens Summary: Previously the `_tu` was not propagated to the returned cursor, leading to errors when

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rL313913: [libclang] Keep track of TranslationUnit instance when annotating tokens (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D36953?vs=111959=116262#toc Repository: rL

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Do you want me to commit this for you? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r313944 - [Analyzer] Log when auto-synthesized body is used.

Author: george.karpenkov Date: Thu Sep 21 17:37:12 2017 New Revision: 313944 URL: http://llvm.org/viewvc/llvm-project?rev=313944=rev Log: [Analyzer] Log when auto-synthesized body is used. Differential Revision: https://reviews.llvm.org/D37910 Modified:

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl marked 3 inline comments as done. yaxunl added a comment. In https://reviews.llvm.org/D38134#877831, @Anastasia wrote: > Now if we have a block which is being called and enqueued at the same time, > will we generate 2 functions for it? Could we add such test case btw? Yes. It is

[PATCH] D38040: [OpenMP] Add an additional test for D34888

Hahnfeld added a comment. Hi Doru, if I remember correctly I submitted https://reviews.llvm.org/D34888 for a crash when mapping a scalar value with nested regions. I've marked another test in this file that the codegen for `tofrom` is correct. So I don't know if this test checks some other

r313919 - [lit] Refactor out some more common lit configuration code.

Author: zturner Date: Thu Sep 21 14:27:31 2017 New Revision: 313919 URL: http://llvm.org/viewvc/llvm-project?rev=313919=rev Log: [lit] Refactor out some more common lit configuration code. debuginfo-tests has need to reuse a lot of common configuration from clang and lld, and in general it seems

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vsapsai > Date: Fri Sep 15 12:51:42 2017 > New Revision: 313386 > > URL: http://llvm.org/viewvc/llvm-project?rev=313386=rev > Log: > [Sema] Error out early for tags defined inside an

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

eugenis added a comment. ping https://reviews.llvm.org/D37656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32520: Support __fp16 vectors

ahatanak added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1042 +} + +assert(SrcElementTy->isFloatingPointTy() && bruno wrote: > What happens if the SrcElementTy is float and DstElementTy isn't? Seems like > it will hit the assertion

[PATCH] D32520: Support __fp16 vectors

ahatanak updated this revision to Diff 116275. ahatanak marked 8 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D32520 Files: lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/CodeGen/fp16vec-ops.c test/Sema/fp16vec-sema.c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38118: [CodeGen][ObjC] Build the global block structure before emitting the body of global block invoke functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM with one tweak. Comment at: lib/CodeGen/CGBlocks.cpp:1124 LocalDeclMap, -

RE: r313907 - Suppress Wsign-conversion for enums with matching underlying type

Fixed in 313909. -Original Message- From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Thursday, September 21, 2017 1:14 PM To: Keane, Erich ; cfe-commits@lists.llvm.org Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching underlying

r313911 - Remove svn-properties for file added in 313909 (NFC)

Author: erichkeane Date: Thu Sep 21 13:31:01 2017 New Revision: 313911 URL: http://llvm.org/viewvc/llvm-project?rev=313911=rev Log: Remove svn-properties for file added in 313909 (NFC) Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (props changed) Propchange:

[libunwind] r313920 - [libunwind] Partially revert r297174 to fix build on at least FreeBSD.

Author: jhb Date: Thu Sep 21 14:28:48 2017 New Revision: 313920 URL: http://llvm.org/viewvc/llvm-project?rev=313920=rev Log: [libunwind] Partially revert r297174 to fix build on at least FreeBSD. The changes in r297174 moved the #include of on FreeBSD (and probably other systems) inside of the

[PATCH] D38159: [clang] Fix printf fixit for objc specific types

alexshap created this revision. Let's take a look at the following example: for the triple thumbv7-apple-ios8.0.0 ssize_t is long and size_t is unsigned long, while NSInteger is int and NSUinteger is unsigned int. Following

RE: r313907 - Suppress Wsign-conversion for enums with matching underlying type

Ugg... good catch, thanks. -Original Message- From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Thursday, September 21, 2017 1:14 PM To: Keane, Erich ; cfe-commits@lists.llvm.org Subject: Re: r313907 - Suppress Wsign-conversion for enums with matching

r313909 - Add testcase I forgot to add in R313907.

Author: erichkeane Date: Thu Sep 21 13:14:08 2017 New Revision: 313909 URL: http://llvm.org/viewvc/llvm-project?rev=313909=rev Log: Add testcase I forgot to add in R313907. Added: cfe/trunk/test/SemaCXX/warn-sign-conversion-cpp11.cpp (with props) Added:

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl updated this revision to Diff 116277. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revise by Anastasia's comments. https://reviews.llvm.org/D37822 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenCLRuntime.h

r313943 - Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData.

Author: rsmith Date: Thu Sep 21 17:11:15 2017 New Revision: 313943 URL: http://llvm.org/viewvc/llvm-project?rev=313943=rev Log: Extend -ast-dump for CXXRecordDecl to dump the flags from the DefinitionData. Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/Frontend/float16.cpp

r313922 - Revert "[lit] Refactor out some more common lit configuration code."

Author: zturner Date: Thu Sep 21 14:45:45 2017 New Revision: 313922 URL: http://llvm.org/viewvc/llvm-project?rev=313922=rev Log: Revert "[lit] Refactor out some more common lit configuration code." This is breaking several bots. I have enough information to investigate, so I'm reverting to

r313927 - [Analyzer] Use CC environment variable to select analyzer path in SATestBuild.

Author: george.karpenkov Date: Thu Sep 21 15:12:49 2017 New Revision: 313927 URL: http://llvm.org/viewvc/llvm-project?rev=313927=rev Log: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild. This change is required to easily test the given checkout of the analyzer,

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

kongyi created this revision. kongyi added a project: clang. Qualtype may point to null if we cannot infer its type yet. Fixes PR33843 Repository: rL LLVM https://reviews.llvm.org/D38158 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/typo-correction-crash.cpp Index:

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

efriedma added subscribers: cfe-commits, efriedma. efriedma added a comment. Please make sure to add the mailing list as a subscriber when you post a patch. (I haven't looked at the patch yet.) https://reviews.llvm.org/D38126 ___ cfe-commits

[PATCH] D38151: [clang] Fix isExternC matcher docs

alexshap created this revision. Herald added a subscriber: klimek. The wording in the documentation for the matcher isExternC appears to be misleading since this matcher is applicable to functions and variables as well. This diff changes the comment regenerates the html file. Repository: rL

[PATCH] D35796: [analyzer] Delete with non-virtual destructor check

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me! Do you have commit access, or do you need someone to commit it for you? https://reviews.llvm.org/D35796 ___

r313924 - [Analyzer] Add simple help to SATestAdd.py

Author: george.karpenkov Date: Thu Sep 21 14:47:33 2017 New Revision: 313924 URL: http://llvm.org/viewvc/llvm-project?rev=313924=rev Log: [Analyzer] Add simple help to SATestAdd.py Differential Revision: https://reviews.llvm.org/D38003 Modified: cfe/trunk/utils/analyzer/SATestAdd.py

r313923 - [Analyzer] Remove dead code from CmpRuns.py.

Author: george.karpenkov Date: Thu Sep 21 14:47:13 2017 New Revision: 313923 URL: http://llvm.org/viewvc/llvm-project?rev=313923=rev Log: [Analyzer] Remove dead code from CmpRuns.py. Differential Revision: https://reviews.llvm.org/D38003 Modified: cfe/trunk/utils/analyzer/CmpRuns.py

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

echristo added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2917 +CodeGenFunction , llvm::Function *F, +bool ForceThumb) { + StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

klimek added a reviewer: akyrtzi. klimek added a comment. Adding Argyrios, who might have insight on how this is used. I think this had the wrong list of reviewers so far :( https://reviews.llvm.org/D37554 ___ cfe-commits mailing list

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

klimek added a comment. Apart from nits, LGTM, unless Daniel sees issues. Comment at: lib/Format/TokenAnnotator.cpp:2516 return Style.SpacesInAngles; + // space before TT_StructuredBindingLSquare + if (Right.is(TT_StructuredBindingLSquare)) Super-Nit:

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. Hello, I didn't find an easy way factorize the change in IsUnwindTableDefault to support the multiple ARM toolchains. After a quick check in Triple::arm in Driver/Toochains, many seem impacted (excepted NetBSD and Darwin that uses DwarfCFI or SJLG). So here is an

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 116176. chrib added a comment. Herald added a subscriber: javed.absar. Changes since last revision: - Check IsUnwindTablesDefault in ARM Toolchains that support ExceptionHandling::ARM (not Darwin, NetBSD) - Check input type with driver mode for C++ mode. -

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

yaxunl marked 4 inline comments as done. yaxunl added a comment. In https://reviews.llvm.org/D37822#873876, @Anastasia wrote: > In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > > > In https://reviews.llvm.org/D37822#872291, @Anastasia wrote: > > > > > Could you please explain a bit

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jklaehn added a comment. In https://reviews.llvm.org/D36953#877367, @jbcoe wrote: > Do you need someone to commit this change for you? > > I'm happy to do so if you don't have commit access. Yes that would be great, thanks! https://reviews.llvm.org/D36953

r313880 - [OPENMP] Use canonical declarations for redeclarations checks.

Author: abataev Date: Thu Sep 21 07:06:59 2017 New Revision: 313880 URL: http://llvm.org/viewvc/llvm-project?rev=313880=rev Log: [OPENMP] Use canonical declarations for redeclarations checks. If the captured variable has some redeclarations we may run into the situation where the redeclaration

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell added a comment. LGTM we should probably set c++17 as the default over c++14 as part of this change. given that everything seems in order for c++17 bar P0522R0 so this looks like the change should be good. adding @rnk to confirm. @daxpedda do you have commit access?

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

alexfh added a comment. > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource > specification version 1.2 (19 April 2017), Err, "I did ask them, and received an answer that it is it can be implemented in clang-tidy" might not be enough. Repository: rL LLVM

[PATCH] D37263: [clang-format] Ignore case and stable sort using-declarations

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG, thanks! https://reviews.llvm.org/D37263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In https://reviews.llvm.org/D36836#877636, @alexfh wrote: > > The metric is implemented as per COGNITIVE COMPLEXITY by SonarSource > > specification version 1.2 (19 April 2017), > > Err, "I did ask them, and received an answer that it is it can be implemented > in

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 116195. xazax.hun added a comment. - Unittests now creates temporary files at the correct location - Temporary files are also cleaned up when the process is terminated - Absolute paths are handled correctly by the library https://reviews.llvm.org/D34512

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

chh updated this revision to Diff 116201. chh marked 2 inline comments as done. chh edited the summary of this revision. https://reviews.llvm.org/D35743 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl created this revision. Herald added a subscriber: nhaehnle. In OpenCL the kernel function and non-kernel function has different calling conventions. For certain targets they have different argument ABIs. Also kernels have special function attributes and metadata for runtime to launch

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. It seems that msvc enabled some c++17 features when in c++14 mode and they left them enabled because projects became dependant on them. switching to c++17 as the default and removing the

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 116198. Nebiroth added a comment. More consistent logging in clangdmain. Restructured argument checking in ClangdMain Fixed empty compile-commands-dir triggering error messages. Fixed failing standard tests. https://reviews.llvm.org/D37150 Files:

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

daxpedda added a comment. According to this the default is still c++14. I do not have commit access, I would prefer if somebody else commits this in my stead. Comment at:

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh added a comment. In https://reviews.llvm.org/D20689#871947, @barancsuk wrote: > @alexfh, would you mind taking a look at the changes that have been > introduced in the new patch? > > The main improvements are: > > - The checker has been shifted to the module `readability`. > - It is

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

yvvan added a comment. ping 3 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

curdeius added a comment. Could you add just one more test for `PAS_Middle` please? A single line will be just enough. Otherwise, LGTM. https://reviews.llvm.org/D35743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jbcoe added a comment. Do you need someone to commit this change for you? I'm happy to do so if you don't have commit access. https://reviews.llvm.org/D36953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added a comment. Tried stage2 build, so far only one warning. But found out that `ubsan_value.h`'s `typedef s128 SIntMax;` crashes this code because class LLVM_NODISCARD APSInt : public APInt { ... /// \brief Get the correctly-extended \c int64_t value. int64_t

[PATCH] D38075: Fix PR34668 - P0704R1 implementation is too permissive

Rakete added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:5185 if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) { // C++2a allows functions with ref-qualifier & if they are also 'const'. +if (Proto->isConst() &&

[PATCH] D38148: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

tra updated this revision to Diff 116236. tra added a comment. Fixed a typo in one test. https://reviews.llvm.org/D38148 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Headers/__clang_cuda_intrinsics.h clang/test/CodeGen/builtins-nvptx-ptx60.cu

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 +return IntRange(C.getIntWidth(QualType(T, 0)), +!ET->isSignedIntegerOrEnumerationType()); Maybe add a comment noting what can trigger this case?

[PATCH] D38148: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313898: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync}… (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38148?vs=116236=116237#toc Repository: rL LLVM

r313898 - [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins.

Author: tra Date: Thu Sep 21 11:44:49 2017 New Revision: 313898 URL: http://llvm.org/viewvc/llvm-project?rev=313898=rev Log: [NVPTX] Implemented bar.warp.sync, barrier.sync, and vote{.sync} instructions/intrinsics/builtins. Differential Revision: https://reviews.llvm.org/D38148 Modified:

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313899: [CUDA] Fixed order of words in the names of shfl builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38147?vs=116228=116238#toc Repository: rL LLVM

r313899 - [CUDA] Fixed order of words in the names of shfl builtins.

Author: tra Date: Thu Sep 21 11:46:39 2017 New Revision: 313899 URL: http://llvm.org/viewvc/llvm-project?rev=313899=rev Log: [CUDA] Fixed order of words in the names of shfl builtins. Differential Revision: https://reviews.llvm.org/D38147 Modified:

[PATCH] D38046: [Atomic][X8664] set max atomic inline/promote width according to the target

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D38046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38040: [OpenMP] Add an additional test for D34888

gtbercea added a comment. In https://reviews.llvm.org/D38040#878090, @Hahnfeld wrote: > Hi Doru, > > if I remember correctly I submitted https://reviews.llvm.org/D34888 for a > crash when mapping a scalar value with nested regions. > I've marked another test in this file that the codegen for

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

ilya-biryukov added a comment. Could you please run `clang-format` on every submission? Comment at: clangd/GlobalCompilationDatabase.cpp:98 + { +CompileCommandsDir = "/"; +return tryLoadDatabaseFromPath(CompileCommandsDir.getValue()); Is this some

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

ilya-biryukov added a comment. Friendly ping. Any suggestions for other reviewers are also very welcome. https://reviews.llvm.org/D38081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37263: [clang-format] Ignore case and stable sort using-declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL313963: [clang-format] Ignore case and stable sort using-declarations (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D37263 Files:

r313963 - [clang-format] Ignore case and stable sort using-declarations

Author: krasimir Date: Thu Sep 21 21:48:17 2017 New Revision: 313963 URL: http://llvm.org/viewvc/llvm-project?rev=313963=rev Log: [clang-format] Ignore case and stable sort using-declarations Summary: This ignores case while sorting using-declarations, fixing a case where `_` would appear

[PATCH] D38083: [clangd] Skip informative qualifier chunks.

ilya-biryukov updated this revision to Diff 116297. ilya-biryukov added a comment. - Fixed CHECK-DAG typo. https://reviews.llvm.org/D38083 Files: clangd/ClangdUnit.cpp test/clangd/completion-qualifiers.test Index: test/clangd/completion-qualifiers.test

[PATCH] D38083: [clangd] Skip informative qualifier chunks.

ilya-biryukov added inline comments. Comment at: test/clangd/completion-qualifiers.test:12 +# CHECK: {"jsonrpc":"2.0","id":2,"result":[ +# CHEKC-DAG: {"label":"foo() const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

eugenis added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2917 +CodeGenFunction , llvm::Function *F, +bool ForceThumb) { + StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;

r313948 - Fix tracking of whether a destructor would be deleted.

Author: rsmith Date: Thu Sep 21 18:04:22 2017 New Revision: 313948 URL: http://llvm.org/viewvc/llvm-project?rev=313948=rev Log: Fix tracking of whether a destructor would be deleted. I've been unable to find any cases whose behavior is actually changed by this, but only because an implicitly

r313949 - [Analyzer] Refactor analyzer testing scripts.

Author: george.karpenkov Date: Thu Sep 21 18:41:16 2017 New Revision: 313949 URL: http://llvm.org/viewvc/llvm-project?rev=313949=rev Log: [Analyzer] Refactor analyzer testing scripts. - Exporting needed function for future reuse. - Idiomatic python: using with `file as f` instead of

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

ilya-biryukov accepted this revision. ilya-biryukov added a comment. Looks good modulo a few NITS. Let me know if you need help landing this. Comment at: unittests/clangd/ClangdTests.cpp:910 + auto FooH = getVirtualTestFilePath("foo.h"); + auto invalid =

[PATCH] D37925: Allow specifying sanitizers in blacklists

dberris added inline comments. Comment at: lib/Basic/XRayLists.cpp:29 // whether it's treated as a "never" instrument function. - if (AlwaysInstrument->inSection("fun", FunctionName, "arg1")) + if (AlwaysInstrument->inSection("xray_always_instrument", "fun", FunctionName,

r313952 - Add test cases that weren't committed in r313945.

Author: ahatanak Date: Thu Sep 21 18:54:36 2017 New Revision: 313952 URL: http://llvm.org/viewvc/llvm-project?rev=313952=rev Log: Add test cases that weren't committed in r313945. Added: cfe/trunk/test/CodeGenCXX/noescape.cpp cfe/trunk/test/CodeGenObjC/noescape.m

r313954 - Driver: remove support for libstdc++ from CrossWindows

Author: compnerd Date: Thu Sep 21 21:01:12 2017 New Revision: 313954 URL: http://llvm.org/viewvc/llvm-project?rev=313954=rev Log: Driver: remove support for libstdc++ from CrossWindows This code path is entirely untested and not really maintained. The expected use here is with libc++ only.

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

echristo added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2917 +CodeGenFunction , llvm::Function *F, +bool ForceThumb) { + StringRef TargetCPU = CGF.getTarget().getTargetOpts().CPU;

r313953 - Clean up some mistreatment of enumerations.

Author: rsmith Date: Thu Sep 21 19:22:32 2017 New Revision: 313953 URL: http://llvm.org/viewvc/llvm-project?rev=313953=rev Log: Clean up some mistreatment of enumerations. Modified: cfe/trunk/include/clang/AST/Decl.h cfe/trunk/lib/AST/Decl.cpp cfe/trunk/lib/AST/Linkage.h Modified:

r313950 - [Analyzer] Static analyzer script for updating reference results

Author: george.karpenkov Date: Thu Sep 21 18:43:12 2017 New Revision: 313950 URL: http://llvm.org/viewvc/llvm-project?rev=313950=rev Log: [Analyzer] Static analyzer script for updating reference results The script updates reference results from the previous run, and stages them. Differential

r313955 - Give external linkage and mangling to lambdas inside inline variables and variable templates.

Author: rsmith Date: Thu Sep 21 21:25:05 2017 New Revision: 313955 URL: http://llvm.org/viewvc/llvm-project?rev=313955=rev Log: Give external linkage and mangling to lambdas inside inline variables and variable templates. This implements the proposed approach in

r313957 - Closure types have no name (and can't have a typedef name for linkage

Author: rsmith Date: Thu Sep 21 21:33:20 2017 New Revision: 313957 URL: http://llvm.org/viewvc/llvm-project?rev=313957=rev Log: Closure types have no name (and can't have a typedef name for linkage purposes), so they never formally have linkage. Modified: cfe/trunk/lib/AST/Decl.cpp

[clang-tools-extra] r313962 - [clang-tidy] Fix example in documentation, NFC

Author: krasimir Date: Thu Sep 21 21:37:56 2017 New Revision: 313962 URL: http://llvm.org/viewvc/llvm-project?rev=313962=rev Log: [clang-tidy] Fix example in documentation, NFC Summary: A fix in documentation. Reviewers: bkramer Reviewed By: bkramer Subscribers: JDevlieghere, xazax.hun

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane updated this revision to Diff 116244. erichkeane marked 2 inline comments as done. erichkeane added a comment. Updated based on Eli's feedback. https://reviews.llvm.org/D38145 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/warn-sign-conversion-cpp11.cpp Index:

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 + // underlying type, so that when someone specifies the type as + // "unsigned" it doesn't cause sign-conversion type warnings. if (!Enum->isCompleteDefinition())

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8176 + // underlying type, so that when someone specifies the type as + // "unsigned" it doesn't cause sign-conversion type warnings. if (!Enum->isCompleteDefinition())

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

erichkeane updated this revision to Diff 116245. erichkeane marked an inline comment as done. https://reviews.llvm.org/D38145 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/warn-sign-conversion-cpp11.cpp Index: test/SemaCXX/warn-sign-conversion-cpp11.cpp

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r313906 - [Sema] Prevent InstantiateClass from checking unrelated exception specs.

Author: vsapsai Date: Thu Sep 21 12:54:12 2017 New Revision: 313906 URL: http://llvm.org/viewvc/llvm-project?rev=313906=rev Log: [Sema] Prevent InstantiateClass from checking unrelated exception specs. Sema::InstantiateClass should check only exception specs added during class instantiation and

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313906: [Sema] Prevent InstantiateClass from checking unrelated exception specs. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D37881?vs=116056=116250#toc Repository: rL

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi added a comment. ping https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38145: Suppress Wsign-conversion for enums with matching underlying type

This revision was automatically updated to reflect the committed changes. Closed by commit rL313907: Suppress Wsign-conversion for enums with matching underlying type (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38145?vs=116245=116252#toc Repository: rL LLVM

r313907 - Suppress Wsign-conversion for enums with matching underlying type

Author: erichkeane Date: Thu Sep 21 12:58:55 2017 New Revision: 313907 URL: http://llvm.org/viewvc/llvm-project?rev=313907=rev Log: Suppress Wsign-conversion for enums with matching underlying type As reported here: https://bugs.llvm.org/show_bug.cgi?id=34692 A non-defined enum with a backing

r313896 - [Sema] Fix using old initializer during switch statement transformation.

Author: vsapsai Date: Thu Sep 21 10:58:27 2017 New Revision: 313896 URL: http://llvm.org/viewvc/llvm-project?rev=313896=rev Log: [Sema] Fix using old initializer during switch statement transformation. It fixes a crash in CodeGen when we are trying to generate code for initializer expression

[PATCH] D38009: [Sema] Fix using old initializer during switch statement transformation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313896: [Sema] Fix using old initializer during switch statement transformation. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38009?vs=115754=116226#toc Repository: rL

[PATCH] D38113: OpenCL: Assume functions are convergent

Anastasia added a comment. The problem of adding this attribute conservatively for all functions is that it prevents some optimizations to happen. I agree to commit this as a temporary fix to guarantee correctness of generated code. But if we ask to add the `convergent` attribute into the spec

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

tra created this revision. Herald added a subscriber: sanjoy. https://reviews.llvm.org/D38147 Files: clang/lib/Headers/__clang_cuda_intrinsics.h Index: clang/lib/Headers/__clang_cuda_intrinsics.h === ---

[PATCH] D38147: [CUDA] Fixed order of words in the names of shfl builtins.

jlebar added a comment. Naturally they're different orders in the PTX and CUDA. :) https://reviews.llvm.org/D38147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >