[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

xazax.hun accepted this revision. xazax.hun added a comment. I think there was only one comment but that is already addressed in a dependent revision. So I think this one is good as is. https://reviews.llvm.org/D31538 ___ cfe-commits mailing list c

[PATCH] D38688: Misc redundant expressions checker updated for macros

barancsuk created this revision. barancsuk added a project: clang-tools-extra. Redundant Expression Checker is updated to be able to detect expressions that contain macro constants. Also, other small details are modified to improve the current implementation. The improvements in detail are as f

[PATCH] D38627: [clangd] Added move-only function helpers.

ilya-biryukov added inline comments. Comment at: clangd/Function.h:36 + template + UniqueFunction(Callable Func) + : CallablePtr(llvm::make_unique< sammccall wrote: > Do you want this constructor to be explicit? > > If not, I think you should be able to

[PATCH] D38627: [clangd] Added move-only function helpers.

ilya-biryukov updated this revision to Diff 118204. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed review comments. - Added a file comment. - Simplified callsites of UniqueFunction in ClangdServer.h - Properly forward UniqueFunction's constructor argument

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

ilya-biryukov added reviewers: bkramer, klimek. ilya-biryukov added a comment. Adding more reviewers, in case someone will have time to look at that :-) https://reviews.llvm.org/D38617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D38402: [clang-refactor] Apply source replacements

hokein added inline comments. Comment at: include/clang/Frontend/CommandLineSourceLoc.h:57 + std::string FileName; + std::pair Begin; + std::pair End; Add a comment documenting what the first element and second element of the pair represent for (? If I unders

[PATCH] D38639: [clangd] #include statements support for Open definition

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. Looking forward to getting this change! I miss this as well. Please take a look at my comments, though. I think we might want to use a different API to implement this. Comment at: clangd/ClangdSer

Re: Patch to Bugzilla 31373

Hi Erik, You might consider posting your patch to Phabricator.  You'll likely get more feedback/traction there.. https://llvm.org/docs/Phabricator.html  Chad On 10/6/2017 8:15 AM, Erik Viktorsson via cfe-commits wrote: Committing a patch to Bugzilla 31373

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo created this revision. This effectively reverts SVN r204290 and r204292 (back when this code was part of libcxxabi). According to SVN r204290, the primary architecture using the DW_CFA_GNU_args_size opcode is VAX. However, clang also produces it on X86 when it has done X86CallFrameOp

Re: r314571 - [Analyzer] Synthesize function body for std::call_once

Bugzilla is not accessible, so here's a reduced test case: $ cat test-clang__BodyFarm__getBody.cc namespace std { template void call_once(d, e); } void g(); void f() { std::call_once(g, false); } $ clang-tidy -checks=-*,clang-analyzer* test-clang__BodyFarm__getBody.cc -- -std=c++11 -w *** SIGSEG

[PATCH] D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D38674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov updated this revision to Diff 118205. ilya-biryukov added a comment. - Included more cases into a qualifiers-as-written.cpp test. https://reviews.llvm.org/D38538 Files: include/clang/AST/QualTypeNames.h include/clang/Tooling/Core/QualTypeNames.h lib/AST/CMakeLists.txt lib/

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov added inline comments. Comment at: test/CodeCompletion/call.cpp:22 // CHECK-CC1: COMPLETION: Pattern : dynamic_cast<<#type#>>(<#expression#>) - // CHECK-CC1: f(N::Y y, <#int ZZ#>) + // CHECK-CC1: f(Y y, <#int ZZ#>) // CHECK-CC1-NEXT: f(int i, <#int j#>, int

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful, thanks! https://reviews.llvm.org/D37970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris added a comment. Ping. https://reviews.llvm.org/D37299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

xazax.hun added a comment. In https://reviews.llvm.org/D38675#891750, @danielmarjamaki wrote: > > However, the checker seems to work with a low false positive rate. (<15 on > > the LLVM, 6 effectively different) > > This does not sound like a low false positive rate to me. Could you describe >

[PATCH] D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method.

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! https://reviews.llvm.org/D31541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38596: Implement attribute target multiversioning

erichkeane added a subscriber: rsmith. erichkeane added a comment. In https://reviews.llvm.org/D38596#891603, @aaron.ballman wrote: > The attribute and sema bits look good to me, but I agree that you might want > Richard's opinions before committing. Oh, definitely! I actually put this up for

[PATCH] D37478: [analyzer] Implement pointer arithmetic on constants

r.stahl updated this revision to Diff 118182. r.stahl marked an inline comment as done. r.stahl edited the summary of this revision. r.stahl added a comment. Herald added a subscriber: szepet. addressed review comments. updated summary. https://reviews.llvm.org/D37478 Files: lib/StaticAnalyze

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader updated this revision to Diff 118210. bader edited the summary of this revision. bader added a comment. Fix parsing of function declarations with empty parameter list initializers. This change should fix the failure caught by the buildbot. Sorry for the long delay. https://reviews.llvm.org

[PATCH] D38628: Remove unneeded typename from test

rogfer01 updated this revision to Diff 118183. rogfer01 added a comment. - Remove another instance of this issue https://reviews.llvm.org/D38628 Files: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp test/std/utilities/variant/variant.helpers/variant_alternative.fail.cp

[PATCH] D38627: [clangd] Added move-only function helpers.

ilya-biryukov updated this revision to Diff 118184. ilya-biryukov added a comment. - Use proper types (Args&&) when forwarding arguments. https://reviews.llvm.org/D38627 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Function.h Index: clangd/Function.h ==

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

jina.nahias created this revision. https://reviews.llvm.org/D38683 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512cdintrin.h lib/Headers/avx512vlcdintrin.h test/CodeGen/avx512cdintrin.c test/CodeGen/avx512vlcd-builtins.c Index: test/CodeGen/avx512vlcd-builtins.c =

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Any feedback is appreciated! https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Carrot added a comment. I worked on a similar bug as 31161, and then found this one, it should be same as in comment7. What is the current status of the work on that bug? https://reviews.llvm.org/D38656 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

majnemer added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3223-3224 + // crash later. + llvm::IntegerType *ResultTy = + dyn_cast(Result->getType()); + if ((ResultTy->getBitWidth() > 1) && Is this clang-format'

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. A testcase would be nice, but this can go in to unblock things. https://reviews.llvm.org/D38617 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

m_zuckerman added a comment. Please add depended parent. LGTM After the parent commit (LLVM side). https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38627: [clangd] Added move-only function helpers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315210: [clangd] Added move-only function helpers. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38627 Files: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-e

[clang-tools-extra] r315210 - [clangd] Added move-only function helpers.

Author: ibiryukov Date: Mon Oct 9 09:26:26 2017 New Revision: 315210 URL: http://llvm.org/viewvc/llvm-project?rev=315210&view=rev Log: [clangd] Added move-only function helpers. Summary: They are now used in ClangdScheduler instead of deferred std::async computations. The results of `std::async`

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. after LLVM-SIDE https://reviews.llvm.org/D38672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 118218. erichkeane added reviewers: rnk, rsmith. erichkeane added a comment. 1 more const-auto. Also noticed I'd missed that removing the 'default' caused the function to fallthrough, so I added llvm_unreachable to the bottom. https://reviews.llvm.org/D

[PATCH] D38627: [clangd] Added move-only function helpers.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Function.h:9 +//===--===// + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_FUNCTION_

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov updated this revision to Diff 118185. ilya-biryukov added a comment. Herald added a subscriber: mgorny. - Restore qualifiers for types of EnumConstantDecl. https://reviews.llvm.org/D38538 Files: include/clang/AST/QualTypeNames.h include/clang/Tooling/Core/QualTypeNames.h lib

r315212 - Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

Author: ibiryukov Date: Mon Oct 9 09:52:12 2017 New Revision: 315212 URL: http://llvm.org/viewvc/llvm-project?rev=315212&view=rev Log: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble. Summary: It was previsouly set only in ASTUnit, but it should be set for all client of Precomp

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315212: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38617 Files: cfe/trunk/lib/Frontend/ASTUnit.cpp cf

[PATCH] D38675: [analyzer] MisusedMovedObjectChecker: Moving the checker out of alpha state

danielmarjamaki added a reviewer: danielmarjamaki. danielmarjamaki added a comment. > However, the checker seems to work with a low false positive rate. (<15 on > the LLVM, 6 effectively different) This does not sound like a low false positive rate to me. Could you describe what the false posi

[clang-tools-extra] r315213 - [clangd] Added a test for r315212.

Author: ibiryukov Date: Mon Oct 9 09:53:00 2017 New Revision: 315213 URL: http://llvm.org/viewvc/llvm-project?rev=315213&view=rev Log: [clangd] Added a test for r315212. Added: clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test Added: clang-tools-extra/trunk/test/clangd/diagnosti

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

ilya-biryukov added a comment. In https://reviews.llvm.org/D38617#892092, @bkramer wrote: > A testcase would be nice, but this can go in to unblock things. Thanks for reviewing this! Added a test case to clangd in https://reviews.llvm.org/rL315213. Repository: rL LLVM https://reviews.llvm.

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

sammccall added a comment. I'm missing some context for this one: - what's the goal? Make the code read more naturally, change the async model, or something else? - what's the end state for codeComplete specifically? will we switch to the new overload and delete the other, or is makeFutureAPIFr

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev updated this revision to Diff 118200. kosarev added a comment. Removed the extra ###include##. https://reviews.llvm.org/D38126 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/CodeGen/CGObjCRuntime.cpp lib/CodeGen/CGO

[clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Author: ibiryukov Date: Mon Oct 9 09:58:16 2017 New Revision: 315214 URL: http://llvm.org/viewvc/llvm-project?rev=315214&view=rev Log: [clangd] Added a command-line arg to mirror clangd input into a file. Summary: The arg is useful for debugging and creating test cases. Reviewers: bkramer, kras

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315214: [clangd] Added a command-line arg to mirror clangd input into a file. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D37970?vs=115628&id=118223#toc Repository: rL

[PATCH] D38538: Avoid printing some redundant name qualifiers in completion

ilya-biryukov added inline comments. Comment at: test/CodeCompletion/enum-switch-case-qualified.cpp:25 // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:23:8 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s -// CHECK-CC1: Blue : [#M::N::C::Color#]N::C::Blue -//

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov updated this revision to Diff 118225. ilya-biryukov added a comment. - Added a deprecation notice to function description. https://reviews.llvm.org/D38629 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h ===

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

ilya-biryukov added a comment. We had a discussion with @sammccall offline, probably > - what's the goal? Make the code read more naturally, change the async model, > or something else? Callback API is more flexible (if `std::future` that we use had `then`, they'd be equivalent). We have inte

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple updated this revision to Diff 118231. jkorous-apple added a comment. clang-format https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp ===

[PATCH] D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message

danielmarjamaki added a comment. LGTM https://reviews.llvm.org/D38674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo created this revision. This builds on some parts from https://reviews.llvm.org/D33601 - some of them were commented on before. This patch contains comments and explanations about those non-obvious parts. https://reviews.llvm.org/D38679 Files: docs/index.rst src/AddressSpace.hpp

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

rnk added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin; ".eh_fra

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Index/USRGeneration.cpp:819 } +if (const auto *const AT = dyn_cast(T)) { + Out << "{"; Nit: I don't think you really n

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

szepet created this revision. This patch adds support for importing two different kind of C++ AST Node. Note: This solution is based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp#L7605 . https://reviews.llvm.org/D38694 Files: lib/AST/ASTImporter.cpp uni

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

arphaman added inline comments. Comment at: lib/Index/USRGeneration.cpp:820 +if (const auto *const AT = dyn_cast(T)) { + Out << "{"; + switch (AT->getSizeModifier()) { You might also want to use the character literals for one char strings for effic

r315219 - AMDGPU: Fix missing declaration for __builtin_amdgcn_dispatch_ptr

Author: arsenm Date: Mon Oct 9 10:44:18 2017 New Revision: 315219 URL: http://llvm.org/viewvc/llvm-project?rev=315219&view=rev Log: AMDGPU: Fix missing declaration for __builtin_amdgcn_dispatch_ptr Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/bu

[PATCH] D38656: [CGExprScalar] In EmitCompare trunc the result if it has different type as E->getType()

Carrot updated this revision to Diff 118236. Carrot marked 3 inline comments as done. https://reviews.llvm.org/D38656 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ppc-vector-compare.cc Index: test/CodeGen/ppc-vector-compare.cc

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

Hello Benjamin, I look s like this commit broke build on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5327 . . . FAILED: tools/clang/lib/Serialization/CMakeFiles/clangSerialization.dir/ASTReader.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\

[PATCH] D38695: [CodeGen] Do not construct complete LValue base info in trivial cases

kosarev created this revision. kosarev added a project: clang. Besides obvious code simplification, avoiding explicit creation of LValueBaseInfo objects makes it easier to make TBAA information to be part of such objects. This is part of https://reviews.llvm.org/D38126 reworked to be a separate

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev added a comment. Please take a look at https://reviews.llvm.org/D38695, if you want this by smaller pieces. Thanks. https://reviews.llvm.org/D38126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

STL_MSFT added a comment. FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update. Repository: rL LLVM https://reviews.llvm.org/D38646 ___

Re: r315194 - Make SourceLocation, QualType and friends have constexpr constructors.

Looks like a bug in the compiler, the warning doesn't make any sense. Does creating a FileID() variable and passing that instead work? On Mon, Oct 9, 2017 at 8:02 PM, Galina Kistanova wrote: > Hello Benjamin, > > I look s like this commit broke build on one of our builders: > > http://lab.llvm.or

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

arsenm created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D38698 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn.cl Index: test/CodeGenOpenCL/builtins-amdgcn.

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

erichkeane created this revision. It seems that all of the other templated cases are handled correctly, however the function template case was not correctly handled. This patch recovers from this condition by setting the function to noexcept after diagnosing. Previously it simply set NoexceptExp

[libclc] r315228 - Make ptx barrier work irrespective of the cl_mem_fence_flags

Author: jketema Date: Mon Oct 9 11:36:48 2017 New Revision: 315228 URL: http://llvm.org/viewvc/llvm-project?rev=315228&view=rev Log: Make ptx barrier work irrespective of the cl_mem_fence_flags This generates a "bar.sync 0” instruction, which not only causes the threads to wait, but does acts as

Re: [clang-tools-extra] r315214 - [clangd] Added a command-line arg to mirror clangd input into a file.

Hi, On Mon, Oct 9, 2017 at 9:58 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Mon Oct 9 09:58:16 2017 > New Revision: 315214 > > URL: http://llvm.org/viewvc/llvm-project?rev=315214&view=rev > Log: > [clangd] Added a command-line arg to mirror clangd input into a file. > >

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

rnk added a comment. In https://reviews.llvm.org/D38646#892246, @STL_MSFT wrote: > FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, > the first toolset update. 1912 will be the value for VS 2017 15.5, the second > toolset update. Yep. The initial draft of this patc

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

jkorous-apple updated this revision to Diff 118247. jkorous-apple added a comment. Single char constants don't need to be c-strings. https://reviews.llvm.org/D38643 Files: lib/Index/USRGeneration.cpp test/Index/USR/array-type.cpp Index: test/Index/USR/array-type.cpp ==

r315231 - Testing commit access.

Author: hamzasood Date: Mon Oct 9 12:07:09 2017 New Revision: 315231 URL: http://llvm.org/viewvc/llvm-project?rev=315231&view=rev Log: Testing commit access. Modified: cfe/trunk/lib/Driver/Compilation.cpp Modified: cfe/trunk/lib/Driver/Compilation.cpp URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin; rnk

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

jroelofs added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; Would it w

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. I spoke to @EricWF on IRC last week and got his approval to commit this without review if no one had gotten to it in a couple of days, so I'm going ahead with that. https://reviews.llvm.or

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL315234: [libc++] Support Microsoft ABI without vcruntime headers (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D38522?vs=117613&id=118251#toc Repository: rL LLVM https://r

[libcxx] r315234 - [libc++] Support Microsoft ABI without vcruntime headers

Author: smeenai Date: Mon Oct 9 12:25:17 2017 New Revision: 315234 URL: http://llvm.org/viewvc/llvm-project?rev=315234&view=rev Log: [libc++] Support Microsoft ABI without vcruntime headers The vcruntime headers are hairy and clash with both libc++ headers themselves and other libraries. libc++

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; jroelofs w

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

rnk added inline comments. Comment at: src/AddressSpace.hpp:388-389 + found_obj = true; + } else if (!strncmp((const char *)pish->Name, ".eh_frame", + IMAGE_SIZEOF_SHORT_NAME)) { +info.dwarf_section = begin; mstorsjo

[libclc] r315235 - Implement mem_fence on ptx

Author: jketema Date: Mon Oct 9 12:43:04 2017 New Revision: 315235 URL: http://llvm.org/viewvc/llvm-project?rev=315235&view=rev Log: Implement mem_fence on ptx PTX does not differentiate between read and write fences. Hence, these a lowered to a mem_fence call. The mem_fence function compiles to

r315236 - PR13575: Fix USR mangling for fixed-size arrays

Author: jkorous Date: Mon Oct 9 12:51:33 2017 New Revision: 315236 URL: http://llvm.org/viewvc/llvm-project?rev=315236&view=rev Log: PR13575: Fix USR mangling for fixed-size arrays Differential Revision: https://reviews.llvm.org/D38643 Added: cfe/trunk/test/Index/USR/ cfe/trunk/test/Ind

[PATCH] D38643: PR13575: Fix USR mangling for fixed-size arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315236: PR13575: Fix USR mangling for fixed-size arrays (authored by jkorous). Changed prior to commit: https://reviews.llvm.org/D38643?vs=118247&id=118257#toc Repository: rL LLVM https://reviews.ll

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun, javed.absar. Fixes https://bugs.llvm.org/show_bug.cgi?id=30565 @dcoughlin Any advice on how to handle different stdlib implementations? Can we conjure a separate symbol instead of relying on a particular struct

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

xazax.hun added a comment. Did you link the correct bug in the description? The one you linked was closed long ago. https://reviews.llvm.org/D38702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

george.karpenkov added a comment. Ooops, updated to https://bugs.llvm.org/show_bug.cgi?id=34869 https://reviews.llvm.org/D38702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

arsenm closed this revision. arsenm added a comment. r315238 https://reviews.llvm.org/D38698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315238 - AMDGPU: Add read_exec_lo/hi builtins

Author: arsenm Date: Mon Oct 9 13:06:37 2017 New Revision: 315238 URL: http://llvm.org/viewvc/llvm-project?rev=315238&view=rev Log: AMDGPU: Add read_exec_lo/hi builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeG

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 118261. hamzasood added a comment. - Updated lambda mangling to include explicit template parameters - Allow explicit template parameter lists on lambdas pre-c++2a as an extension. - Improved the somewhat fragile template depth handling. - Reformatted some a

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; mstorsjo w

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo updated this revision to Diff 118263. mstorsjo added a comment. Added a fixme comment about the truncated section name, flipped the ifdef in the assembly source. Didn't implement findFunctionName. https://reviews.llvm.org/D38679 Files: docs/index.rst src/AddressSpace.hpp src/Unw

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

jroelofs added inline comments. Comment at: src/AddressSpace.hpp:521 unw_word_t *offset) { -#ifndef _LIBUNWIND_IS_BAREMETAL +#if !defined(_LIBUNWIND_IS_BAREMETAL) && !defined(_WIN32) Dl_info dyldInfo; mstorsjo w

r315241 - PR13575: Fix test

Author: jkorous Date: Mon Oct 9 13:17:28 2017 New Revision: 315241 URL: http://llvm.org/viewvc/llvm-project?rev=315241&view=rev Log: PR13575: Fix test Ignore OS-specific mangled name. Modified: cfe/trunk/test/Index/USR/array-type.cpp Modified: cfe/trunk/test/Index/USR/array-type.cpp URL:

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

mstorsjo added inline comments. Comment at: docs/index.rst:53 NetBSD x86_64 Clang, GCC DWARF CFI +Windows i386 ClangDWARF CFI Any i386, x86_64, ARMClangSjLj FWIW, for this to actually work

[clang-tools-extra] r315242 - Revert r315214 since diff -Z isn't portable, this is breaking:

Author: bruno Date: Mon Oct 9 13:22:05 2017 New Revision: 315242 URL: http://llvm.org/viewvc/llvm-project?rev=315242&view=rev Log: Revert r315214 since diff -Z isn't portable, this is breaking: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive http://green.lab.llvm.org/green/jo

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#889842, @smeenai wrote: > Does dlopen cause issues even with `RTLD_GLOBAL`? From my testing, yes. Regardless, `RTLD_LOCAL` is how JNI libraries get loaded when `System.loadLibrary` is used, so the `strcmp` fallback is a requirement

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs resigned from this revision. jroelofs added a comment. I'm not sure I'm the right person to review this. Repository: rL LLVM https://reviews.llvm.org/D38599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

mstorsjo created this revision. Herald added a subscriber: mehdi_amini. This makes sure that the FDE cache is thread safe. This requires building with `_WIN32_WINNT >= 0x0600`. The alternative would be to skip the FDE cache altogether if building without threads. https://reviews.llvm.org/D387

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

jkorous-apple created this revision. https://reviews.llvm.org/D38707 Files: lib/Index/USRGeneration.cpp test/Index/USR/func-type.cpp Index: test/Index/USR/func-type.cpp === --- /dev/null +++ test/Index/USR/func-type.cpp @@ -0,0

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

mstorsjo added a comment. In https://reviews.llvm.org/D38704#892479, @zturner wrote: > I'm a little nervous about re-inventing a poor man's version of a reader > writer lock. Can we not just copy LLVM's? I guess I could have a look to see how much extra either kitchen sink it would bring. Si

[PATCH] D38708: [AST] Flag the typo-corrected nodes for better tooling

arphaman created this revision. This patch adds a new boolean field to the `DeclRefExpr`, `MemberExpr`, `CXXCtorInitializer`, `ObjCIvarRefExpr`, `ObjCPropertyRefExpr` nodes which is set to true when these nodes have been produced during typo-correction. This is useful for Clang-based tooling as

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo added a comment. In https://reviews.llvm.org/D38680#892487, @compnerd wrote: > I think that the problem is that we are using the generic register name, but > we need to use the target specific register name. On x86, EIP/ESP are > swapped. You mean EBP/ESP? I think the code here does

[PATCH] D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments.

arphaman added inline comments. Comment at: lib/Index/USRGeneration.cpp:757 VisitType(FT->getReturnType()); - for (const auto &I : FT->param_types()) + Out << '('; + for (const auto &I : FT->param_types()) { I believe you can drop the '(' an

[PATCH] D38702: [Analyzer] Do not segfault on unexpected call_once implementation

dcoughlin added a comment. > @dcoughlin Any advice on how to handle different stdlib implementations? > Can we conjure a separate symbol instead of relying on a particular struct > layout? > For now this implementation will simply not go inside a differently > implemented call_once. I think t

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

Quuxplusone added a comment. I'm also much out of my depth here, but I'm skeptical. You're changing the comments in the code from essentially saying "This workaround helps people with broken code" to essentially saying "This indispensable functionality helps people like me who use dlopen()." A

  1   2   >