[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn marked an inline comment as done. jklaehn added a comment. In https://reviews.llvm.org/D36973#893851, @jbcoe wrote: > LGTM > > Would you like me to commit this for you? Yes, that would be great! https://reviews.llvm.org/D36973 ___

[PATCH] D38402: [clang-refactor] Apply source replacements

hokein accepted this revision. hokein added a comment. LGTM, let's check in it. Repository: rL LLVM https://reviews.llvm.org/D38402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn added a comment. In https://reviews.llvm.org/D36955#893856, @jbcoe wrote: > LGTM > > Would you like me to commit this for you? Yes, I would appreciate it. https://reviews.llvm.org/D36955 ___ cfe-commits mailing list

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

hokein added a comment. The code looks most good to me, a few nits. Comment at: lib/Basic/DiagnosticIDs.cpp:46 unsigned WarnShowInSystemHeader : 1; - unsigned Category : 5; + unsigned Category : 6; just curious: is this change needed?

[PATCH] D38452: Mark test as a long-test

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38791: [CodeGen] EmitLoadOfPointerLValue() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. This patch should not bring in any functional changes. Prepared on top of https://reviews.llvm.org/D38733. Repository: rL LLVM https://reviews.llvm.org/D38791 Files: CodeGen/CGExpr.cpp CodeGen/CodeGenFunction.h Index:

[PATCH] D38733: [CodeGen] Generate TBAA info along with LValue base info

kosarev updated this revision to Diff 118551. kosarev added a comment. Removed changes related to functions like getNaturalTypeAlignment() that generate LValue base info objects to simplify the patch. These removed changes will be addressed with separate patches.

[PATCH] D38793: [CodeGen] EmitLoadOfReference() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. Repository: rL LLVM https://reviews.llvm.org/D38793 Files: CodeGen/CGExpr.cpp CodeGen/CodeGenFunction.h Index: CodeGen/CodeGenFunction.h === ---

[PATCH] D38794: [CodeGen] getNaturalTypeAlignment() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. This patch should not bring in any functional changes. Prepared on top of https://reviews.llvm.org/D38733, https://reviews.llvm.org/D38788, https://reviews.llvm.org/D38791 and https://reviews.llvm.org/D38793. Repository: rL

[PATCH] D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315452: [clang-rename] Don't add prefix qualifiers to the declaration and definition of… (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D38723?vs=118573=118587#toc Repository:

r315452 - [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

Author: hokein Date: Wed Oct 11 04:15:48 2017 New Revision: 315452 URL: http://llvm.org/viewvc/llvm-project?rev=315452=rev Log: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek,

r315453 - [OpenCL] Allow function declaration with empty argument list.

Author: bader Date: Wed Oct 11 04:16:31 2017 New Revision: 315453 URL: http://llvm.org/viewvc/llvm-project?rev=315453=rev Log: [OpenCL] Allow function declaration with empty argument list. Treat 'f()' as 'f(void)' rather than a function w/o a prototype. Reviewers: Anastasia, yaxunl Reviewed

r315439 - Revert r314955: "Remove PendingBody mechanism for function and ObjC method deserialization."

Author: djasper Date: Wed Oct 11 00:47:54 2017 New Revision: 315439 URL: http://llvm.org/viewvc/llvm-project?rev=315439=rev Log: Revert r314955: "Remove PendingBody mechanism for function and ObjC method deserialization." This is breaking a build of https://github.com/abseil/abseil-cpp and so

[PATCH] D38788: [CodeGen] EmitCXXMemberDataPointerAddress() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. Prepared on top of https://reviews.llvm.org/D38733. Repository: rL LLVM https://reviews.llvm.org/D38788 Files: CodeGen/CGClass.cpp CodeGen/CGExpr.cpp CodeGen/CodeGenFunction.h Index: CodeGen/CodeGenFunction.h

[PATCH] D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol.

hokein updated this revision to Diff 118573. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D38723 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/RenameClassTest.cpp Index:

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/IssueHash.cpp:39 + // primary template. + if (const FunctionDecl *InstantiatedFrom = + Target->getInstantiatedFromMemberFunction()) martong wrote: > Could we use here

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. Prepared on top of https://reviews.llvm.org/D38795. Repository: rL LLVM https://reviews.llvm.org/D38796 Files: CodeGen/CGExpr.cpp CodeGen/CodeGenFunction.cpp CodeGen/CodeGenFunction.h CodeGen/CodeGenModule.cpp

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. @mgrang, did you ever get to completing this? I've got a need for this now (only `__dmb` so far), and if you don't have time, I can try to finish it. https://reviews.llvm.org/D36111 ___ cfe-commits mailing list

[PATCH] D38797: [analyzer] CStringChecker: pr34460: Admit that some casts are hard to model.

NoQ created this revision. Herald added a subscriber: szepet. In https://bugs.llvm.org/show_bug.cgi?id=34460 CStringChecker tries to `evalCast()` a memory region from `void *` to `char *` for the purposes of modeling `mempcpy()`. The memory region turned out to be an element region of type

[PATCH] D37856: [refactor] add support for refactoring options

hokein added a comment. Sorry for the delay. I saw you have reverted this commit somehow. A post commit. Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113 Rules.push_back(createRefactoringActionRule( -SymbolSelectionRequirement())); +

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

hamzasood added a comment. I have access now, so I'm able to commit this myself. However it's been a while since it was approved, so I'd be grateful if someone could take another look to make sure nothing has changed in the meantime (besides potentially needing to re-tag some new APIs).

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

baloghadamsoftware added a comment. I tried to extend the type to avoid overflow scenarios. Unfortunately, this breaks essential calculations based on the overflow scenarios (e.g. ProgramSate::assumeInbound()). So I see no other option than to abandon this patch and return to the local

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

martong added inline comments. Comment at: test/Analysis/bug_hash_test.cpp:105 +void g() { + TX x; + TX xl; As we discussed, the checking of the equality of the `IssueString` in case of `TX` and `TX` is implicit. And as such it is hard to see that it is

[PATCH] D38797: [analyzer] CStringChecker: pr34460: Admit that some casts are hard to model.

NoQ added inline comments. Comment at: test/Analysis/casts.c:134-139 + clang_analyzer_eval(y1 == y2); // expected-warning{{TRUE}} + + // FIXME: should be FALSE (i.e. equal pointers). + clang_analyzer_eval(y1 - y2); // expected-warning{{UNKNOWN}} + // FIXME: should be TRUE

[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. This is an update to https://reviews.llvm.org/D36111 by @mgrang, taking over finishing of this patch. Compared to his version, this makes the intrinsics conditional to ALL_MS_LANGUAGES.

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

arphaman added inline comments. Comment at: lib/Basic/DiagnosticIDs.cpp:46 unsigned WarnShowInSystemHeader : 1; - unsigned Category : 5; + unsigned Category : 6; hokein wrote: > just curious: is this change needed? I get a build warning without this

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

arphaman updated this revision to Diff 118701. arphaman marked 2 inline comments as done. arphaman added a comment. - rename the common consumer class. Repository: rL LLVM https://reviews.llvm.org/D38772 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt

[PATCH] D38824: [X86] Synchronize the CPU predefined macros with gcc

chandlerc added inline comments. Comment at: lib/Basic/Targets/X86.cpp:844-845 -// FIXME: Historically, we defined this legacy name, it would be nice to -// remove it at some point. We've never exposed fine-grained names for -// recent primary x86 CPUs, and we should

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert abandoned this revision. danalbert added a comment. nbjoerg and zygoloid got me pointed in the right direction. Both `Base` and `BaseImpl` are missing their key functions, and that's the problem here. Patch should be unnecessary. https://reviews.llvm.org/D38599

r315530 - [ADT] Make Twine's copy constructor private.

Author: zturner Date: Wed Oct 11 16:33:06 2017 New Revision: 315530 URL: http://llvm.org/viewvc/llvm-project?rev=315530=rev Log: [ADT] Make Twine's copy constructor private. There's a lot of misuse of Twine scattered around LLVM. This ranges in severity from benign (returning a Twine from a

r315536 - Revert "[ADT] Make Twine's copy constructor private."

Author: zturner Date: Wed Oct 11 16:54:34 2017 New Revision: 315536 URL: http://llvm.org/viewvc/llvm-project?rev=315536=rev Log: Revert "[ADT] Make Twine's copy constructor private." This reverts commit 4e4ee1c507e2707bb3c208e1e1b6551c3015cbf5. This is failing due to some code that isn't built

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

rsmith added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8667-8679 + bool Result; // The result of the comparison + if ((Op == BO_GT && ValueType == LimitType::Max && ConstOnRight) || + (Op == BO_GT && ValueType == LimitType::Min && !ConstOnRight) || + (Op

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert planned changes to this revision. danalbert added a comment. In https://reviews.llvm.org/D38599#894041, @jroelofs wrote: > (possibly renamed to _LIBCXXABI_DYNAMIC_FALLBACK) I opted for adding this switch to libc++ instead. Like @rprichard points out, we'll need to do this in

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

jroelofs added a comment. Needs a docs entry for the new flag (in libcxx's BuildingLibcxx.rst). Other than that, all the stuff I've asked you to add LGTM. I'd still appreciate @EricWF/@mclow's opinion on the meat of the functional change part of this though... I don't know all the implications

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

On 22 September 2017 at 18:00, Volodymyr Sapsai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Sep 21, 2017, at 15:17, Richard Smith wrote: > > On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

Buildbot numbers for the last week of 10/1/2017 - 10/7/2017

Hello everyone, Below are some buildbot numbers for the last week of 10/1/2017 - 10/7/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 09/24/2017 - 09/30/2017

Hello everyone, Below are some buildbot numbers for the week of 09/24/2017 - 09/30/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

K-ballo created this revision. Introduce a new form of `result_of` without function type encoding. Rename and split `is_callable/is_nothrow_callable` into `is_invocable/is_nothrow_invocable/is_invocable_r/is_nothrow_invocable_r` (and associated types accordingly) Change function type encoding

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

george.karpenkov added a comment. @mgorny I've replied via email, but the message didn't seem to appear here. From my (maybe limited) understanding, running tests on standalone compiler-rt builds was never something which was supported, as that required a fresh compiler. I've just tried

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert abandoned this revision. danalbert added a comment. zygoloid and nbjoerg got me pointed in the right direction on this. Looks like the user didn't have a key function defined for one of their classes, which was actually the root of the problem. Repository: rL LLVM

r315532 - Update cc1as_main for MCCodeEmitter ownership change in r315531.

Author: lhames Date: Wed Oct 11 16:35:27 2017 New Revision: 315532 URL: http://llvm.org/viewvc/llvm-project?rev=315532=rev Log: Update cc1as_main for MCCodeEmitter ownership change in r315531. Modified: cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/tools/driver/cc1as_main.cpp

r315508 - [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once.

Author: george.karpenkov Date: Wed Oct 11 13:53:01 2017 New Revision: 315508 URL: http://llvm.org/viewvc/llvm-project?rev=315508=rev Log: [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once. Differential Revision: https://reviews.llvm.org/D38810 Modified:

[PATCH] D38810: [Analyzer] Support bodyfarming std::call_once for libstdc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL315508: [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once. (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D38810?vs=118644=118686#toc

[PATCH] D38824: [X86] Synchronize the CPU predefined macros with gcc

craig.topper created this revision. Herald added a subscriber: krytarowski. We were using corei7 for a large swatch of Intel CPUs. gcc has a different defines that more closely match the march flags. This updates to match. It also fixes skylake-avx512 and adds silvermont in addition to slm.

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:51 +namespace LanguageAS { /// The type of a lookup table which maps from language-specific address spaces jlebar wrote: > I wonder if you need this namespace? LangAS right

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

jlebar added a comment. > The only reason I added this namespace is that I wasn't sure whether having > those functions in the clang namespace is acceptable. Maybe someone else will object, or suggest an existing namespace they should be in. FWIW I think it's fine. > Not quite sure what to

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert created this revision. Herald added a subscriber: mgorny. libc++ doesn't yet have the code for this, but libc++abi does. Adding the switch to libc++ since the flag in libc++abi is `_LIBCXX_DYNAMIC_FALLBACK`, not `_LIBCXXABI_DYNAMIC_FALLBACK`, and it will be needed here as well.

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert updated this revision to Diff 118711. danalbert added a comment. Herald added a subscriber: mgorny. Update the test with an XFAIL when _LIBCXX_DYNAMIC_FALLBACK is not set. https://reviews.llvm.org/D38827 adds this cmake option to libc++. https://reviews.llvm.org/D38599 Files:

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

eugenis added a comment. ping https://reviews.llvm.org/D38430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth marked an inline comment as done. Nebiroth added inline comments. Comment at: clangd/ClangdUnit.cpp:784 +/// Finds declarations locations that a given source location refers to. +class TargetDeclarationFinder : public index::IndexDataConsumer { + std::vector

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. It sounds like there's agreement about the basic technical direction of introducing LangAS::opencl_private. Please introduce isAddressSpaceImplicit() in a different patch and make this patch just about the introduction of LangAS::opencl_private. You can have the

r315517 - [X86] Add support for 'amdfam17h' to __builtin_cpu_is to match gcc.

Author: ctopper Date: Wed Oct 11 14:42:02 2017 New Revision: 315517 URL: http://llvm.org/viewvc/llvm-project?rev=315517=rev Log: [X86] Add support for 'amdfam17h' to __builtin_cpu_is to match gcc. The compiler-rt implementation already supported it, it just wasn't exposed. Modified:

r315518 - [Driver] Export symbols needed to use profile runtime

Author: vedantk Date: Wed Oct 11 14:54:09 2017 New Revision: 315518 URL: http://llvm.org/viewvc/llvm-project?rev=315518=rev Log: [Driver] Export symbols needed to use profile runtime Apple's API verification tool (tapi) checks that the symbols exported from a program match a whitelist. When the

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

rnk added inline comments. Comment at: src/libunwind.cpp:188 + co->getInfo(); + pint_t orgArgSize = (pint_t)info.gp; + uint64_t orgFuncStart = info.start_ip; I think it makes sense to have this here: the contract is that if the personality sets

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

jlebar added a comment. My only regret is that I have but one +1 to give to this patch. Comment at: include/clang/Basic/AddressSpaces.h:51 +namespace LanguageAS { /// The type of a lookup table which maps from language-specific address spaces I wonder if

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo added a comment. As further explanation/justification - libcxxabi and libunwind don't support SEH exceptions yet. https://reviews.llvm.org/D38819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38824: [X86] Synchronize the CPU predefined macros with gcc

chandlerc added inline comments. Comment at: lib/Basic/Targets/X86.cpp:844-845 -// FIXME: Historically, we defined this legacy name, it would be nice to -// remove it at some point. We've never exposed fine-grained names for -// recent primary x86 CPUs, and we should

r315506 - [clang-fuzzer] Build with newer protobuf-mutator.

Author: morehouse Date: Wed Oct 11 13:45:10 2017 New Revision: 315506 URL: http://llvm.org/viewvc/llvm-project?rev=315506=rev Log: [clang-fuzzer] Build with newer protobuf-mutator. Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake Modified:

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 2 inline comments as done. yaxunl added a comment. In https://reviews.llvm.org/D35082#895230, @rjmccall wrote: > It sounds like there's agreement about the basic technical direction of > introducing LangAS::opencl_private. Please introduce > isAddressSpaceImplicit() in a

[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. LGTM. https://reviews.llvm.org/D38821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert planned changes to this revision. danalbert added a comment. Actually, I was wrong. This is implemented. Will update to set the flag the configures this and add a test. Repository: rL LLVM https://reviews.llvm.org/D38827 ___

[PATCH] D38824: [X86] Synchronize the CPU predefined macros with gcc

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:844-845 -// FIXME: Historically, we defined this legacy name, it would be nice to -// remove it at some point. We've never exposed fine-grained names for -// recent primary x86 CPUs, and we

r315459 - [clang-rename] Add more unittest.

Author: hokein Date: Wed Oct 11 07:00:42 2017 New Revision: 315459 URL: http://llvm.org/viewvc/llvm-project?rev=315459=rev Log: [clang-rename] Add more unittest. Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp URL:

[PATCH] D38798: [OpenMP] Support for implicit "declare target" functions - Sema patch

grokos created this revision. grokos added a project: clang. This patch completes the support for the "declare target" directive in Sema. With this patch Sema handles implicitly used functions (i.e. functions which are used inside a target region without having been "declared target")

[PATCH] D38801: [analyzer] In getSVal() API, disable auto-detection of void type as char type.

NoQ created this revision. Herald added a subscriber: szepet. In https://reviews.llvm.org/D38358, we ended up believing that reading the first byte of the void pointer is not the intended behavior of `ProgramState::getSVal(Loc)`. Hence the fix. Additionally, allow specifying the type in the

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

This revision was automatically updated to reflect the committed changes. Closed by commit rL315462: [Analyzer] Clarify error messages for undefined result (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D30295?vs=116865=118620#toc Repository: rL LLVM

[PATCH] D38720: [clangd] Report proper kinds for 'Keyword' and 'Snippet' completion items.

rwols accepted this revision. rwols added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 118617. szdominik marked 4 inline comments as done. szdominik added a comment. Small changes after aaron.ballman's comments. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/CopyConstructorInitCheck.cpp

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:37 + + // We match here because we want one warning (and FixIt) for every ctor. + const auto Matches = match( aaron.ballman wrote: > Wouldn't registering this matcher

[PATCH] D37856: [refactor] add support for refactoring options

arphaman added a comment. In https://reviews.llvm.org/D37856#894638, @hokein wrote: > Sorry for the delay. I saw you have reverted this commit somehow. A post > commit. I had some issues with ppc64/s390x bots for some reason, so I had to revert. I'm still trying to investigate what went

[PATCH] D23963: [analyzer] pr28449 - Move literal rvalue construction away from RegionStore.

NoQ updated this revision to Diff 118625. NoQ added a comment. Herald added a subscriber: szepet. Because i didn't get back to this in a while, and similar crashes keep coming, i decided to leave this refactoring as a FIXME. https://reviews.llvm.org/D23963 Files:

r315464 - [OPENMP] Fix PR34916: Crash on mixing taskloop|tasks directives.

Author: abataev Date: Wed Oct 11 08:29:40 2017 New Revision: 315464 URL: http://llvm.org/viewvc/llvm-project?rev=315464=rev Log: [OPENMP] Fix PR34916: Crash on mixing taskloop|tasks directives. If both taskloop and task directives are used at the same time in one program, we may ran into the

r315462 - [Analyzer] Clarify error messages for undefined result

Author: danielmarjamaki Date: Wed Oct 11 07:49:35 2017 New Revision: 315462 URL: http://llvm.org/viewvc/llvm-project?rev=315462=rev Log: [Analyzer] Clarify error messages for undefined result Differential Revision: https://reviews.llvm.org/D30295 Modified:

[PATCH] D38795: [CodeGen] emitOMPArraySectionBase() to generate TBAA info along with LValue base info

kosarev created this revision. kosarev added a project: clang. Prepared on top of https://reviews.llvm.org/D38733. Repository: rL LLVM https://reviews.llvm.org/D38795 Files: CodeGen/CGExpr.cpp Index: CodeGen/CGExpr.cpp ===

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM - thanks! https://reviews.llvm.org/D38757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r315547 - [X86] Remove a few unnecessary check lines from the predefined-arch-macros test.

Author: ctopper Date: Wed Oct 11 19:06:17 2017 New Revision: 315547 URL: http://llvm.org/viewvc/llvm-project?rev=315547=rev Log: [X86] Remove a few unnecessary check lines from the predefined-arch-macros test. These were testing OS macros and clang/llvm macros. Modified:

[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

compnerd added a comment. Don't you need a change to the intrinsics to actually map the builtin? https://reviews.llvm.org/D38821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38835: [refactor] selection: new CodeRangeASTSelection represents a set of selected consecu

arphaman created this revision. Repository: rL LLVM https://reviews.llvm.org/D38835 Files: include/clang/Tooling/Refactoring/ASTSelection.h lib/Tooling/Refactoring/ASTSelection.cpp unittests/Tooling/ASTSelectionTest.cpp Index: unittests/Tooling/ASTSelectionTest.cpp

[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. In https://reviews.llvm.org/D38821#895527, @compnerd wrote: > Don't you need a change to the intrinsics to actually map the builtin? Apparently, this change is all that's needed since the tests pass. I can of course try to look closer and see what actually makes it

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo added inline comments. Comment at: src/libunwind.cpp:188 + co->getInfo(); + pint_t orgArgSize = (pint_t)info.gp; + uint64_t orgFuncStart = info.start_ip; rnk wrote: > I think it makes sense to have this here: the contract is that if the

[PATCH] D38679: [libunwind] Support dwarf unwinding on i386 windows

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r315463 - [clang-fuzzer] Fix shared library dependencies.

Author: morehouse Date: Wed Oct 11 08:13:53 2017 New Revision: 315463 URL: http://llvm.org/viewvc/llvm-project?rev=315463=rev Log: [clang-fuzzer] Fix shared library dependencies. Modified: cfe/trunk/tools/clang-fuzzer/CMakeLists.txt cfe/trunk/tools/clang-fuzzer/handle-cxx/CMakeLists.txt

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726 + case NVPTX::BI__hmma_m16n16k16_ld_c_f16: +case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{ +Address Dst = EmitPointerWithAlignment(E->getArg(0)); jlebar wrote: > weird indentation?

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

tra updated this revision to Diff 118636. tra marked 6 inline comments as done. tra added a comment. Addressed Justin's comments. https://reviews.llvm.org/D38742 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-nvptx-sm_70.cu

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth marked 3 inline comments as done. Nebiroth added inline comments. Comment at: clangd/ClangdUnit.cpp:1017 + + auto DeclLocationsFinder = std::make_shared( + llvm::errs(), SourceLocationBeg, AST.getASTContext(), ilya-biryukov wrote: > I wonder if we

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb updated this revision to Diff 118638. bsdjhb added a comment. - Add more soft-float checks. https://reviews.llvm.org/D38110 Files: include/__libunwind_config.h include/libunwind.h src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S src/UnwindRegistersSave.S

r315465 - Reland "[clang-fuzzer] Allow building without coverage instrumentation."

Author: morehouse Date: Wed Oct 11 08:51:12 2017 New Revision: 315465 URL: http://llvm.org/viewvc/llvm-project?rev=315465=rev Log: Reland "[clang-fuzzer] Allow building without coverage instrumentation." This relands r315336 after fixing bot breakage. Added:

[PATCH] D37856: [refactor] add support for refactoring options

hokein added inline comments. Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113 Rules.push_back(createRefactoringActionRule( -SymbolSelectionRequirement())); +SymbolSelectionRequirement(), OptionRequirement())); return Rules;

r315470 - [X86] Correct type for argument to clflushopt intrinsic.

Author: ctopper Date: Wed Oct 11 09:06:08 2017 New Revision: 315470 URL: http://llvm.org/viewvc/llvm-project?rev=315470=rev Log: [X86] Correct type for argument to clflushopt intrinsic. Summary: According to Intel docs this should take void const *. We had char*. The lack of const is the main

r315467 - [OPENMP] Remove extra if, NFC.

Author: abataev Date: Wed Oct 11 08:56:38 2017 New Revision: 315467 URL: http://llvm.org/viewvc/llvm-project?rev=315467=rev Log: [OPENMP] Remove extra if, NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL:

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726 + case NVPTX::BI__hmma_m16n16k16_ld_c_f16: +case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{ +Address Dst =

[PATCH] D38733: [CodeGen] Generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure. https://reviews.llvm.org/D38733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23963: [analyzer] pr28449 - Move literal rvalue construction away from RegionStore.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. OK. Seems reasonable! https://reviews.llvm.org/D23963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r315492 - [Analyzer] Fix introduced regression: properly check for nullable attribute.

Author: george.karpenkov Date: Wed Oct 11 12:13:15 2017 New Revision: 315492 URL: http://llvm.org/viewvc/llvm-project?rev=315492=rev Log: [Analyzer] Fix introduced regression: properly check for nullable attribute. Modified:

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

george.karpenkov updated this revision to Diff 118657. george.karpenkov marked 2 inline comments as done. https://reviews.llvm.org/D38764 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

r315488 - [Analyzer] Assume that string-like const globals are non-nil.

Author: george.karpenkov Date: Wed Oct 11 11:39:40 2017 New Revision: 315488 URL: http://llvm.org/viewvc/llvm-project?rev=315488=rev Log: [Analyzer] Assume that string-like const globals are non-nil. Differential Revision: https://reviews.llvm.org/D38764 Added:

[PATCH] D38764: [Analyzer] Assume const string-like globals are non-null

This revision was automatically updated to reflect the committed changes. Closed by commit rL315488: [Analyzer] Assume that string-like const globals are non-nil. (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D38764?vs=118657=118660#toc Repository: rL

r315489 - [Analyzer] Remove dead code from testing scripts

Author: george.karpenkov Date: Wed Oct 11 11:42:39 2017 New Revision: 315489 URL: http://llvm.org/viewvc/llvm-project?rev=315489=rev Log: [Analyzer] Remove dead code from testing scripts Differential Revision: https://reviews.llvm.org/D38488 Modified: cfe/trunk/utils/analyzer/SATestBuild.py

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth added a comment. Bumping this. I've worked on a patch for this feature that currently supports showing the declaration of whatever is being hovered on instead of the raw source code. It also has basic support to distinguish declarations in types ( class/struct, namespace, global

[PATCH] D38810: [Analyzer] Support bodyfarming std::call_once for libstdc++

george.karpenkov created this revision. Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar, aemerson. https://reviews.llvm.org/D38810 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test/Analysis/call_once.cpp

  1   2   >