[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

mstorsjo created this revision. Herald added subscribers: kristof.beyls, aemerson. This matches the original libunwind API. This also unifies the type between ARM EHABI and the other configurations, and allows getting rid of a number of casts in log messages. The cursor size updates for ppc

[libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

Author: mstorsjo Date: Fri Oct 27 00:59:01 2017 New Revision: 316745 URL: http://llvm.org/viewvc/llvm-project?rev=316745=rev Log: Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER This avoids having to keep the same information duplicated in multiple places. Adjust

[PATCH] D39281: [libunwind] Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

This revision was automatically updated to reflect the committed changes. Closed by commit rL316745: Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D39281?vs=120467=120548#toc Repository: rL

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL316747: Add support for dwarf unwinding on windows on x86_64 (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D38819?vs=120380=120552#toc Repository: rL LLVM

[libunwind] r316747 - Add support for dwarf unwinding on windows on x86_64

Author: mstorsjo Date: Fri Oct 27 01:11:36 2017 New Revision: 316747 URL: http://llvm.org/viewvc/llvm-project?rev=316747=rev Log: Add support for dwarf unwinding on windows on x86_64 Clang doesn't currently support building for windows/x86_64 with dwarf by setting command line parameters, but if

[PATCH] D39280: [libunwind] Use uint64_t for unw_word_t in ARM EHABI

mstorsjo added a comment. In https://reviews.llvm.org/D39280#908825, @compnerd wrote: > I dont think that this is correct. IIRC, the unwind specification expects > `unw_word_t` to match `uintptr_t` (that is, it should be 32-bits on > https://reviews.llvm.org/P32 environments). I checked

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

hans added a comment. The request for -fno-cygprofile-args was from another user. You raise a good point, it sounds like mcount() might be perfect for them :-) https://reviews.llvm.org/D39331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39366: [ASTMatchers] Matchers for new[] operators

baloghadamsoftware created this revision. Herald added a subscriber: rnkovacs. Two new matchers for ``CXXNewExpr`` are added which may be useful e.g. in clang-tidy checkers. One of them is ``isArrayForm`` which matches ``new[]`` but not plain ``new`. The other one, ``hasArraySize`` matches

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

baloghadamsoftware created this revision. Herald added a subscriber: rnkovacs. The check now recognizes error cases like `new char[strlen(s + 1)]` and suggests a fix in the format `new char[strlen(s) + 1]`. https://reviews.llvm.org/D39367 Files:

[PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

kimgr added a comment. Why? It seems easier to me to map back if the diagnostic mirrors the code as-written. https://reviews.llvm.org/D39360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

Rakete abandoned this revision. Rakete added a comment. @kimgr Well, mostly because they bother me a bit, don't know what others think though. I just thought it would be nice if they didn't appear, mainly because there is no need to show empty quotes in the error message. Hmm, you have

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

baloghadamsoftware updated this revision to Diff 120545. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D39121 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[clang-tools-extra] r316744 - [clang-tidy ObjC] [3/3] New check objc-forbidden-subclassing

Author: hokein Date: Fri Oct 27 00:41:36 2017 New Revision: 316744 URL: http://llvm.org/viewvc/llvm-project?rev=316744=rev Log: [clang-tidy ObjC] [3/3] New check objc-forbidden-subclassing Summary: This is part 3 of 3 of a series of changes to improve Objective-C linting in clang-tidy. This

RE: r316518 - mplement __has_unique_object_representations

Incremental progress is fine :) On 26 Oct 2017 09:53, "Keane, Erich via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Thanks for the review Richard. Would you like me to revert, or can I just make these changes in a new patch? *From:* Richard Smith [mailto:rich...@metafoo.co.uk]

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

sammccall added a comment. Implementation LG. My questions are mostly framework-level: - should this be an Action, or just a Rule under the existing rename Action? - {qname vs selection} x {local vs global} x ... seems like a combinatorial explosion in the number of rules. Shouldn't concerns

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks great! Thanks for bearing with me. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:31 + /// A human readable title for the

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:143 +} +auto USRs = getUSRsForDeclaration(ND, Context.getASTContext()); +return tooling::createRenameAtomicChanges( sammccall wrote: > if this is a local

[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

hokein abandoned this revision. hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:74 +// The declaration in which the nested name is contained (can be nullptr). +const Decl *Context; +// The nested name being

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

sammccall added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:143 +} +auto USRs = getUSRsForDeclaration(ND, Context.getASTContext()); +return tooling::createRenameAtomicChanges( hokein wrote: > sammccall wrote: > > if

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

ioeric accepted this revision. ioeric added a comment. lg Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:48 + + // static const RefactoringDescriptor () = 0; }; A comment would be nice here. Comment at:

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

JonasToth added inline comments. Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:62 + const Expr *Alloc = Result.Nodes.getNodeAs("Alloc"); + if (!Alloc) Alloc = Result.Nodes.getNodeAs("Alloc"); const auto *StrLen = Result.Nodes.getNodeAs("StrLen");

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

JonasToth added a comment. Should the release notes be modified as well? Repository: rL LLVM https://reviews.llvm.org/D39367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39366: [ASTMatchers] Matchers for new[] operators

baloghadamsoftware updated this revision to Diff 120577. baloghadamsoftware added a comment. Matcher renamed to `isArray`. https://reviews.llvm.org/D39366 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

baloghadamsoftware updated this revision to Diff 120579. baloghadamsoftware added a comment. Reformatted according to the comments. https://reviews.llvm.org/D39367 Files: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp docs/ReleaseNotes.rst

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 120581. mibintc added a comment. The patch to clang is the same as before. The modifications are to the test cases, I verified that all these test cases need modifications. I will also be updating the associated diff for clang/tools/extra, please review

[PATCH] D39366: [ASTMatchers] Matchers for new[] operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D39366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

baloghadamsoftware added a comment. In https://reviews.llvm.org/D39121#909172, @aaron.ballman wrote: > Many of the comments are marked done, but the code does not reflect that it > actually is done, so I'm not certain what's happened there. Neither do I. I will try to re-upload the diff.

r316758 - Test commit

Author: yvvan Date: Fri Oct 27 04:05:40 2017 New Revision: 316758 URL: http://llvm.org/viewvc/llvm-project?rev=316758=rev Log: Test commit Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp URL:

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

hokein updated this revision to Diff 120575. hokein added a comment. Add an assert for non-empty USRs. https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/RefactoringActionRegistry.def lib/Tooling/Refactoring/Rename/RenamingAction.cpp

[PATCH] D38596: Implement attribute target multiversioning

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1917 + MVK_All, // All Decls of this function have a 'target' attribute. None differ + // in contents, so this is the 'hint' case. + MVK_MultiVersion, // All Decls of this function

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

aaron.ballman added a comment. Many of the comments are marked done, but the code does not reflect that it actually is done, so I'm not certain what's happened there. Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:86 + diag(Alloc->getLocStart(), +

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In https://reviews.llvm.org/D39367#909117, @JonasToth wrote: > Should the release notes be modified as well? I think so. I consider the inclusion of operator `new[]` important.

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris added a comment. Ping. https://reviews.llvm.org/D37299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39370: [clang-tidy] Detect bugs in bugprone-misplaced-operator-in-strlen-in-alloc even in the case the allocation function is called using a constant function pointer

baloghadamsoftware created this revision. Detect bugs even if a function of the `malloc()` family is called using a constant pointer. https://reviews.llvm.org/D39370 Files: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 120584. mibintc added a comment. Updated the test diff to correspond to the https://reviews.llvm.org/D34158 patch uploaded today. https://reviews.llvm.org/D34624 Files: test/pp-trace/pp-trace-pragma-general.cpp test/pp-trace/pp-trace-pragma-opencl.cpp

[PATCH] D39366: [ASTMatchers] Matchers for new[] operators

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5772 +/// matches the expression 'new MyClass[10]'. +AST_MATCHER(CXXNewExpr, isArrayForm) { + return Node.isArray(); We typically try to match the AST method names with

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 120578. bsdjhb marked 3 inline comments as done. bsdjhb added a comment. - Use correct #ifdef for N32. - Rename N64 to newabi. https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

aaron.ballman added a comment. This upload looks considerably better, thank you! Comment at: docs/ReleaseNotes.rst:63 + + Finds cases where ``1`` is added to the string in the parameter of + ``strlen()``, ``strnlen()``, ``strnlen_s()``, ``wcslen()``, ``wcsnlen()`` and

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

szepet added a comment. LGTM as well, but same note applies. https://reviews.llvm.org/D38842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r316764 - [CrossTU] Fix handling of Cross Translation Unit directory path

Author: xazax Date: Fri Oct 27 05:53:37 2017 New Revision: 316764 URL: http://llvm.org/viewvc/llvm-project?rev=316764=rev Log: [CrossTU] Fix handling of Cross Translation Unit directory path Differential Revision: https://reviews.llvm.org/D38842 Modified:

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb marked 2 inline comments as done. bsdjhb added inline comments. Comment at: include/__libunwind_config.h:62 +# define _LIBUNWIND_CONTEXT_SIZE 35 +# define _LIBUNWIND_CURSOR_SIZE 46 +# define _LIBUNWIND_HIGHEST_DWARF_REGISTER 66 sdardis wrote: >

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:64-65 +Alloc = Result.Nodes.getNodeAs("Alloc"); + assert(Alloc && "Matched node bound by `Alloc` shoud be either `CallExpr`" + " or `CXXNewExpr`"); +

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

baloghadamsoftware updated this revision to Diff 120595. baloghadamsoftware added a comment. Herald added a subscriber: mgorny. Backsticks changed to single quotes, new tests added. https://reviews.llvm.org/D39367 Files: clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

xazax.hun added a comment. In https://reviews.llvm.org/D37470#906717, @dcoughlin wrote: > I think it would be better to add a new > "test/Analysis/block-in-critical-section.m" file rather than enabling a > random alpha checker in a file that tests the analyzer core. My reasoning was that the

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

xazax.hun updated this revision to Diff 120598. xazax.hun added a comment. - Added a separate test case as per Devin's suggestion https://reviews.llvm.org/D37470 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/block-in-critical-section.m Index:

[PATCH] D39374: CodeGen: Fix insertion position of addrspace cast for alloca

yaxunl created this revision. For non-zero alloca addr space, alloca is usually casted to default addr space immediately. For non-vla, alloca is inserted at AllocaInsertPt, therefore the addr space cast should also be insterted at AllocaInsertPt. However, for vla, alloca is inserted at the

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

leanil created this revision. It doesn't depend on instance specific data, so this would make it easier to use, for example here : https://reviews.llvm.org/D39372 Files: include/clang/Basic/DiagnosticIDs.h lib/Basic/DiagnosticIDs.cpp Index:

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

aaron.ballman added a comment. My only remaining concern is with the diagnostic message/fixit interaction itself. Let's see if @alexfh has any suggestions there, or we think of an improvement ourselves. https://reviews.llvm.org/D39121 ___

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

baloghadamsoftware updated this revision to Diff 120593. baloghadamsoftware added a comment. Docs rephrased according to the comments. https://reviews.llvm.org/D39121 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[clang-tools-extra] r316767 - [clang-tidy] Fix bug 34845, offending standard bitmask types

Author: jonastoth Date: Fri Oct 27 07:44:08 2017 New Revision: 316767 URL: http://llvm.org/viewvc/llvm-project?rev=316767=rev Log: [clang-tidy] Fix bug 34845, offending standard bitmask types Summary: The C++ standard allows implementations to choose the underlying type for bitmask types (e.g.

[PATCH] D38171: Implement clang-tidy check aliases.

leanil added a comment. In https://reviews.llvm.org/D38171#901427, @xazax.hun wrote: > One problem to think about when we add all clang-diagnostic as "first or > second" class citizen, `checkes=*` might now enable all the warnings which > make no sense and might be surprising to the users.

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

This revision was automatically updated to reflect the committed changes. Closed by commit rL316764: [CrossTU] Fix handling of Cross Translation Unit directory path (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D38842?vs=118773=120576#toc Repository: rL LLVM

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:64-65 +Alloc = Result.Nodes.getNodeAs("Alloc"); + assert(Alloc && "Matched node bound by `Alloc` shoud be either `CallExpr`" + " or `CXXNewExpr`"); +

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

baloghadamsoftware updated this revision to Diff 120582. baloghadamsoftware added a comment. Second try to upload the correct diff... https://reviews.llvm.org/D39121 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added reviewers: ddunbar, krememek. nik added a comment. ...added some more reviewers that I've found with git blame. Ping to the new ones :) https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth created this revision. Revision https://reviews.llvm.org/D38639 needs this commit in order to properly make open definition calls on include statements work. Since this modifies clang and not clangd, I decided to include it in a different patch. https://reviews.llvm.org/D39375

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb updated this revision to Diff 120623. bsdjhb added a comment. - Rebase for recent change to MAX_REGISTER meaning. https://reviews.llvm.org/D38110 Files: include/__libunwind_config.h include/libunwind.h src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S

Re: [libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

On 10/27/17 8:59 AM, Martin Storsjo via cfe-commits wrote: > Author: mstorsjo > Date: Fri Oct 27 00:59:01 2017 > New Revision: 316745 > > URL: http://llvm.org/viewvc/llvm-project?rev=316745=rev > Log: > Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER > > This avoids

[clang-tools-extra] r316770 - [clangd] Harden clangd a bit against garbage input.

Author: d0k Date: Fri Oct 27 09:33:15 2017 New Revision: 316770 URL: http://llvm.org/viewvc/llvm-project?rev=316770=rev Log: [clangd] Harden clangd a bit against garbage input. There can be nullptrs here if the YAML fails to parse. Found by clangd-fuzzer! Modified:

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

syzaara created this revision. Add clang option -msave-toc-indirect for PowerPC. https://reviews.llvm.org/D39376 Files: include/clang/Driver/Options.td test/Driver/ppc-features.cpp Index: test/Driver/ppc-features.cpp === ---

[PATCH] D38596: Implement attribute target multiversioning

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: include/clang/Basic/Attr.td:1917 + MVK_All, // All Decls of this function have a 'target' attribute. None differ + // in contents, so this is the 'hint' case. +

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle added a comment. Can you revert the formatting changes in places you haven’t touched (mainly astunit.cpp)? I think you should be able to do that with git checkout -p HEAD~1 https://reviews.llvm.org/D39375 ___ cfe-commits mailing list

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 120624. bsdjhb added a comment. - Rebase after MAX_REGISTER change. https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp src/Registers.hpp src/UnwindCursor.hpp

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a reviewer: bruno. MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120628. hintonda added a comment. - Add support for individual DiagID's, and print out number of breakpoints added. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

compnerd added inline comments. Comment at: include/__libunwind_config.h:69 +# define _LIBUNWIND_CURSOR_SIZE 47 +# define _LIBUNWIND_HIGHEST_DWARF_REGISTER 65 # else Can we sink the two cases into the `__mips__` case? Something like: #if

[clang-tools-extra] r316774 - [clangd] Don't crash on extremely large JSON messages.

Author: d0k Date: Fri Oct 27 10:06:41 2017 New Revision: 316774 URL: http://llvm.org/viewvc/llvm-project?rev=316774=rev Log: [clangd] Don't crash on extremely large JSON messages. Found by clangd-fuzzer. Added: clang-tools-extra/trunk/test/clangd/too_large.test Modified:

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 120620. erichkeane added a comment. Fixes for Aaron's comments. https://reviews.llvm.org/D38596 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h

[PATCH] D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message

zaks.anna added a comment. Please, commit. https://reviews.llvm.org/D38674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

zaks.anna added a comment. Just to be clear, since this leads to regression to the checker API, I am asking to look into other ways of solving this problem. For example, is there a way to ensure that the checker names are set at construction? https://reviews.llvm.org/D37437

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Thanks Gabor. Looks great to me! https://reviews.llvm.org/D37470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38596: Implement attribute target multiversioning

aaron.ballman added a comment. I think the attribute and sema parts look good, but I leave the codegen bits to someone with more experience in that area. https://reviews.llvm.org/D38596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120629. hintonda added a comment. - Remove whitespace. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.py @@ -0,0

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:28 + +// FIXME: Remove the Actions alltogether. +class ExtractRefactoring final : public RefactoringAction { ioeric wrote: > Maybe I'm missing the context here... Why do

r316773 - New lldb python module for managing diagnostic breakpoints

Author: dhinton Date: Fri Oct 27 10:02:33 2017 New Revision: 316773 URL: http://llvm.org/viewvc/llvm-project?rev=316773=rev Log: New lldb python module for managing diagnostic breakpoints Summary: Can be used to set breakpoints for either the diagnostics actually emitted for the current

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL316773: New lldb python module for managing diagnostic breakpoints (authored by dhinton). Repository: rL LLVM https://reviews.llvm.org/D36347 Files: cfe/trunk/utils/clangdiag.py Index:

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 120636. erichkeane added a comment. Fix comment in Attr.td that @aaron.ballman brought up on IRC. https://reviews.llvm.org/D38596 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

arphaman added a comment. I've committed https://reviews.llvm.org/D38985, so you'd have to rebase unfortunately. Things are still somewhat unstable :) Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public

r316777 - [WebAssembly] Add crt1.o with calling lld

Author: sbc Date: Fri Oct 27 11:10:19 2017 New Revision: 316777 URL: http://llvm.org/viewvc/llvm-project?rev=316777=rev Log: [WebAssembly] Add crt1.o with calling lld Also, for OS unknown targets like wasm, don't include 'unknown' in the library path. This is a fix for rL316719. Differential

[PATCH] D37341: [Sema] Fix an assert-on-invalid by avoiding function template specialisation deduction for invalid functions with fabricated template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL316778: [Sema] Fix an assert-on-invalid by avoiding function template specialisation (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D37341?vs=119967=120658#toc Repository:

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

craig.topper added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:4586 +ParsedAttr.Features.erase( +remove_if(ParsedAttr.Features.begin(), ParsedAttr.Features.end(), +[&](const std::string ) { Use llvm::remove_if which takes a

r316778 - [Sema] Fix an assert-on-invalid by avoiding function template specialisation

Author: arphaman Date: Fri Oct 27 11:13:31 2017 New Revision: 316778 URL: http://llvm.org/viewvc/llvm-project?rev=316778=rev Log: [Sema] Fix an assert-on-invalid by avoiding function template specialisation deduction for invalid functions The fabricated template parameters cause an assertion

[PATCH] D39378: Remove x86,x86_32/64 from isValidFeatureName

erichkeane created this revision. These are not valid values for this, and are pretty non-sensical, since LLVM doesn't understand them. https://reviews.llvm.org/D39378 Files: lib/Basic/Targets/X86.cpp Index: lib/Basic/Targets/X86.cpp

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

zaks.anna accepted this revision. zaks.anna added a comment. LGTM! https://reviews.llvm.org/D38728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r316783 - Filter out invalid 'target' items from being passed to LLVM

Author: erichkeane Date: Fri Oct 27 11:32:23 2017 New Revision: 316783 URL: http://llvm.org/viewvc/llvm-project?rev=316783=rev Log: Filter out invalid 'target' items from being passed to LLVM Craig noticed that CodeGen wasn't properly ignoring the values sent to the target attribute. This patch

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

hfinkel added a comment. Please upload diffs with full context. Comment at: include/clang/Driver/Options.td:1907 def mvsx : Flag<["-"], "mvsx">, Group; +def msave_toc_indirect : Flag<["-"], "msave-toc-indirect">, Group; def mno_vsx : Flag<["-"], "mno-vsx">, Group;

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: ioeric wrote: > arphaman wrote: > > hokein wrote: > > > sammccall wrote: > > > > As

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: arphaman wrote: > hokein wrote: > > sammccall wrote: > > > As discussed offline, it's not

r316784 - Replace a few usages of llvm::join with range-version[NFC]

Author: erichkeane Date: Fri Oct 27 11:45:06 2017 New Revision: 316784 URL: http://llvm.org/viewvc/llvm-project?rev=316784=rev Log: Replace a few usages of llvm::join with range-version[NFC] I noticed a few usages of llvm::join that were using begin/end rather than just the range version. This

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1041 +else + BaseLV = CGF.EmitLoadOfReferenceLValue(BaseLV); BaseTy = BaseTy->getPointeeType(); Oh-oh, it looks I do something not functionally equivalent here. Sorry, will

[PATCH] D39354: [WebAssembly] Add crt1.o when calling lld

This revision was automatically updated to reflect the committed changes. Closed by commit rL316777: [WebAssembly] Add crt1.o with calling lld (authored by sbc). Repository: rL LLVM https://reviews.llvm.org/D39354 Files: cfe/trunk/lib/Driver/ToolChain.cpp

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev updated this revision to Diff 120654. kosarev added a comment. - Fixed the type of the reference lvalue in loadToBegin(). John, can you please review the fix? Thanks. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp

[PATCH] D38844: [analyzer] Make issue hash related tests more concise

zaks.anna added a comment. Please, change the commit description to be more comprehensive. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68 // (globals should not be invalidated, etc), hence the use of evalCall. - FnCheck Handler =

r316780 - [refactor] Describe refactorings in the operation classes

Author: arphaman Date: Fri Oct 27 11:19:11 2017 New Revision: 316780 URL: http://llvm.org/viewvc/llvm-project?rev=316780=rev Log: [refactor] Describe refactorings in the operation classes This commit changes the way that the refactoring operation classes are structured: - Users have to call

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

erichkeane updated this revision to Diff 120659. erichkeane added a comment. Switched to llvm::remove_if(RANGE, lambda) instead of std::remove_if with begin/end per Craig's suggestion. https://reviews.llvm.org/D39357 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/X86.cpp

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rL316780: [refactor] Describe refactorings in the operation classes (authored by arphaman). Changed prior to commit:

[PATCH] D38844: [analyzer] Make issue hash related tests more concise

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68 // (globals should not be invalidated, etc), hence the use of evalCall. - FnCheck Handler = llvm::StringSwitch(C.getCalleeName(CE)) -.Case("clang_analyzer_eval",

[PATCH] D39378: Remove x86,x86_32/64 from isValidFeatureName

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39269: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. What kind of output will this start displaying? (I believe currently the script does print the summary of the objects that are added or deleted.) https://reviews.llvm.org/D39269

  1   2   >