[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

mike.dvoretsky created this revision. mike.dvoretsky added reviewers: craig.topper, spatel, RKSimon. Herald added a subscriber: cfe-commits. Currently, X86 floor and ceil intrinsics for vectors are implemented as target-specific intrinsics that use the generic rounding instruction of the

[PATCH] D44732: [clangd] Set CLANGD_EDITOR environment variable in vscode extension.

hokein abandoned this revision. hokein added a comment. Herald added a subscriber: MaskRay. As discussed, we infer the editor from process tree which won't require changes in all clients. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44732

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

ilya-biryukov added a comment. Sorry for the late response, was on vacation. Comment at: include/clang/Sema/CodeCompleteConsumer.h:565 + /// \brief For this completion result correction is required. + Optional Corr = None; + yvvan wrote: > yvvan wrote: > >

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329053: [clangd][cmake] Provide libatomic when there is no native support for 64bit… (authored by sdardis, committed by ). Herald added subscribers: llvm-commits, MaskRay. Changed prior to commit:

[clang-tools-extra] r329053 - [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

Author: sdardis Date: Tue Apr 3 02:40:07 2018 New Revision: 329053 URL: http://llvm.org/viewvc/llvm-project?rev=329053=rev Log: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics This addresses a persistent failure on clang-cmake-mips buildbot. Reviewers:

[PATCH] D45069: [clangd] synthesize fix message when the diagnostic doesn't provide one.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a small nit Comment at: clangd/Diagnostics.cpp:322 + StringRef Insert = FixIt.CodeToInsert; + if (!Invalid && Remove.size() + Insert.size()

[PATCH] D45126: Xray, OpenBSD support

dberris added a comment. In https://reviews.llvm.org/D45126#1055451, @devnexen wrote: > In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > > > LGTM -- at some point, it would be good to refactor all these flag settings > > to a single place. Maybe file a bug so that we can track that

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

ilya-biryukov added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:26 +// their compile commands. If getAllFilenames() is empty, no inference occurs. +// +//===--===//

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

lebedev.ri added a comment. In https://reviews.llvm.org/D45163#1054994, @Quuxplusone wrote: > `std::move` would definitely be special in this regard if there were a > pressing benefit to be gained — i.e., if people were currently getting bitten > by accidentally discarded calls of

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +replyError(ErrorCode::MethodNotFound, OS.str()); malaperle wrote: > ilya-biryukov

[PATCH] D45126: Xray, OpenBSD support

devnexen updated this revision to Diff 140762. https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp === --- lib/Driver/XRayArgs.cpp +++

[PATCH] D45007: [clangd] Use compile-command interpolation to provide commands for header files.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Let's just always do it! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45007 ___ cfe-commits mailing list

r329052 - UsersManual.rst: update text for /GX- to match r328708

Author: hans Date: Tue Apr 3 02:28:21 2018 New Revision: 329052 URL: http://llvm.org/viewvc/llvm-project?rev=329052=rev Log: UsersManual.rst: update text for /GX- to match r328708 Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > LGTM -- at some point, it would be good to refactor all these flag settings > to a single place. Maybe file a bug so that we can track that issue on XRay? > If you can't do it now, I'd be happy to do it

[PATCH] D45126: Xray, OpenBSD support

dberris added inline comments. Comment at: lib/Driver/XRayArgs.cpp:53 +} else if (Triple.getOS() == llvm::Triple::FreeBSD || + Triple.getOS() == llvm::Triple::OpenBSD) { if (Triple.getArch() != llvm::Triple::x86_64) { I just noticed

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

hokein added a comment. pfultz2@, could you rebase this patch? The check has been moved to bugprone. https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. > Fixed: http://llvm.org/PR36985 Nice ! The NetBSD version will benefit it as well (not sure it s really done in the frontend side). https://reviews.llvm.org/D45126 ___ cfe-commits mailing list

[PATCH] D45126: Xray, OpenBSD support

dberris accepted this revision. dberris added a comment. LGTM -- I'll defer to @brad on confirming and landing. https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

JonasToth added a comment. LGTM, but @aaron.ballman, @alexfh or someone else should review it before comitting. https://reviews.llvm.org/D45059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM modulo requested changes. There's a section in `NOTES.TXT` about the steps required for adding a header. Please update that to mention listing it in CMake.

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL329073: [clang-tidy] Check for sizeof that call functions (authored by hokein, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

hokein added a comment. Thanks, I have committed for you. Repository: rL LLVM https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44932: [CodeComplete] Fix completion in the middle of ident in ctor lists.

ilya-biryukov added a reviewer: arphaman. ilya-biryukov added a comment. +Alex, in case he might know someone who can review it. Repository: rC Clang https://reviews.llvm.org/D44932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

lebedev.ri updated this revision to Diff 140787. lebedev.ri added a comment. - Rebased - Silence both of the diagnostics in an unevaluated context. - Fixed `-Wself-assign-field` preexisting problems: - False-positives on `volatile` stores. - Do not warn in template instantiations. - Handle

[PATCH] D45128: [libcxx][test] Silence -Wself-assign diagnostics

lebedev.ri updated this revision to Diff 140788. lebedev.ri added a comment. The diagnostic was adjusted not to warn in an unevaluated context. The remaining diff will have to remain, unless you want to disable `-Wself-assign` altogether for tests... If there are remaining problems with this

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

JDevlieghere added a comment. @jingham is this safe to land? Comment at: lib/CodeGen/CGDebugInfo.cpp:2992 + std::string NameString = Name.str(); + llvm::raw_string_ostream ParameterizedName(NameString); + ParameterizedName << "<"; ormris wrote:

[clang-tools-extra] r329073 - [clang-tidy] Check for sizeof that call functions

Author: hokein Date: Tue Apr 3 08:10:24 2018 New Revision: 329073 URL: http://llvm.org/viewvc/llvm-project?rev=329073=rev Log: [clang-tidy] Check for sizeof that call functions Summary: A common mistake that I have found in our codebase is calling a function to get an integer or enum that

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

hokein added inline comments. Comment at: clangd/ClangdLSPServer.cpp:258 +if (!Items) + return replyError(ErrorCode::InvalidParams, +llvm::toString(Items.takeError())); `InvalidParams` doesn't match all cases where

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall updated this revision to Diff 140791. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D45006 Files: include/clang/Tooling/CompilationDatabase.h lib/Tooling/CMakeLists.txt

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

pfultz2 updated this revision to Diff 140790. pfultz2 added a comment. I have rebased. https://reviews.llvm.org/D44231 Files: clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tidy/bugprone/SizeofExpressionCheck.h docs/clang-tidy/checks/bugprone-sizeof-expression.rst

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:115 +for (auto F : getAllFiles()) + Paths.emplace_back(Strings.save(F), 0); +finalizeIndex(); ilya-biryukov wrote: > This class seems to do two somewhat

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. ping... Repository: rC Clang https://reviews.llvm.org/D43281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45168: [clang-format/ObjC] Do not insert space after opening brace of ObjC dict literal

This revision was automatically updated to reflect the committed changes. Closed by commit rL329069: [clang-format/ObjC] Do not insert space after opening brace of ObjC dict literal (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45169: [clang-format/ObjC] Do not detect "[]" as ObjC method expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL329070: [clang-format/ObjC] Do not detect [] as ObjC method expression (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall updated this revision to Diff 140792. sammccall added a comment. clang-format Repository: rC Clang https://reviews.llvm.org/D45006 Files: include/clang/Tooling/CompilationDatabase.h lib/Tooling/CMakeLists.txt lib/Tooling/InterpolatingCompilationDatabase.cpp

r329077 - [Hexagon] Remove -mhvx-double and the corresponding subtarget feature

Author: kparzysz Date: Tue Apr 3 08:59:10 2018 New Revision: 329077 URL: http://llvm.org/viewvc/llvm-project?rev=329077=rev Log: [Hexagon] Remove -mhvx-double and the corresponding subtarget feature Specifying the HVX vector length should be done via the -mhvx-length option. Modified:

r329069 - [clang-format/ObjC] Do not insert space after opening brace of ObjC dict literal

Author: benhamilton Date: Tue Apr 3 07:07:09 2018 New Revision: 329069 URL: http://llvm.org/viewvc/llvm-project?rev=329069=rev Log: [clang-format/ObjC] Do not insert space after opening brace of ObjC dict literal Summary: D44816 attempted to fix a few cases where `clang-format` incorrectly

r329070 - [clang-format/ObjC] Do not detect "[]" as ObjC method expression

Author: benhamilton Date: Tue Apr 3 07:07:11 2018 New Revision: 329070 URL: http://llvm.org/viewvc/llvm-project?rev=329070=rev Log: [clang-format/ObjC] Do not detect "[]" as ObjC method expression Summary: The following C++ code was being detected by `guessLanguage()` as Objective-C: #define

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall updated this revision to Diff 140802. sammccall added a comment. Add more tests, and only add -x when actually needed. Repository: rC Clang https://reviews.llvm.org/D45006 Files: include/clang/Tooling/CompilationDatabase.h lib/Tooling/CMakeLists.txt

[PATCH] D45212: [WIP][HIP] Let CUDA toolchain support HIP language mode

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: tpr, nhaehnle, jholewinski. This patch let CUDA toolchain support HIP language mode. It includes: Add offloading archs for amdgpu for CUDA/HIP. Add file type hip for toolchain. Create specific

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

jingham added a comment. @ormris Thanks! I you come up with some examples that test this, I can whip up an lldb test case (or you can if you are feeling adventurous.) If you want to try I'd be happy to give you a hand. Repository: rC Clang https://reviews.llvm.org/D44842

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

jingham added a comment. I don't know off the top of my head. Did anybody working on this patch try printing variables in lldb with this name change, particularly global variables? Global lookups are particularly tricky, but it shouldn't be hard to check. You'd want to check that you can

[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

tra added a comment. In https://reviews.llvm.org/D45061#1053795, @echristo wrote: > Let's talk about the rest of it more. I'm not sure I'm seeing the need here > rather than the annotations that are already here. Can you elaborate more > here on why we need an additional method when you've

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. @jingham Will do. Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +replyError(ErrorCode::MethodNotFound, OS.str()); ilya-biryukov wrote: > Could we also `log`

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. @jingham Doesn't look like it works. $ cat repro.cpp template T crazy = T(); int main(void) { crazy = 5; return crazy; } $ clang++ -g repro.cpp $ lldb a.out ... (lldb) frame variable (lldb) expr crazy error: use of undeclared identifier

RE: [PATCH] D44747: Set calling convention for CUDA kernel

I will try fixing that. The CUDA kernel calling convention should be dropped in all DRE's since it is invisible to the user. Sam -Original Message- From: Artem Belevich via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Tuesday, April 03, 2018 1:51 PM To: Liu, Yaxun (Sam)

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. No such luck... Patch: Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp === --- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp (revision 329079) +++

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

lebedev.ri added a comment. In https://reviews.llvm.org/D45163#1055856, @rjmccall wrote: > Well, we should feel welcome to submit patches to the C++ library > implementations, I think. I can understand why Marshall is waiting to just > do this until he gets a comprehensive committee paper,

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak abandoned this revision. ahatanak added a comment. This appears to have been fixed. https://reviews.llvm.org/D25001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added a comment. Glad you took another look. I don't want to yield, let's find another reviewer :) Comment at: clangd/FuzzyMatch.cpp:230 void FuzzyMatcher::buildGraph() { + Scores[0][0][Miss] = Scores[0][0][Match] = {0, Miss}; for (int W = 0; W < WordN; ++W) {

[libcxx] r329075 - Implement P0754R2: The header.

Author: marshall Date: Tue Apr 3 08:48:24 2018 New Revision: 329075 URL: http://llvm.org/viewvc/llvm-project?rev=329075=rev Log: Implement P0754R2: The header. Added: libcxx/trunk/include/version libcxx/trunk/test/libcxx/language.support/support.limits/version.pass.cpp

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +replyError(ErrorCode::MethodNotFound, OS.str()); simark wrote: > ilya-biryukov wrote: > >

[PATCH] D45217: [ThinLTO] Pass -save-temps to LTO backend for distributed ThinLTO builds

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: eraman, inglorion, mehdi_amini. The clang driver option -save-temps was not passed to the LTO config, so when invoking the ThinLTO backends via clang during distributed builds there was no way to get LTO

[PATCH] D44747: Set calling convention for CUDA kernel

tra added a comment. In https://reviews.llvm.org/D44747#1055894, @yaxunl wrote: > Let's revert it for now. I will create a review after fixing it and commit it > again with the fix. > > Thanks. > > Sam reverted in r329099. Repository: rL LLVM https://reviews.llvm.org/D44747

r329102 - [analyzer] Fix diagnostics in callees of interesting callees.

Author: dergachev Date: Tue Apr 3 11:52:30 2018 New Revision: 329102 URL: http://llvm.org/viewvc/llvm-project?rev=329102=rev Log: [analyzer] Fix diagnostics in callees of interesting callees. removeUnneededCalls() is responsible for removing path diagnostic pieces within functions that don't

[PATCH] D45117: [analyzer] Fix diagnostics in callees of interesting callees.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL329102: [analyzer] Fix diagnostics in callees of interesting callees. (authored by dergachev, committed by ). Herald

[PATCH] D45223: [CUDA] Fix overloading resolution failure due to kernel calling convention

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. The following test causes overloading resolution failure in clang due to missing kernel calling convention in the function pointer type. template __global__ void EmptyKernel(void) {} struct Dummy { /// Type

[PATCH] D45121: [coroutines] Add noop_coroutine to

GorNishanov added a comment. @EricWF , gentle ping. Super tini-tiny change. Last piece missing to be post-Jax 2018 compilant https://reviews.llvm.org/D45121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45069: [clangd] synthesize fix message when the diagnostic doesn't provide one.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329090: [clangd] synthesize fix message when the diagnostic doesnt provide one. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r329090 - [clangd] synthesize fix message when the diagnostic doesn't provide one.

Author: sammccall Date: Tue Apr 3 10:35:57 2018 New Revision: 329090 URL: http://llvm.org/viewvc/llvm-project?rev=329090=rev Log: [clangd] synthesize fix message when the diagnostic doesn't provide one. Summary: Currently if a fix is attached directly to a diagnostic, we repeat the diagnostic

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, looks good. Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. About to test with CPlusPlus14 enabled Here's the output from those two commands. (lldb) frame var -g crazy error: no variable named 'crazy' found in this frame (lldb) frame var -g crazy error: no variable named 'crazy' found in this frame (lldb)

r329099 - Revert "Set calling convention for CUDA kernel"

Author: tra Date: Tue Apr 3 11:29:31 2018 New Revision: 329099 URL: http://llvm.org/viewvc/llvm-project?rev=329099=rev Log: Revert "Set calling convention for CUDA kernel" This reverts r328795 which introduced an issue with referencing __global__ function templates. More details in the original

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45174: non-zero-length bit-fields should make a class non-empty

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: ReleaseNotes.rst:68-72 +- Clang implements the proposed resolution of LWG issue 2358, along with the + `corresponding change to the Itanium C++ ABI +

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

jingham added a comment. Apparently this makes a global variable, so "frame var" wouldn't show it by default. What does "frame var -g" show? We would also need to get: (lldb) frame var -g crazy or something like it to work. "frame var" has its own parser to support "->" and ".". That

[PATCH] D44747: Set calling convention for CUDA kernel

tra added inline comments. Comment at: lib/Sema/SemaType.cpp:3319-3330 + // Attribute AT_CUDAGlobal affects the calling convention for AMDGPU targets. + // This is the simplest place to infer calling convention for CUDA kernels. + if (S.getLangOpts().CUDA &&

[PATCH] D45161: [AST] Add new printing policy to suppress printing template arguments

khuttun abandoned this revision. khuttun added a comment. Figured out a better way to do this by using `FunctionDecl::getInstantiatedFromMemberFunction` Repository: rC Clang https://reviews.llvm.org/D45161 ___ cfe-commits mailing list

r329098 - Use Clang when referring to the project and clang when referring to the binary.

Author: rsmith Date: Tue Apr 3 11:28:13 2018 New Revision: 329098 URL: http://llvm.org/viewvc/llvm-project?rev=329098=rev Log: Use Clang when referring to the project and clang when referring to the binary. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

sammccall added a comment. Thanks for your work on this patch! I think there a several useful improvements here, which I'd love to see landed. Particularly the logic around matches that end early is much better. There are also places that change existing design decisions in ways that don't

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

rjmccall added a comment. Trust me, I understand that this is an important function, but a lot of functions are important, and we're not going to hardcode knowledge about all of them in the compiler. It seems reasonable to ask libc++ to use `__attribute__((warn_unused_result))` if

[PATCH] D45069: [clangd] synthesize fix message when the diagnostic doesn't provide one.

sammccall added inline comments. Comment at: clangd/Diagnostics.cpp:322 + StringRef Insert = FixIt.CodeToInsert; + if (!Invalid && Remove.size() + Insert.size() < 200) { +llvm::raw_svector_ostream M(Message); ilya-biryukov wrote: > I don't

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

rjmccall added a comment. Well, we should feel welcome to submit patches to the C++ library implementations, I think. I can understand why Marshall is waiting to just do this until he gets a comprehensive committee paper, but he might consider taking a patch in the meantime. But I'm not sure

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode

yaxunl updated this revision to Diff 140827. yaxunl retitled this revision from "[WIP][HIP] Let CUDA toolchain support HIP language mode" to "[HIP] Let CUDA toolchain support HIP language mode". yaxunl edited the summary of this revision. yaxunl added a comment. Fixed typo which causes lit test

[PATCH] D44747: Set calling convention for CUDA kernel

tra added inline comments. Comment at: lib/Sema/SemaType.cpp:3319-3330 + // Attribute AT_CUDAGlobal affects the calling convention for AMDGPU targets. + // This is the simplest place to infer calling convention for CUDA kernels. + if (S.getLangOpts().CUDA &&

[PATCH] D44747: Set calling convention for CUDA kernel

tra added a comment. In https://reviews.llvm.org/D44747#1055877, @yaxunl wrote: > I will try fixing that. > > The CUDA kernel calling convention should be dropped in all DRE's since it is > invisible to the user. > > Sam Apparently it's not always the case. Here's a bit more elaborate example

RE: [PATCH] D44747: Set calling convention for CUDA kernel

Let's revert it for now. I will create a review after fixing it and commit it again with the fix. Thanks. Sam -Original Message- From: Artem Belevich via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Tuesday, April 03, 2018 2:09 PM To: Liu, Yaxun (Sam) ;

r329097 - Restrict a test using named file descriptors to using the system shell

Author: dblaikie Date: Tue Apr 3 11:22:14 2018 New Revision: 329097 URL: http://llvm.org/viewvc/llvm-project?rev=329097=rev Log: Restrict a test using named file descriptors to using the system shell Modified: cfe/trunk/test/Misc/dev-fd-fs.c Modified: cfe/trunk/test/Misc/dev-fd-fs.c URL:

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

Quuxplusone added inline comments. Comment at: test/libcxx/diagnostics/force_nodiscard.fail.cpp:15 +// MODULES_DEFINES: _LIBCPP_FORCE_NODISCARD +#define _LIBCPP_FORCE_NODISCARD +#include <__config> What is the purpose of `_LIBCPP_FORCE_NODISCARD`? On one of your

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

Quuxplusone added a comment. In https://reviews.llvm.org/D45163#1055957, @lebedev.ri wrote: > In https://reviews.llvm.org/D45163#1055856, @rjmccall wrote: > > > Well, we should feel welcome to submit patches to the C++ library > > implementations, I think. I can understand why Marshall is

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

lebedev.ri added inline comments. Comment at: test/libcxx/diagnostics/force_nodiscard.fail.cpp:15 +// MODULES_DEFINES: _LIBCPP_FORCE_NODISCARD +#define _LIBCPP_FORCE_NODISCARD +#include <__config> Quuxplusone wrote: > What is the purpose of

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 140857. https://reviews.llvm.org/D44788 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c

r329110 - [driver][darwin] Do not infer -simulator environment for non-simulator SDKs

Author: arphaman Date: Tue Apr 3 13:50:05 2018 New Revision: 329110 URL: http://llvm.org/viewvc/llvm-project?rev=329110=rev Log: [driver][darwin] Do not infer -simulator environment for non-simulator SDKs rdar://36369832 Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp

Re: r329113 - Add REQUIRES: darwin-system to test/Driver/darwin-sdkroot.c

See my reply to the original commit, but I think this is the wrong fix. On Tue, Apr 3, 2018 at 2:13 PM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Tue Apr 3 14:10:26 2018 > New Revision: 329113 > > URL:

Re: r329110 - [driver][darwin] Do not infer -simulator environment for non-simulator SDKs

On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Tue Apr 3 13:50:05 2018 > New Revision: 329110 > > URL: http://llvm.org/viewvc/llvm-project?rev=329110=rev > Log: > [driver][darwin] Do not infer -simulator environment for

r329115 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Apr 3 14:31:50 2018 New Revision: 329115 URL: http://llvm.org/viewvc/llvm-project?rev=329115=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

lebedev.ri added a comment. In https://reviews.llvm.org/D45179#1056183, @rjmccall wrote: > Is Marshall arguing that the standard doesn't allow compilers to warn about > failing to use these function results prior to C++17? No. He was simply saying that people are opposed to having nodiscard

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

sammccall added a comment. In https://reviews.llvm.org/D44720#1055997, @MaskRay wrote: > Glad you took another look. I don't want to yield, let's find another > reviewer :) OK - the people with the most context on this particular code are ilya-biryukov and klimek (but klimek is out this

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added a comment. In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > Seems reasonable, looks good. Any opinion on the wording of the option name? Repository: rC Clang https://reviews.llvm.org/D45152 ___ cfe-commits mailing list

[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

craig.topper added inline comments. Comment at: test/Preprocessor/predefined-arch-macros.c:1164 +// CHECK_ICX_M32: #define __corei7 1 +// CHECK_ICX_M32: #define __corei7__ 1 +// CHECK_ICX_M32: #define __i386 1 The ICX_M32 and ICX_M64 should be contiguous in the

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

rjmccall added a comment. Is Marshall arguing that the standard doesn't allow compilers to warn about failing to use these function results prior to C++17? Because I don't think that's true; warnings are thoroughly non-normative. If libc++ wants to allow its users to opt out of these warnings

[PATCH] D45163: [Sema] -Wunused-value: diagnose unused std::move() call results.

lebedev.ri added a comment. In https://reviews.llvm.org/D45163#1056044, @rjmccall wrote: > It seems reasonable to ask libc++ to use > `__attribute__((warn_unused_result))` if `[[nodiscard]]` is unavailable. https://reviews.llvm.org/D45179 should hopefully add an **opt-in** define to allow

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

Quuxplusone added a comment. >> If we must have an opt-in/out mechanism (which I don't believe we do) > > Yes, we do. Opt-out is pre-existing, and removing it would be an > [unacceptable] regression. Ah, I see now that you weren't the originator of `_LIBCPP_DISABLE_NODISCARD_AFTER_CXX17`;

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

lebedev.ri added a comment. In https://reviews.llvm.org/D45179#1056108, @Quuxplusone wrote: > > Opt-in is an enhancement. Of course, it would be nice to always default it > > to on, but as it was disscussed with @mclow.lists, this is simply not going > > to happen. This is the best we'll get.

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo added a comment. In https://reviews.llvm.org/D45152#1056134, @rnk wrote: > In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote: > > > In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > > > > > Seems reasonable, looks good. > > > > > > Any opinion on the wording of the

r329113 - Add REQUIRES: darwin-system to test/Driver/darwin-sdkroot.c

Author: arphaman Date: Tue Apr 3 14:10:26 2018 New Revision: 329113 URL: http://llvm.org/viewvc/llvm-project?rev=329113=rev Log: Add REQUIRES: darwin-system to test/Driver/darwin-sdkroot.c The test from r329110 is for Darwin only Modified: cfe/trunk/test/Driver/darwin-sdkroot.c Modified:

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

craig.topper added inline comments. Comment at: include/clang/Basic/BuiltinsX86.def:951 TARGET_BUILTIN(__builtin_ia32_rndscalepd_mask, "V8dV8dIiV8dUcIi", "", "avx512f") +TARGET_BUILTIN(__builtin_ia32_floorps_mask, "V16fV16fV16fUs", "", "avx512f")

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

rnk added a comment. In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote: > In https://reviews.llvm.org/D45152#1055871, @rnk wrote: > > > Seems reasonable, looks good. > > > Any opinion on the wording of the option name? Maybe what we're trying to do is find the sysroot relative to

[PATCH] D45223: [CUDA] Fix overloading resolution failure due to kernel calling convention

rjmccall added a comment. I think the appropriate place to do this is in IsStandardConversion, immediately after the call to ResolveAddressOfOverloadedFunction. You might want to add a general utility for getting the type-of-reference of a function decl. https://reviews.llvm.org/D45223

  1   2   >